]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
USB: serial: remove redundant initializations of 'mos_parport'
authorColin Ian King <colin.king@canonical.com>
Wed, 17 Jan 2018 11:54:27 +0000 (11:54 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 22 Jan 2018 14:34:37 +0000 (15:34 +0100)
The pointer mos_parport is being initialized to pp->private_data and
then the assignment is duplicated after a spin lock.  Remove the
initialization as it occurs before the spin lock and it is a redundant
assignment.

Cleans up clang warnings:
drivers/usb/serial/mos7720.c:521:26: warning: Value stored to
'mos_parport' during its initialization is never read
drivers/usb/serial/mos7720.c:557:26: warning: Value stored to
'mos_parport' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/mos7720.c

index f4df3d5bf69c3f421de16c07c713f6d278f905cc..bd57630e67e2bbd2fcb26ede6b834a6074f88fbf 100644 (file)
@@ -518,7 +518,7 @@ static void parport_mos7715_write_control(struct parport *pp, unsigned char d)
 
 static unsigned char parport_mos7715_read_control(struct parport *pp)
 {
-       struct mos7715_parport *mos_parport = pp->private_data;
+       struct mos7715_parport *mos_parport;
        __u8 dcr;
 
        spin_lock(&release_lock);
@@ -554,7 +554,7 @@ static unsigned char parport_mos7715_frob_control(struct parport *pp,
 static unsigned char parport_mos7715_read_status(struct parport *pp)
 {
        unsigned char status;
-       struct mos7715_parport *mos_parport = pp->private_data;
+       struct mos7715_parport *mos_parport;
 
        spin_lock(&release_lock);
        mos_parport = pp->private_data;