]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
fs: completely ignore unknown open flags
authorChristoph Hellwig <hch@lst.de>
Thu, 27 Apr 2017 07:42:25 +0000 (09:42 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Fri, 11 Aug 2017 10:36:33 +0000 (12:36 +0200)
BugLink: http://bugs.launchpad.net/bugs/1705238
commit 629e014bb8349fcf7c1e4df19a842652ece1c945 upstream.

Currently we just stash anything we got into file->f_flags, and the
report it in fcntl(F_GETFD).  This patch just clears out all unknown
flags so that we don't pass them to the fs or report them.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
fs/open.c

index 6f06a8756896ec6eb3330f58b7f0a7a9870ee981..79e8d93b35c73c959fe257d5d7c0816294f17d62 100644 (file)
--- a/fs/open.c
+++ b/fs/open.c
@@ -890,6 +890,12 @@ static inline int build_open_flags(int flags, umode_t mode, struct open_flags *o
        int lookup_flags = 0;
        int acc_mode;
 
+       /*
+        * Clear out all open flags we don't know about so that we don't report
+        * them in fcntl(F_GETFD) or similar interfaces.
+        */
+       flags &= VALID_OPEN_FLAGS;
+
        if (flags & (O_CREAT | __O_TMPFILE))
                op->mode = (mode & S_IALLUGO) | S_IFREG;
        else