]> git.proxmox.com Git - mirror_qemu.git/commitdiff
arm/acpi: fix duplicated _UID of PCI interrupt link devices
authorHeyi Guo <guoheyi@huawei.com>
Tue, 4 Feb 2020 01:43:23 +0000 (09:43 +0800)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 13 Feb 2020 14:14:53 +0000 (14:14 +0000)
Using _UID of 0 for all PCI interrupt link devices absolutely violates
the spec. Simply increase one by one.

Signed-off-by: Heyi Guo <guoheyi@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-id: 20200204014325.16279-6-guoheyi@huawei.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/arm/virt-acpi-build.c

index 5d157a9dd5e95f5754b815aeaaa8e62366367484..f3e340b17290b6fa42c9b473ee987e48a552a00f 100644 (file)
@@ -189,7 +189,7 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
         uint32_t irqs =  irq + i;
         Aml *dev_gsi = aml_device("GSI%d", i);
         aml_append(dev_gsi, aml_name_decl("_HID", aml_string("PNP0C0F")));
-        aml_append(dev_gsi, aml_name_decl("_UID", aml_int(0)));
+        aml_append(dev_gsi, aml_name_decl("_UID", aml_int(i)));
         crs = aml_resource_template();
         aml_append(crs,
                    aml_interrupt(AML_CONSUMER, AML_LEVEL, AML_ACTIVE_HIGH,