]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
media: stm32-dcmi: simplify of_node_put usage
authorNicholas Mc Guire <hofrat@osadl.org>
Tue, 12 Jun 2018 17:23:16 +0000 (13:23 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 28 Jun 2018 11:49:29 +0000 (07:49 -0400)
This does not fix any bug - this is just a code simplification. As
np is not used after passing it to v4l2_fwnode_endpoint_parse() its
refcount can be decremented immediately and at one location.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/stm32/stm32-dcmi.c

index fcad6de06009bdeddc304e5319ccdb72ee6e5000..4f65f14fbbc1c40a9da4587bc3177973b3e8dc55 100644 (file)
@@ -1655,23 +1655,20 @@ static int dcmi_probe(struct platform_device *pdev)
        }
 
        ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(np), &ep);
+       of_node_put(np);
        if (ret) {
                dev_err(&pdev->dev, "Could not parse the endpoint\n");
-               of_node_put(np);
                return -ENODEV;
        }
 
        if (ep.bus_type == V4L2_MBUS_CSI2) {
                dev_err(&pdev->dev, "CSI bus not supported\n");
-               of_node_put(np);
                return -ENODEV;
        }
        dcmi->bus.flags = ep.bus.parallel.flags;
        dcmi->bus.bus_width = ep.bus.parallel.bus_width;
        dcmi->bus.data_shift = ep.bus.parallel.data_shift;
 
-       of_node_put(np);
-
        irq = platform_get_irq(pdev, 0);
        if (irq <= 0) {
                dev_err(&pdev->dev, "Could not get irq\n");