pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()' in case of error

'status' is known to be 0 at this point. It must be set to a meaningful
value in order to return an error code if one of the 'of_get_property()'
call fails.

Return -EINVAL in such a case.

Fixes: 2b571a066a2f("pcmcia: CompactFlash driver for PA Semi Electra boards")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>

diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c
index 35158cfd9c1a3c4fd5945cc3157c64a7165e08cb..40a5cffe24a4c5abb17aa5b56b1b05b8513b3428 100644 (file)
--- a/drivers/pcmcia/electra_cf.c
+++ b/drivers/pcmcia/electra_cf.c
@@ -229,6 +229,8 @@ static int electra_cf_probe(struct platform_device *ofdev)
 
        cf->socket.pci_irq = cf->irq;
 
+       status = -EINVAL;
+
        prop = of_get_property(np, "card-detect-gpio", NULL);
        if (!prop)
                goto fail1;