]> git.proxmox.com Git - mirror_qemu.git/commitdiff
block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR
authorMarkus Armbruster <armbru@redhat.com>
Wed, 28 May 2014 09:17:03 +0000 (11:17 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 30 May 2014 12:26:54 +0000 (14:26 +0200)
Introduced in commit a8d8ecb.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/qapi.c

index 75f44f15371d8b21fa5fc11fdb35433d51065ae8..97e16418ef4e79610c942a14415ecbea35132b53 100644 (file)
@@ -475,6 +475,7 @@ static void dump_qobject(fprintf_function func_fprintf, void *f,
         case QTYPE_QERROR: {
             QString *value = qerror_human((QError *)obj);
             func_fprintf(f, "%s", qstring_get_str(value));
+            QDECREF(value);
             break;
         }
         case QTYPE_NONE: