]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
regulator: arizona-ldo1: Rely on core to handle GPIO descriptor
authorLinus Walleij <linus.walleij@linaro.org>
Tue, 11 Dec 2018 09:53:19 +0000 (10:53 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 12 Dec 2018 16:49:36 +0000 (16:49 +0000)
After making sure that the regulator core always take over
handling of the GPIO descriptors, the gpiod_put()
on the errorpath of the Arizona LDO1 driver becomes
redundant.

Reported-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/arizona-ldo1.c

index 9a72eae4926d5ceabad10d478851bedb604bfef1..b9a93049e41ee7b2ccddf7940e82d6b09ddc6911 100644 (file)
@@ -283,9 +283,6 @@ static int arizona_ldo1_common_init(struct platform_device *pdev,
        of_node_put(config.of_node);
 
        if (IS_ERR(ldo1->regulator)) {
-               if (config.ena_gpiod)
-                       gpiod_put(config.ena_gpiod);
-
                ret = PTR_ERR(ldo1->regulator);
                dev_err(&pdev->dev, "Failed to register LDO1 supply: %d\n",
                        ret);