]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
reset: brcmstb-rescal: fix incorrect polarity of status bit
authorJim Quinlan <jim2101024@gmail.com>
Tue, 14 Sep 2021 22:11:21 +0000 (15:11 -0700)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Tue, 5 Oct 2021 08:48:56 +0000 (10:48 +0200)
The readl_poll_timeout() should complete when the status bit
is a 1, not 0.

Fixes: 4cf176e52397 ("reset: Add Broadcom STB RESCAL reset controller")
Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20210914221122.62315-1-f.fainelli@gmail.com
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/reset/reset-brcmstb-rescal.c

index b6f074d6a65f8c34686712c96a150a32dc9b3386..433fa0c40e477f8770229aeeb48c7c90a63c222e 100644 (file)
@@ -38,7 +38,7 @@ static int brcm_rescal_reset_set(struct reset_controller_dev *rcdev,
        }
 
        ret = readl_poll_timeout(base + BRCM_RESCAL_STATUS, reg,
-                                !(reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
+                                (reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
        if (ret) {
                dev_err(data->dev, "time out on SATA/PCIe rescal\n");
                return ret;