]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
drm/nouveau/nouveau: fix incorrect sizeof on args.src an args.dst
authorColin Ian King <colin.king@canonical.com>
Fri, 29 Nov 2019 16:28:28 +0000 (16:28 +0000)
committerBen Skeggs <bskeggs@redhat.com>
Wed, 15 Jan 2020 00:49:58 +0000 (10:49 +1000)
The sizeof is currently on args.src and args.dst and should be on
*args.src and *args.dst. Fortunately these sizes just so happen
to be the same size so it worked, however, this should be fixed
and it also cleans up static analysis warnings

Addresses-Coverity: ("sizeof not portable")
Fixes: f268307ec7c7 ("nouveau: simplify nouveau_dmem_migrate_vma")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nouveau_dmem.c

index fa14399415965efc6a607d140ba8e06b60f2c972..0ad5d87b5a8e57d6a093594476772ce8be3a6143 100644 (file)
@@ -635,10 +635,10 @@ nouveau_dmem_migrate_vma(struct nouveau_drm *drm,
        unsigned long c, i;
        int ret = -ENOMEM;
 
-       args.src = kcalloc(max, sizeof(args.src), GFP_KERNEL);
+       args.src = kcalloc(max, sizeof(*args.src), GFP_KERNEL);
        if (!args.src)
                goto out;
-       args.dst = kcalloc(max, sizeof(args.dst), GFP_KERNEL);
+       args.dst = kcalloc(max, sizeof(*args.dst), GFP_KERNEL);
        if (!args.dst)
                goto out_free_src;