]> git.proxmox.com Git - ovs.git/commitdiff
vlog: Make "vlog/set" without args set everything to "dbg".
authorJustin Pettit <jpettit@ovn.org>
Wed, 5 Jul 2017 06:34:34 +0000 (23:34 -0700)
committerJustin Pettit <jpettit@ovn.org>
Sat, 15 Jul 2017 20:43:22 +0000 (13:43 -0700)
The documentation stated that "ovs-appctl vlog/set" without any
arguments should set every module and destination to debug level.

Signed-off-by: Justin Pettit <jpettit@ovn.org>
Acked-by: Ben Pfaff <blp@ovn.org>
lib/vlog.c

index 2a60ca34a48da6c6856fe369c0f9ccdd6bf927ae..08b57b6f5eeaed8d40d66b5996447e0d2eedad1e 100644 (file)
@@ -631,6 +631,10 @@ vlog_unixctl_set(struct unixctl_conn *conn, int argc, const char *argv[],
 {
     int i;
 
+    /* With no argument, set all destinations and modules to "dbg". */
+    if (argc == 1) {
+        vlog_set_levels(NULL, VLF_ANY_DESTINATION, VLL_DBG);
+    }
     for (i = 1; i < argc; i++) {
         char *msg = vlog_set_levels_from_string(argv[i]);
         if (msg) {
@@ -791,7 +795,7 @@ vlog_init(void)
 
         unixctl_command_register(
             "vlog/set", "{spec | PATTERN:destination:pattern}",
-            1, INT_MAX, vlog_unixctl_set, NULL);
+            0, INT_MAX, vlog_unixctl_set, NULL);
         unixctl_command_register("vlog/list", "", 0, 0, vlog_unixctl_list,
                                  NULL);
         unixctl_command_register("vlog/list-pattern", "", 0, 0,