iio: dac: Convert powerdown read callbacks to sysfs_emit()

Update DAC drivers powerdown attribute show callback to use the new
sysfs_emit() function.

sysfs_emit() is preferred over raw s*printf() for sysfs attributes since it
knows about the sysfs buffer specifics and has some built-in sanity checks.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20210320071405.9347-5-lars@metafoo.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/dac/ad5064.c b/drivers/iio/dac/ad5064.c
index 82abd4d6886cfe7668e61b2436aa054c52939d35..dff623b65e4f1214e9a337579eb1fbb0466fadf4 100644 (file)
--- a/drivers/iio/dac/ad5064.c
+++ b/drivers/iio/dac/ad5064.c
@@ -277,7 +277,7 @@ static ssize_t ad5064_read_dac_powerdown(struct iio_dev *indio_dev,
 {
        struct ad5064_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", st->pwr_down[chan->channel]);
+       return sysfs_emit(buf, "%d\n", st->pwr_down[chan->channel]);
 }
 
 static ssize_t ad5064_write_dac_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/ad5360.c b/drivers/iio/dac/ad5360.c
index 602dd2ba61b552d4eafd5af0fbdd19d3b56aafa7..2d3b14c407d838f70aa87809acb414ecace27493 100644 (file)
--- a/drivers/iio/dac/ad5360.c
+++ b/drivers/iio/dac/ad5360.c
@@ -255,7 +255,7 @@ static ssize_t ad5360_read_dac_powerdown(struct device *dev,
        struct iio_dev *indio_dev = dev_to_iio_dev(dev);
        struct ad5360_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", (bool)(st->ctrl & AD5360_SF_CTRL_PWR_DOWN));
+       return sysfs_emit(buf, "%d\n", (bool)(st->ctrl & AD5360_SF_CTRL_PWR_DOWN));
 }
 
 static int ad5360_update_ctrl(struct iio_dev *indio_dev, unsigned int set,

diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
index 37ef653564b0a29d62e0f05b1beba1ee0ba3070b..53db5b4e4c53cad75fd94891f3fee682d8aa0101 100644 (file)
--- a/drivers/iio/dac/ad5380.c
+++ b/drivers/iio/dac/ad5380.c
@@ -85,7 +85,7 @@ static ssize_t ad5380_read_dac_powerdown(struct iio_dev *indio_dev,
 {
        struct ad5380_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", st->pwr_down);
+       return sysfs_emit(buf, "%d\n", st->pwr_down);
 }
 
 static ssize_t ad5380_write_dac_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
index d87e21016863c5b2e2a31df75e4dff8edd8a6109..488ec69967d671f842d6e89591a69508ac806064 100644 (file)
--- a/drivers/iio/dac/ad5446.c
+++ b/drivers/iio/dac/ad5446.c
@@ -100,7 +100,7 @@ static ssize_t ad5446_read_dac_powerdown(struct iio_dev *indio_dev,
 {
        struct ad5446_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", st->pwr_down);
+       return sysfs_emit(buf, "%d\n", st->pwr_down);
 }
 
 static ssize_t ad5446_write_dac_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c
index f383bdcdc12185cc15decaeef843ea9d759cd79d..19cdf9890d02ecb70e0abd68ecb3ae13e4b1946e 100644 (file)
--- a/drivers/iio/dac/ad5504.c
+++ b/drivers/iio/dac/ad5504.c
@@ -170,8 +170,8 @@ static ssize_t ad5504_read_dac_powerdown(struct iio_dev *indio_dev,
 {
        struct ad5504_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n",
-                       !(st->pwr_down_mask & (1 << chan->channel)));
+       return sysfs_emit(buf, "%d\n",
+                         !(st->pwr_down_mask & (1 << chan->channel)));
 }
 
 static ssize_t ad5504_write_dac_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/ad5624r_spi.c b/drivers/iio/dac/ad5624r_spi.c
index 2b2b8edfd258cb311ee2126bd609356496959917..9bde8698291211b09bf3f471994e3384764b0765 100644 (file)
--- a/drivers/iio/dac/ad5624r_spi.c
+++ b/drivers/iio/dac/ad5624r_spi.c
@@ -117,8 +117,8 @@ static ssize_t ad5624r_read_dac_powerdown(struct iio_dev *indio_dev,
 {
        struct ad5624r_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n",
-                       !!(st->pwr_down_mask & (1 << chan->channel)));
+       return sysfs_emit(buf, "%d\n",
+                         !!(st->pwr_down_mask & (1 << chan->channel)));
 }
 
 static ssize_t ad5624r_write_dac_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
index 99a95282ac577bc92f38f3f2e7c8df5489ca69b3..fcb64f20ff64d182af02afd97f4e32f0589c253c 100644 (file)
--- a/drivers/iio/dac/ad5686.c
+++ b/drivers/iio/dac/ad5686.c
@@ -57,7 +57,7 @@ static ssize_t ad5686_read_dac_powerdown(struct iio_dev *indio_dev,
 {
        struct ad5686_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", !!(st->pwr_down_mask &
+       return sysfs_emit(buf, "%d\n", !!(st->pwr_down_mask &
                                       (0x3 << (chan->channel * 2))));
 }
 

diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
index 0df28acf074a858cd3c3f73611eedb7ca449af29..cabc38d540854bf6d36ed44a664c72a993cc3f7a 100644 (file)
--- a/drivers/iio/dac/ad5755.c
+++ b/drivers/iio/dac/ad5755.c
@@ -399,8 +399,8 @@ static ssize_t ad5755_read_powerdown(struct iio_dev *indio_dev, uintptr_t priv,
 {
        struct ad5755_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n",
-                      (bool)(st->pwr_down & (1 << chan->channel)));
+       return sysfs_emit(buf, "%d\n",
+                         (bool)(st->pwr_down & (1 << chan->channel)));
 }
 
 static ssize_t ad5755_write_powerdown(struct iio_dev *indio_dev, uintptr_t priv,

diff --git a/drivers/iio/dac/ad5758.c b/drivers/iio/dac/ad5758.c
index bd9ac8359d986c6776f7642014017cd20aec90af..0572ef518101283c56063f1c370cbd217933f25e 100644 (file)
--- a/drivers/iio/dac/ad5758.c
+++ b/drivers/iio/dac/ad5758.c
@@ -574,7 +574,7 @@ static ssize_t ad5758_read_powerdown(struct iio_dev *indio_dev,
 {
        struct ad5758_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", st->pwr_down);
+       return sysfs_emit(buf, "%d\n", st->pwr_down);
 }
 
 static ssize_t ad5758_write_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/ad5770r.c b/drivers/iio/dac/ad5770r.c
index 4e7a8ed83cc1cf642188d5b35c8289e30072d9f3..7ab2ccf908639744c876f828015799529733e9a2 100644 (file)
--- a/drivers/iio/dac/ad5770r.c
+++ b/drivers/iio/dac/ad5770r.c
@@ -433,7 +433,7 @@ static ssize_t ad5770r_read_dac_powerdown(struct iio_dev *indio_dev,
 {
        struct ad5770r_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", st->ch_pwr_down[chan->channel]);
+       return sysfs_emit(buf, "%d\n", st->ch_pwr_down[chan->channel]);
 }
 
 static ssize_t ad5770r_write_dac_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/ad5791.c b/drivers/iio/dac/ad5791.c
index 615d72cd59bcdc2a9116c8e017fcb0b3291ef92e..a0923b76e8b65dbb6210447a9af205b33b8c7340 100644 (file)
--- a/drivers/iio/dac/ad5791.c
+++ b/drivers/iio/dac/ad5791.c
@@ -177,7 +177,7 @@ static ssize_t ad5791_read_dac_powerdown(struct iio_dev *indio_dev,
 {
        struct ad5791_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", st->pwr_down);
+       return sysfs_emit(buf, "%d\n", st->pwr_down);
 }
 
 static ssize_t ad5791_write_dac_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
index dbb4645ab6b1776653106a33efbabe74c91f8d9d..e1b6a92df12fbb91ea5823ceef9658f3fe123642 100644 (file)
--- a/drivers/iio/dac/ad7303.c
+++ b/drivers/iio/dac/ad7303.c
@@ -65,7 +65,7 @@ static ssize_t ad7303_read_dac_powerdown(struct iio_dev *indio_dev,
 {
        struct ad7303_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", (bool)(st->config &
+       return sysfs_emit(buf, "%d\n", (bool)(st->config &
                AD7303_CFG_POWER_DOWN(chan->channel)));
 }
 

diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c
index 4002ed0868be92ad049ff5b1520ec76edfa1b197..53e4b887d372d693c155e17ab387c8645968ef40 100644 (file)
--- a/drivers/iio/dac/ltc2632.c
+++ b/drivers/iio/dac/ltc2632.c
@@ -135,8 +135,8 @@ static ssize_t ltc2632_read_dac_powerdown(struct iio_dev *indio_dev,
 {
        struct ltc2632_state *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n",
-                      !!(st->powerdown_cache_mask & (1 << chan->channel)));
+       return sysfs_emit(buf, "%d\n",
+                         !!(st->powerdown_cache_mask & (1 << chan->channel)));
 }
 
 static ssize_t ltc2632_write_dac_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/max5821.c b/drivers/iio/dac/max5821.c
index d6bb24db49c4132a362cecc87db8c669fc28b8fd..bd6e75699a636300a842a82457b9aae207699765 100644 (file)
--- a/drivers/iio/dac/max5821.c
+++ b/drivers/iio/dac/max5821.c
@@ -84,7 +84,7 @@ static ssize_t max5821_read_dac_powerdown(struct iio_dev *indio_dev,
 {
        struct max5821_data *st = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", st->powerdown[chan->channel]);
+       return sysfs_emit(buf, "%d\n", st->powerdown[chan->channel]);
 }
 
 static int max5821_sync_powerdown_mode(struct max5821_data *data,

diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
index beb9a15b7c74425cbb714529c53688fe4610f5ff..34b14aafb630188d0e1121cfae085fa8b8973506 100644 (file)
--- a/drivers/iio/dac/mcp4725.c
+++ b/drivers/iio/dac/mcp4725.c
@@ -167,7 +167,7 @@ static ssize_t mcp4725_read_powerdown(struct iio_dev *indio_dev,
 {
        struct mcp4725_data *data = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", data->powerdown);
+       return sysfs_emit(buf, "%d\n", data->powerdown);
 }
 
 static ssize_t mcp4725_write_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c
index 12dec68c16f71aa85f98e91e531acbddeaa3a495..a5b0a52bf86eb5687eb0f2062b129b66fe7b0f49 100644 (file)
--- a/drivers/iio/dac/stm32-dac.c
+++ b/drivers/iio/dac/stm32-dac.c
@@ -210,7 +210,7 @@ static ssize_t stm32_dac_read_powerdown(struct iio_dev *indio_dev,
        if (ret < 0)
                return ret;
 
-       return sprintf(buf, "%d\n", ret ? 0 : 1);
+       return sysfs_emit(buf, "%d\n", ret ? 0 : 1);
 }
 
 static ssize_t stm32_dac_write_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/ti-dac082s085.c b/drivers/iio/dac/ti-dac082s085.c
index de33c1fc6e0bd4492406036fe2e39ecac5add346..5c14bfb165219e4e37cb4753545507ef5081ae09 100644 (file)
--- a/drivers/iio/dac/ti-dac082s085.c
+++ b/drivers/iio/dac/ti-dac082s085.c
@@ -121,7 +121,7 @@ static ssize_t ti_dac_read_powerdown(struct iio_dev *indio_dev,
 {
        struct ti_dac_chip *ti_dac = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", ti_dac->powerdown);
+       return sysfs_emit(buf, "%d\n", ti_dac->powerdown);
 }
 
 static ssize_t ti_dac_write_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
index d3295767a079c83d210143c4c92252f41650a0f9..2a5ba1b08a1d0af6c6aea10ea016a93a95381781 100644 (file)
--- a/drivers/iio/dac/ti-dac5571.c
+++ b/drivers/iio/dac/ti-dac5571.c
@@ -166,7 +166,7 @@ static ssize_t dac5571_read_powerdown(struct iio_dev *indio_dev,
 {
        struct dac5571_data *data = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", data->powerdown[chan->channel]);
+       return sysfs_emit(buf, "%d\n", data->powerdown[chan->channel]);
 }
 
 static ssize_t dac5571_write_powerdown(struct iio_dev *indio_dev,

diff --git a/drivers/iio/dac/ti-dac7311.c b/drivers/iio/dac/ti-dac7311.c
index 63171e42f987a4417786f3c8fba132b6766fa74e..9d0b253be8413edd6b5d7bb520a9296b7807c0bd 100644 (file)
--- a/drivers/iio/dac/ti-dac7311.c
+++ b/drivers/iio/dac/ti-dac7311.c
@@ -110,7 +110,7 @@ static ssize_t ti_dac_read_powerdown(struct iio_dev *indio_dev,
 {
        struct ti_dac_chip *ti_dac = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d\n", ti_dac->powerdown);
+       return sysfs_emit(buf, "%d\n", ti_dac->powerdown);
 }
 
 static ssize_t ti_dac_write_powerdown(struct iio_dev *indio_dev,