]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
dpaa2-eth: don't print error from dpaa2_mac_connect if that's EPROBE_DEFER
authorVladimir Oltean <vladimir.oltean@nxp.com>
Fri, 21 May 2021 14:12:20 +0000 (17:12 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 May 2021 21:49:40 +0000 (14:49 -0700)
When booting a board with DPAA2 interfaces defined statically via DPL
(as opposed to creating them dynamically using restool), the driver will
print an unspecific error message.

This change adds the error code to the message, and avoids printing
altogether if the error code is EPROBE_DEFER, because that is not a
cause of alarm.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c

index e0c3c58e2ac73346c0fdcc665940ab61d317ebef..8433aa730c4219ffeace101f99dd65431a35f491 100644 (file)
@@ -4164,10 +4164,11 @@ static int dpaa2_eth_connect_mac(struct dpaa2_eth_priv *priv)
 
        if (dpaa2_eth_is_type_phy(priv)) {
                err = dpaa2_mac_connect(mac);
-               if (err) {
-                       netdev_err(priv->net_dev, "Error connecting to the MAC endpoint\n");
+               if (err && err != -EPROBE_DEFER)
+                       netdev_err(priv->net_dev, "Error connecting to the MAC endpoint: %pe",
+                                  ERR_PTR(err));
+               if (err)
                        goto err_close_mac;
-               }
        }
 
        return 0;