]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
batman-adv: Delete an unnecessary check before the function call "batadv_softif_vlan_...
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 3 Nov 2015 18:20:34 +0000 (19:20 +0100)
committerAntonio Quartulli <a@unstable.cc>
Sat, 9 Jan 2016 12:56:00 +0000 (20:56 +0800)
The batadv_softif_vlan_free_ref() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
net/batman-adv/translation-table.c

index ec67deff162101385c5c05af6ef213a582a290c2..5852fda9f1759f5d24f0781742c95f158fd0e849 100644 (file)
@@ -3356,8 +3356,7 @@ bool batadv_is_ap_isolated(struct batadv_priv *bat_priv, u8 *src, u8 *dst,
        ret = true;
 
 out:
-       if (vlan)
-               batadv_softif_vlan_free_ref(vlan);
+       batadv_softif_vlan_free_ref(vlan);
        if (tt_global_entry)
                batadv_tt_global_entry_free_ref(tt_global_entry);
        if (tt_local_entry)