]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
unicore32/stacktrace: Remove the pointless ULONG_MAX marker
authorThomas Gleixner <tglx@linutronix.de>
Wed, 10 Apr 2019 10:27:59 +0000 (12:27 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 14 Apr 2019 17:58:28 +0000 (19:58 +0200)
Terminating the last trace entry with ULONG_MAX is a completely pointless
exercise and none of the consumers can rely on it because it's
inconsistently implemented across architectures. In fact quite some of the
callers remove the entry and adjust stack_trace.nr_entries afterwards.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: Guan Xuetao <gxt@pku.edu.cn>
Link: https://lkml.kernel.org/r/20190410103644.036077691@linutronix.de
arch/unicore32/kernel/stacktrace.c

index 9976e767d51c2eca3803c1dd5f4210549ccf2dc1..e37da8c6837be5782ea968cbf96f379d88c905f9 100644 (file)
@@ -120,8 +120,6 @@ void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace)
        }
 
        walk_stackframe(&frame, save_trace, &data);
-       if (trace->nr_entries < trace->max_entries)
-               trace->entries[trace->nr_entries++] = ULONG_MAX;
 }
 
 void save_stack_trace(struct stack_trace *trace)