ovn-controller: Log chassis claiming lport only when changes occur.

With recent OVN commits, the logic for a chassis to claim
or release a logical port was consolidated.  This is a
good thing.  However, there was a logic change that
resulted in VLOG_INFO being generated every time on the
ovn-controller.  This patch changes the logic so that
VLOG_INFO is only generated when there is a change, for
example when the chassis claims an lport the first time.

Signed-off-by: Mickey Spiegel <mickeys.dev@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>

diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c
index feca4331ceadf65e5f6d4efdbfbae7e5a4068eb5..2f24e9dc7ac289cb58b0128290ced9c9770b4f38 100644 (file)
--- a/ovn/controller/binding.c
+++ b/ovn/controller/binding.c
@@ -372,17 +372,22 @@ consider_local_datapath(struct controller_ctx *ctx,
 
     if (ctx->ovnsb_idl_txn) {
         if (our_chassis) {
-            if (binding_rec->chassis) {
-                VLOG_INFO("Changing chassis for lport %s from %s to %s.",
-                          binding_rec->logical_port,
-                          binding_rec->chassis->name,
-                          chassis_rec->name);
-            }
-            for (int i = 0; i < binding_rec->n_mac; i++) {
-                VLOG_INFO("%s: Claiming %s",
-                          binding_rec->logical_port, binding_rec->mac[i]);
+            if (binding_rec->chassis != chassis_rec) {
+                if (binding_rec->chassis) {
+                    VLOG_INFO("Changing chassis for lport %s from %s to %s.",
+                              binding_rec->logical_port,
+                              binding_rec->chassis->name,
+                              chassis_rec->name);
+                } else {
+                    VLOG_INFO("Claiming lport %s for this chassis.",
+                              binding_rec->logical_port);
+                }
+                for (int i = 0; i < binding_rec->n_mac; i++) {
+                    VLOG_INFO("%s: Claiming %s",
+                              binding_rec->logical_port, binding_rec->mac[i]);
+                }
+                sbrec_port_binding_set_chassis(binding_rec, chassis_rec);
             }
-            sbrec_port_binding_set_chassis(binding_rec, chassis_rec);
         } else if (binding_rec->chassis == chassis_rec) {
             VLOG_INFO("Releasing lport %s from this chassis.",
                       binding_rec->logical_port);