]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
media: em28xx: Fix misplaced reset of dev->v4l::field_count
authorBen Hutchings <ben@decadent.org.uk>
Thu, 17 Jan 2019 00:25:58 +0000 (00:25 +0000)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
BugLink: https://bugs.launchpad.net/bugs/1837477
The backport of commit afeaade90db4 "media: em28xx: make
v4l2-compliance happier by starting sequence on zero" added a
reset on em28xx_v4l2::field_count to em28xx_enable_analog_tuner()
but it should be done in em28xx_start_analog_streaming().

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/media/usb/em28xx/em28xx-video.c

index 9c464e6d0c55051cede9e8acbb9059bd9dc13096..6cd47080c768a0a4b850187672ddedc3658ceee8 100644 (file)
@@ -900,8 +900,6 @@ static int em28xx_enable_analog_tuner(struct em28xx *dev)
        if (!mdev || !v4l2->decoder)
                return 0;
 
-       dev->v4l2->field_count = 0;
-
        /*
         * This will find the tuner that is connected into the decoder.
         * Technically, this is not 100% correct, as the device may be
@@ -1074,6 +1072,8 @@ int em28xx_start_analog_streaming(struct vb2_queue *vq, unsigned int count)
 
        em28xx_videodbg("%s\n", __func__);
 
+       dev->v4l2->field_count = 0;
+
        /* Make sure streaming is not already in progress for this type
           of filehandle (e.g. video, vbi) */
        rc = res_get(dev, vq->type);