]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
hsr: remove WARN_ONCE() in hsr_fill_frame_info()
authorTaehee Yoo <ap420073@gmail.com>
Wed, 6 May 2020 15:47:45 +0000 (15:47 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 May 2020 00:40:02 +0000 (17:40 -0700)
When VLAN frame is being sent, hsr calls WARN_ONCE() because hsr doesn't
support VLAN. But using WARN_ONCE() is overdoing.
Using netdev_warn_once() is enough.

Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/hsr/hsr_forward.c

index ddd9605bad04cbe35c5e247a3f8674c3428624ee..ed13760463decffabaad9144f1117dc6b7cb46c2 100644 (file)
@@ -321,7 +321,7 @@ static int hsr_fill_frame_info(struct hsr_frame_info *frame,
        if (ethhdr->h_proto == htons(ETH_P_8021Q)) {
                frame->is_vlan = true;
                /* FIXME: */
-               WARN_ONCE(1, "HSR: VLAN not yet supported");
+               netdev_warn_once(skb->dev, "VLAN not yet supported");
        }
        if (ethhdr->h_proto == htons(ETH_P_PRP) ||
            ethhdr->h_proto == htons(ETH_P_HSR)) {