]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
af_unix: fix struct pid memory leak
authorEric Dumazet <edumazet@google.com>
Sun, 24 Jan 2016 21:53:50 +0000 (13:53 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 25 Jan 2016 06:04:49 +0000 (22:04 -0800)
Dmitry reported a struct pid leak detected by a syzkaller program.

Bug happens in unix_stream_recvmsg() when we break the loop when a
signal is pending, without properly releasing scm.

Fixes: b3ca9b02b007 ("net: fix multithreaded signal handling in unix recv routines")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Rainer Weikusat <rweikusat@mobileactivedefense.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/unix/af_unix.c

index c5bf5ef2bf89476b6d7ab766b8591e6af2e869fd..49d5093eb0553a4416af09784b0e012f58cbd124 100644 (file)
@@ -2339,6 +2339,7 @@ again:
 
                        if (signal_pending(current)) {
                                err = sock_intr_errno(timeo);
+                               scm_destroy(&scm);
                                goto out;
                        }