]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
usb: Make use of ktime_* comparison functions
authorMariusz Skamra <mariuszx.skamra@intel.com>
Fri, 26 May 2017 10:15:59 +0000 (12:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Jun 2017 09:08:04 +0000 (18:08 +0900)
Start using ktime_* compare functions to make the code backportable.
Now that may be a bit tricky due to recent change of ktime_t.

Signed-off-by: Mariusz Skamra <mariuszx.skamra@intel.com>
Acked-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@intel.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/otg_fsm.c
drivers/usb/host/ehci-timer.c
drivers/usb/host/fotg210-hcd.c

index 93e24ce61a3ac6c3701ed117df2770287f63572a..949183ede16fb15f7e32f812a81696da8a2f05f1 100644 (file)
@@ -234,7 +234,7 @@ static void ci_otg_add_timer(struct ci_hdrc *ci, enum otg_fsm_timer t)
                                ktime_set(timer_sec, timer_nsec));
        ci->enabled_otg_timer_bits |= (1 << t);
        if ((ci->next_otg_timer == NUM_OTG_FSM_TIMERS) ||
-                       (ci->hr_timeouts[ci->next_otg_timer] >
+                       ktime_after(ci->hr_timeouts[ci->next_otg_timer],
                                                ci->hr_timeouts[t])) {
                        ci->next_otg_timer = t;
                        hrtimer_start_range_ns(&ci->otg_fsm_hrtimer,
@@ -269,7 +269,7 @@ static void ci_otg_del_timer(struct ci_hdrc *ci, enum otg_fsm_timer t)
                        for_each_set_bit(cur_timer, &enabled_timer_bits,
                                                        NUM_OTG_FSM_TIMERS) {
                                if ((next_timer == NUM_OTG_FSM_TIMERS) ||
-                                       (ci->hr_timeouts[next_timer] <
+                                       ktime_before(ci->hr_timeouts[next_timer],
                                         ci->hr_timeouts[cur_timer]))
                                        next_timer = cur_timer;
                        }
@@ -397,13 +397,13 @@ static enum hrtimer_restart ci_otg_hrtimer_func(struct hrtimer *t)
 
        now = ktime_get();
        for_each_set_bit(cur_timer, &enabled_timer_bits, NUM_OTG_FSM_TIMERS) {
-               if (now >= ci->hr_timeouts[cur_timer]) {
+               if (ktime_compare(now, ci->hr_timeouts[cur_timer]) >= 0) {
                        ci->enabled_otg_timer_bits &= ~(1 << cur_timer);
                        if (otg_timer_handlers[cur_timer])
                                ret = otg_timer_handlers[cur_timer](ci);
                } else {
                        if ((next_timer == NUM_OTG_FSM_TIMERS) ||
-                               (ci->hr_timeouts[cur_timer] <
+                               ktime_before(ci->hr_timeouts[cur_timer],
                                        ci->hr_timeouts[next_timer]))
                                next_timer = cur_timer;
                }
index 3893b5bafd8725a00ec4b32335a83c53fcef33a9..0b6cdb723192f22bf6522c9e9113eb2d13024b7a 100644 (file)
@@ -424,7 +424,7 @@ static enum hrtimer_restart ehci_hrtimer_func(struct hrtimer *t)
         */
        now = ktime_get();
        for_each_set_bit(e, &events, EHCI_HRTIMER_NUM_EVENTS) {
-               if (now >= ehci->hr_timeouts[e])
+               if (ktime_compare(now, ehci->hr_timeouts[e]) >= 0)
                        event_handlers[e](ehci);
                else
                        ehci_enable_event(ehci, e, false);
index ced08dc229ad02ef394816b657e7d5343b1d2e84..457cc6525abd6abd01ae39844aa62341356af691 100644 (file)
@@ -1380,7 +1380,7 @@ static enum hrtimer_restart fotg210_hrtimer_func(struct hrtimer *t)
         */
        now = ktime_get();
        for_each_set_bit(e, &events, FOTG210_HRTIMER_NUM_EVENTS) {
-               if (now >= fotg210->hr_timeouts[e])
+               if (ktime_compare(now, fotg210->hr_timeouts[e]) >= 0)
                        event_handlers[e](fotg210);
                else
                        fotg210_enable_event(fotg210, e, false);