]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
net: lan78xx: Bail out if lan78xx_get_endpoints fails
authorStefan Wahren <stefan.wahren@i2se.com>
Tue, 4 Sep 2018 17:29:09 +0000 (19:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Sep 2018 05:20:45 +0000 (22:20 -0700)
We need to bail out if lan78xx_get_endpoints() fails, otherwise the
result is overwritten.

Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Raghuram Chary Jallipalli <raghuramchary.jallipalli@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/lan78xx.c

index a9991c5f4736b6dd1e395527fbfeeecc3d0ab303..3f70b9426d8d46fb43e81bdefb83b0a1f342c698 100644 (file)
@@ -2952,6 +2952,11 @@ static int lan78xx_bind(struct lan78xx_net *dev, struct usb_interface *intf)
        int i;
 
        ret = lan78xx_get_endpoints(dev, intf);
+       if (ret) {
+               netdev_warn(dev->net, "lan78xx_get_endpoints failed: %d\n",
+                           ret);
+               return ret;
+       }
 
        dev->data[0] = (unsigned long)kzalloc(sizeof(*pdata), GFP_KERNEL);