ipmi: Fix memory leak in __ipmi_bmc_register

BugLink: https://bugs.launchpad.net/bugs/1863019
commit 4aa7afb0ee20a97fbf0c5bab3df028d5fb85fdab upstream.

In the impelementation of __ipmi_bmc_register() the allocated memory for
bmc should be released in case ida_simple_get() fails.

Fixes: 68e7e50f195f ("ipmi: Don't use BMC product/dev ids in the BMC name")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Message-Id: <20191021200649.1511-1-navid.emamdoost@gmail.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>

diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index f6c3f2ec49bd9afb24d018a2f5253bd7a4106b55..c88fc5cd4fc17df7c24fd4a0040253e85a304989 100644 (file)
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -3010,8 +3010,11 @@ static int __ipmi_bmc_register(ipmi_smi_t intf,
                bmc->pdev.name = "ipmi_bmc";
 
                rv = ida_simple_get(&ipmi_bmc_ida, 0, 0, GFP_KERNEL);
-               if (rv < 0)
+               if (rv < 0) {
+                       kfree(bmc);
                        goto out;
+               }
+
                bmc->pdev.dev.driver = &ipmidriver.driver;
                bmc->pdev.id = rv;
                bmc->pdev.dev.release = release_bmc_device;