]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
cpufreq: governor: Drop pointless goto from cpufreq_governor_init()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 8 Feb 2016 22:57:22 +0000 (23:57 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 9 Mar 2016 13:40:57 +0000 (14:40 +0100)
It is silly to jump around "return 0", so don't do that.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/cpufreq_governor.c

index 298be52adea00d12da2fed8f5fb4eb473a69bae1..d6bd402a3237ed4ef0f118160862eb536e222173 100644 (file)
@@ -395,12 +395,11 @@ static int cpufreq_governor_init(struct cpufreq_policy *policy)
 
        ret = sysfs_create_group(get_governor_parent_kobj(policy),
                                 get_sysfs_attr(gov));
-       if (ret)
-               goto reset_gdbs_data;
+       if (!ret)
+               return 0;
 
-       return 0;
+       /* Failure, so roll back. */
 
-reset_gdbs_data:
        policy->governor_data = NULL;
 
        if (!have_governor_per_policy())