]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
octeon: convert to use netdev_for_each_mc_addr
authorJiri Pirko <jpirko@redhat.com>
Tue, 23 Feb 2010 09:54:58 +0000 (09:54 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Feb 2010 10:08:33 +0000 (02:08 -0800)
Hmm so actually my original patch including this bit was correct,
"list = list->next;" confused me :) - will send patch correcting that in a few.

Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/octeon/octeon_mgmt.c

index 3a0f910924a51c34d222319a8207fc928badf33d..be368e5cbf7589a1897a6b8bd88f752767d928b2 100644 (file)
@@ -467,7 +467,6 @@ static void octeon_mgmt_set_rx_filtering(struct net_device *netdev)
 {
        struct octeon_mgmt *p = netdev_priv(netdev);
        int port = p->port;
-       int i;
        union cvmx_agl_gmx_rxx_adr_ctl adr_ctl;
        union cvmx_agl_gmx_prtx_cfg agl_gmx_prtx;
        unsigned long flags;
@@ -511,12 +510,8 @@ static void octeon_mgmt_set_rx_filtering(struct net_device *netdev)
                }
        }
        if (multicast_mode == 0) {
-               i = netdev_mc_count(netdev);
-               list = netdev->mc_list;
-               while (i--) {
+               netdev_for_each_mc_addr(list, netdev)
                        octeon_mgmt_cam_state_add(&cam_state, list->da_addr);
-                       list = list->next;
-               }
        }