]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
net-procfs: Use vsnprintf extension %phN
authorJoe Perches <joe@perches.com>
Fri, 2 Jun 2017 09:40:44 +0000 (02:40 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 4 Jun 2017 23:52:58 +0000 (19:52 -0400)
Save a bit of code by using the kernel extension.

$ size net/core/net-procfs.o*
   text    data     bss     dec     hex filename
   3701     120       0    3821     eed net/core/net-procfs.o.new
   3764     120       0    3884     f2c net/core/net-procfs.o.old

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/net-procfs.c

index 14d09345f00d96ca6a54328c3da2564a5d51044a..4847964931df62bd91cbe6057f73cd68081d62fb 100644 (file)
@@ -363,15 +363,10 @@ static int dev_mc_seq_show(struct seq_file *seq, void *v)
 
        netif_addr_lock_bh(dev);
        netdev_for_each_mc_addr(ha, dev) {
-               int i;
-
-               seq_printf(seq, "%-4d %-15s %-5d %-5d ", dev->ifindex,
-                          dev->name, ha->refcount, ha->global_use);
-
-               for (i = 0; i < dev->addr_len; i++)
-                       seq_printf(seq, "%02x", ha->addr[i]);
-
-               seq_putc(seq, '\n');
+               seq_printf(seq, "%-4d %-15s %-5d %-5d %*phN\n",
+                          dev->ifindex, dev->name,
+                          ha->refcount, ha->global_use,
+                          (int)dev->addr_len, ha->addr);
        }
        netif_addr_unlock_bh(dev);
        return 0;