]> git.proxmox.com Git - mirror_qemu.git/commitdiff
tests/qtest: device-plug-test: Reverse the usage of double/single quotes
authorBin Meng <bin.meng@windriver.com>
Wed, 24 Aug 2022 09:40:13 +0000 (17:40 +0800)
committerThomas Huth <thuth@redhat.com>
Mon, 29 Aug 2022 13:28:51 +0000 (15:28 +0200)
The usage of double/single quotes in test_pci_unplug_json_request()
should be reversed to work on both win32 and non-win32 platforms:

- The value of -device parameter needs to be surrounded by "" as
  Windows does not drop '' when passing it to QEMU which causes
  QEMU command line option parser failure.
- The JSON key/value pairs need to be surrounded by '' to make the
  JSON parser happy on Windows.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220824094029.1634519-36-bmeng.cn@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/qtest/device-plug-test.c

index 2e3137843e371db544dd0b4a0b2fb29393d3b088..a1fb99c8ff358883c8f34fc9bbc66e8fce73cdef 100644 (file)
@@ -95,7 +95,7 @@ static void test_pci_unplug_json_request(void)
     }
 
     QTestState *qtest = qtest_initf(
-        "%s -device '{\"driver\": \"virtio-mouse-pci\", \"id\": \"dev0\"}'",
+        "%s -device \"{'driver': 'virtio-mouse-pci', 'id': 'dev0'}\"",
         machine_addition);
 
     /*