]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/amdgpu: Fix driver reloading failure
authorXiangliang.Yu <Xiangliang.Yu@amd.com>
Thu, 21 Sep 2017 02:19:49 +0000 (10:19 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 26 Sep 2017 19:14:19 +0000 (15:14 -0400)
SRIOV doesn't implement PMC capability of PCIe, so it can't update
power state by reading PMC register.

Currently, amdgpu driver doesn't disable pci device when removing
driver, the enable_cnt of pci device will not be decrease to 0.
When reloading driver, pci_enable_device will do nothing as
enable_cnt is not zero. And power state will not be updated as PMC
is not support.
So current_state of pci device is not D0 state and pci_enable_msi
return fail.

Add pci_disable_device when remmoving driver to fix the issue.

Signed-off-by: Xiangliang.Yu <Xiangliang.Yu@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

index dee35a9c5723556cc3acb6208f54f75a8a437625..91e42b60d66b589170dc2c3de6cf43e007e06cb9 100644 (file)
@@ -609,6 +609,8 @@ amdgpu_pci_remove(struct pci_dev *pdev)
 
        drm_dev_unregister(dev);
        drm_dev_unref(dev);
+       pci_disable_device(pdev);
+       pci_set_drvdata(pdev, NULL);
 }
 
 static void