]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
riscv: Fix comment regarding kernel mapping overlapping with IS_ERR_VALUE
authorAlexandre Ghiti <alex@ghiti.fr>
Mon, 26 Jul 2021 05:42:54 +0000 (07:42 +0200)
committerPalmer Dabbelt <palmerdabbelt@google.com>
Thu, 12 Aug 2021 14:16:58 +0000 (07:16 -0700)
The current comment states that we check if the 64-bit kernel mapping
overlaps with the last 4K of the address space that is reserved to
error values in create_kernel_page_table, which is not the case since it
is done in setup_vm. But anyway, remove the reference to any function
and simply note that in 64-bit kernel, the check should be done as soon
as the kernel mapping base address is known.

Fixes: db6b84a368b4 ("riscv: Make sure the kernel mapping does not overlap with IS_ERR_VALUE")
Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
Cc: stable@vger.kernel.org
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
arch/riscv/mm/init.c

index 88134cc288d9a60b1a881a04315c413a0b7e1988..7cb4f391d106f4561250648144fb773584a70037 100644 (file)
@@ -197,7 +197,7 @@ static void __init setup_bootmem(void)
         * if end of dram is equal to maximum addressable memory.  For 64-bit
         * kernel, this problem can't happen here as the end of the virtual
         * address space is occupied by the kernel mapping then this check must
-        * be done in create_kernel_page_table.
+        * be done as soon as the kernel mapping base address is determined.
         */
        max_mapped_addr = __pa(~(ulong)0);
        if (max_mapped_addr == (phys_ram_end - 1))