]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
nvme/pci: Delete misleading queue-wrap comment
authorKeith Busch <keith.busch@intel.com>
Fri, 9 Dec 2016 17:08:58 +0000 (12:08 -0500)
committerChristoph Hellwig <hch@lst.de>
Wed, 21 Dec 2016 10:33:23 +0000 (11:33 +0100)
It is not theoretically possible for this driver to wrap twice while
processing completions. The driver allocates only 'queue_depth - 1'
tags, so there can never be more than that to reap when processing a
completion queue. Removing this misleading comment makes it a little
less likely people with broken controllers will blame the driver for
their spurious interrupts.

Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/pci.c

index 7d6c870285684147e5fcd6b3d6874e3a96077349..151ce59f4ffb394a19c651b1832be54105036cc2 100644 (file)
@@ -712,15 +712,8 @@ static void __nvme_process_cq(struct nvme_queue *nvmeq, unsigned int *tag)
                req = blk_mq_tag_to_rq(*nvmeq->tags, cqe.command_id);
                nvme_req(req)->result = cqe.result;
                blk_mq_complete_request(req, le16_to_cpu(cqe.status) >> 1);
-
        }
 
-       /* If the controller ignores the cq head doorbell and continuously
-        * writes to the queue, it is theoretically possible to wrap around
-        * the queue twice and mistakenly return IRQ_NONE.  Linux only
-        * requires that 0.1% of your interrupts are handled, so this isn't
-        * a big problem.
-        */
        if (head == nvmeq->cq_head && phase == nvmeq->cq_phase)
                return;