]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net: hns3: add a log for getting chain failure in hns3_nic_uninit_vector_data()
authorHuazhong Tan <tanhuazhong@huawei.com>
Thu, 19 Dec 2019 06:57:46 +0000 (14:57 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 21 Dec 2019 05:20:39 +0000 (21:20 -0800)
Since the mapping can be overwritten, when fail to get
the chain between vector and ring, we should go on to
deal with the remaining options. For debugging, this
patch adds log info for this failure.

Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

index 840a1fbc4d2e6d34b2a0087be20258248c527343..aee5facc89b5e1b77bdb9c1ca7bc341c5756a76f 100644 (file)
@@ -3602,7 +3602,12 @@ static void hns3_nic_uninit_vector_data(struct hns3_nic_priv *priv)
                if (!tqp_vector->rx_group.ring && !tqp_vector->tx_group.ring)
                        continue;
 
-               hns3_get_vector_ring_chain(tqp_vector, &vector_ring_chain);
+               /* Since the mapping can be overwritten, when fail to get the
+                * chain between vector and ring, we should go on to deal with
+                * the remaining options.
+                */
+               if (hns3_get_vector_ring_chain(tqp_vector, &vector_ring_chain))
+                       dev_warn(priv->dev, "failed to get ring chain\n");
 
                h->ae_algo->ops->unmap_ring_from_vector(h,
                        tqp_vector->vector_irq, &vector_ring_chain);