]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
spi: imx: Don't require platform data chipselect array
authorTrent Piepho <tpiepho@impinj.com>
Tue, 31 Oct 2017 19:49:06 +0000 (12:49 -0700)
committerMark Brown <broonie@kernel.org>
Fri, 10 Nov 2017 21:28:11 +0000 (21:28 +0000)
If the array is not present, assume all chip selects are native.  This
is the standard behavior for SPI masters configured via the device
tree and the behavior of this driver as well when it is configured via
device tree.

This reduces platform data vs DT differences and allows most of the
platform data based boards to remove their chip select arrays.

CC: Shawn Guo <shawnguo@kernel.org>
CC: Sascha Hauer <kernel@pengutronix.de>
CC: Fabio Estevam <fabio.estevam@nxp.com>
CC: Mark Brown <broonie@kernel.org>
Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-imx.c

index fdbbdac66839eafc3b3165c413f9a3afc7a8c416..79ddefe4180d6ccd643afd36e003af8997a8fa39 100644 (file)
@@ -1526,13 +1526,15 @@ static int spi_imx_probe(struct platform_device *pdev)
        /* Get number of chip selects, either platform data or OF */
        if (mxc_platform_info) {
                master->num_chipselect = mxc_platform_info->num_chipselect;
-               master->cs_gpios = devm_kzalloc(&master->dev,
-                       sizeof(int) * master->num_chipselect, GFP_KERNEL);
-               if (!master->cs_gpios)
-                       return -ENOMEM;
-
-               for (i = 0; i < master->num_chipselect; i++)
-                       master->cs_gpios[i] = mxc_platform_info->chipselect[i];
+               if (mxc_platform_info->chipselect) {
+                       master->cs_gpios = devm_kzalloc(&master->dev,
+                               sizeof(int) * master->num_chipselect, GFP_KERNEL);
+                       if (!master->cs_gpios)
+                               return -ENOMEM;
+
+                       for (i = 0; i < master->num_chipselect; i++)
+                               master->cs_gpios[i] = mxc_platform_info->chipselect[i];
+               }
        } else {
                u32 num_cs;