]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net/tls: tls_is_tx_ready() checked list_entry
authorPietro Borrello <borrello@diag.uniroma1.it>
Sat, 28 Jan 2023 16:29:17 +0000 (16:29 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 31 Jan 2023 05:06:08 +0000 (21:06 -0800)
tls_is_tx_ready() checks that list_first_entry() does not return NULL.
This condition can never happen. For empty lists, list_first_entry()
returns the list_entry() of the head, which is a type confusion.
Use list_first_entry_or_null() which returns NULL in case of empty
lists.

Fixes: a42055e8d2c3 ("net/tls: Add support for async encryption of records for performance")
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Link: https://lore.kernel.org/r/20230128-list-entry-null-check-tls-v1-1-525bbfe6f0d0@diag.uniroma1.it
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tls/tls_sw.c

index 9ed9786341259ea6dc4ed1a255f35534f9f902bf..a83d2b4275fa69a15931d193183f7ba7ed0fc935 100644 (file)
@@ -2427,7 +2427,7 @@ static bool tls_is_tx_ready(struct tls_sw_context_tx *ctx)
 {
        struct tls_rec *rec;
 
-       rec = list_first_entry(&ctx->tx_list, struct tls_rec, list);
+       rec = list_first_entry_or_null(&ctx->tx_list, struct tls_rec, list);
        if (!rec)
                return false;