]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
[media] VPU: mediatek: fix return value check in mtk_vpu_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 12 Jul 2016 11:00:55 +0000 (08:00 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 13 Jul 2016 10:59:52 +0000 (07:59 -0300)
In case of error, the function devm_clk_get() returns ERR_PTR()
and not returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/mtk-vpu/mtk_vpu.c

index b60d02c0f65362c82afe4ad8a75185903aff7b6f..c8b2c72e7c48032405c5fd2855a31d57e5a24dbf 100644 (file)
@@ -788,9 +788,9 @@ static int mtk_vpu_probe(struct platform_device *pdev)
 
        /* Get VPU clock */
        vpu->clk = devm_clk_get(dev, "main");
-       if (!vpu->clk) {
+       if (IS_ERR(vpu->clk)) {
                dev_err(dev, "get vpu clock failed\n");
-               return -EINVAL;
+               return PTR_ERR(vpu->clk);
        }
 
        platform_set_drvdata(pdev, vpu);