]> git.proxmox.com Git - proxmox-backup.git/log
proxmox-backup.git
3 years agoEdit section "Network Management"
Dylan Whyte [Wed, 2 Sep 2020 08:22:18 +0000 (10:22 +0200)]
Edit section "Network Management"

Following changes made:
    * Remove empty column "method6" from network list output,
      so table fits in console code-block
    * Walkthrough bond, rather than a bridge as it may be a more
      common setup case

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoPVE integration: Add note about hiding password
Dylan Whyte [Mon, 7 Sep 2020 15:38:36 +0000 (17:38 +0200)]
PVE integration: Add note about hiding password

Add a note to section "Proxmox VE integration" explaining
how to avoid passing password as plain text when using the
pvesm command.

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agochange order of "Image Archives" and "File Archives"
Dylan Whyte [Mon, 7 Sep 2020 15:28:48 +0000 (17:28 +0200)]
change order of "Image Archives" and "File Archives"

Change the order of the "Image Archives" and "File
Archives" subsections, so that they match the order
which they are introduced in, in the section "Backup
Content" (minor readability improvement).

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoSync Jobs: add screenshots and explanation
Dylan Whyte [Mon, 7 Sep 2020 15:21:12 +0000 (17:21 +0200)]
Sync Jobs: add screenshots and explanation

Add screenshots of sync jobs panel in web interface
and explain how to carry out related tasks from it.

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoNetwork Config: Add screenshots and explanation
Dylan Whyte [Mon, 7 Sep 2020 15:21:11 +0000 (17:21 +0200)]
Network Config: Add screenshots and explanation

Add screenshots for network configuration and explain
how to carry out related tasks using the web interface.

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoUser Management: Add screenshots and explanation
Dylan Whyte [Mon, 7 Sep 2020 15:21:10 +0000 (17:21 +0200)]
User Management: Add screenshots and explanation

Add screenshots for user management section in web
interface and explain how to carry out relevant tasks
using it.

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoDatastore Config: add screenshots and explanation
Dylan Whyte [Mon, 7 Sep 2020 15:21:09 +0000 (17:21 +0200)]
Datastore Config: add screenshots and explanation

Add screenshots from the datastore section of the
web interface and explain how to carry out tasks using
the web interface.

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoDisk Management: Add screenshots and explanation
Dylan Whyte [Mon, 7 Sep 2020 15:21:08 +0000 (17:21 +0200)]
Disk Management: Add screenshots and explanation

This adds screenshots from the web interface for the
sections related to disk management and adds explanation
of how to carry out tasks using the web interface.

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoAdd screenshots of web interface
Dylan Whyte [Mon, 7 Sep 2020 15:21:07 +0000 (17:21 +0200)]
Add screenshots of web interface

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agosrc/tools/systemd/time.rs: derive Clone
Dietmar Maurer [Mon, 7 Sep 2020 10:37:08 +0000 (12:37 +0200)]
src/tools/systemd/time.rs: derive Clone

3 years agoSYSTEMD_CALENDAR_EVENT_SCHEMA: fix wrong schema description
Dietmar Maurer [Mon, 7 Sep 2020 07:07:55 +0000 (09:07 +0200)]
SYSTEMD_CALENDAR_EVENT_SCHEMA: fix wrong schema description

3 years agotools/systemd/time: enable dates for calendarevents
Dominik Csapak [Fri, 4 Sep 2020 12:33:34 +0000 (14:33 +0200)]
tools/systemd/time: enable dates for calendarevents

this implements parsing and calculating calendarevents that have a
basic date component (year-mon-day) with the usual syntax options
(*, ranges, lists)

and some special events:
monthly
yearly/annually (like systemd)
quarterly
semiannually,semi-annually (like systemd)

includes some regression tests

the ~ syntax for days (the last x days of the month) is not yet
implemented

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agotools/systemd/time: fix signed conversion
Dominik Csapak [Fri, 4 Sep 2020 12:33:33 +0000 (14:33 +0200)]
tools/systemd/time: fix signed conversion

instead of using 'as' and silently converting wrong,
use the TryInto trait and raise an error if we cannot convert

this should only happen if we have a negative year,
but this is expected (we do not want schedules from before the year 0)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agotools/systemd/tm_editor: add setter/getter for months/years/days
Dominik Csapak [Fri, 4 Sep 2020 12:33:32 +0000 (14:33 +0200)]
tools/systemd/tm_editor: add setter/getter for months/years/days

add_* are modeled after add_days

subtract one for set_mon to have a consistent interface for all fields
(i.e. getter/setter return/expect the 'real' number, not the ones
in the tm struct)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agotools/systemd/tm_editor: move conversion of the year into getter and setter
Dominik Csapak [Fri, 4 Sep 2020 12:33:31 +0000 (14:33 +0200)]
tools/systemd/tm_editor: move conversion of the year into getter and setter

the tm struct contains the year - 1900 but we added that

if we want to use the libc normalization correctly, the tm struct
must have the correct year in it, else the computations for timezones,
etc. fail

instead add a getter that adds the years and a setter that subtracts it again

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agotools/systemd/time: fix selection for multiple options
Dominik Csapak [Fri, 4 Sep 2020 12:33:30 +0000 (14:33 +0200)]
tools/systemd/time: fix selection for multiple options

if we give multiple options/ranges for a value, e.g.
2,4,8
we always choose the biggest, instead of the smallest that is next

this happens because in DateTimeValue::find_next(value)
'next' can be set multiple times and we set it when the new
value was *bigger* than the last found 'next' value, when in reality
we have to choose the *smallest* next we can find

reverse the comparison operator to fix this

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agotools/systemd/parse_time: error out on invalid ranges
Dominik Csapak [Fri, 4 Sep 2020 12:33:29 +0000 (14:33 +0200)]
tools/systemd/parse_time: error out on invalid ranges

if the range is reverse (bigger..smaller) we will never find a value,
so error out during parsing

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agotools/systemd/tm_editor: remove reset_time from add_days and document it
Dominik Csapak [Fri, 4 Sep 2020 12:33:28 +0000 (14:33 +0200)]
tools/systemd/tm_editor: remove reset_time from add_days and document it

we never passed 'false' to it anyway so remove it
(we can add it again if we should ever need it)

also remove the adding of wday (gets normalized anyway)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agotools/systemd/time: convert the resulting timestamp into an option
Dominik Csapak [Fri, 4 Sep 2020 12:33:27 +0000 (14:33 +0200)]
tools/systemd/time: convert the resulting timestamp into an option

we want to use dates for the calendarspec, and with that there are some
impossible combinations that cannot be detected during parsing
(e.g. some datetimes do not exist in some timezones, and the timezone
can change after setting the schedule)

so finding no timestamp is not an error anymore but a valid result

we omit logging in that case (since it is not an error anymore)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agotools/systemd/time: move continue out of the if/else
Dominik Csapak [Fri, 4 Sep 2020 12:33:26 +0000 (14:33 +0200)]
tools/systemd/time: move continue out of the if/else

will be called anyway

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agotools/systemd/time: let libc normalize time for us
Dominik Csapak [Fri, 4 Sep 2020 12:33:25 +0000 (14:33 +0200)]
tools/systemd/time: let libc normalize time for us

mktime/gmtime can normalize time and even can handle special timezone
cases like the fact that the time 2:30 on specific day/timezone combos
do not exists

we have to convert the signature of all functions that use
normalize_time since mktime/gmtime can return an EOVERFLOW
but if this happens there is no way we can find a good time anyway

since normalize_time will always set wday according to the rest of the
time, remove set_wday

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agotools/systemd/tm_editor: remove TMChanges optimization
Dominik Csapak [Fri, 4 Sep 2020 12:33:24 +0000 (14:33 +0200)]
tools/systemd/tm_editor: remove TMChanges optimization

while it was correct, there was no measurable speed gain
(a benchmark yielded 2.8 ms for a spec that did not find a timestamp either way)
so remove it for simpler code

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agoserver/worker_task: fix 'unknown' status for some big task logs
Dietmar Maurer [Fri, 4 Sep 2020 08:41:13 +0000 (10:41 +0200)]
server/worker_task: fix 'unknown' status for some big task logs

when trying to parse the task status, we seek 8k from the end
which may be into the middle of a line, so the datetime parsing
can fail (when the log message contains ': ')

This patch does a fast search for the last line, and avoid the
'lines' iterator.

3 years agodepend on proxmox 0.3.5
Dietmar Maurer [Fri, 4 Sep 2020 06:11:53 +0000 (08:11 +0200)]
depend on proxmox 0.3.5

3 years agofix #2978: allow non-root to view datastore usage
Fabian Grünbichler [Thu, 3 Sep 2020 12:49:22 +0000 (14:49 +0200)]
fix #2978: allow non-root to view datastore usage

for datastores where the requesting user has read or write permissions,
since the API method itself filters by that already. this is the same
permission setting and filtering that the datastore list API endpoint
does.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
3 years agoonline help: use a phony target and regenerate
Thomas Lamprecht [Wed, 2 Sep 2020 12:41:03 +0000 (14:41 +0200)]
online help: use a phony target and regenerate

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agodocs: add prototype sphinx extension for online help
Oguz Bektas [Wed, 2 Sep 2020 12:22:36 +0000 (14:22 +0200)]
docs: add prototype sphinx extension for online help

goes through the sections in the documents and creates the
OnlineHelpInfo.js file from the explicitly defined section labels which
are used in the js files with 'onlineHelp' variable.

3 years agobump version to 0.8.14-1 v0.8.14
Thomas Lamprecht [Wed, 2 Sep 2020 07:36:56 +0000 (09:36 +0200)]
bump version to 0.8.14-1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agogc: improve percentage done logs
Dietmar Maurer [Wed, 2 Sep 2020 08:03:53 +0000 (10:03 +0200)]
gc: improve percentage done logs

3 years agoverify: also fail on server shutdown
Dietmar Maurer [Wed, 2 Sep 2020 07:50:17 +0000 (09:50 +0200)]
verify: also fail on server shutdown

3 years agoui: datastore content: eslint fixes
Thomas Lamprecht [Wed, 2 Sep 2020 07:15:53 +0000 (09:15 +0200)]
ui: datastore content: eslint fixes

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoui: datastore: show more granular verify state
Thomas Lamprecht [Wed, 2 Sep 2020 07:13:37 +0000 (09:13 +0200)]
ui: datastore: show more granular verify state

Allows to differ the following situations:
* some snapshots in a group where not verified
* how many snapshots failed to verify in a group
* all snapshots verified but last verification task was over 30 days
  ago

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoui: datastore: mark row invalid if last snapshot verification failed
Thomas Lamprecht [Wed, 2 Sep 2020 07:12:05 +0000 (09:12 +0200)]
ui: datastore: mark row invalid if last snapshot verification failed

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoverify: log progress
Dietmar Maurer [Wed, 2 Sep 2020 05:43:04 +0000 (07:43 +0200)]
verify: log progress

3 years agodatastore content: search: set emptytext to searched columns
Thomas Lamprecht [Tue, 1 Sep 2020 16:30:20 +0000 (18:30 +0200)]
datastore content: search: set emptytext to searched columns

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agodatastore content: reduce count column width
Thomas Lamprecht [Tue, 1 Sep 2020 16:28:12 +0000 (18:28 +0200)]
datastore content: reduce count column width

Using 75 as width we can display up to 9999999 which would allow
displaying over 19 years of snapshots done each minute, so quite
enough for the common cases.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agodatastore content: reload after verify
Thomas Lamprecht [Tue, 1 Sep 2020 16:27:30 +0000 (18:27 +0200)]
datastore content: reload after verify

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agod/postinst: always fixup termproxy user id and for all users
Stefan Reiter [Tue, 1 Sep 2020 14:50:18 +0000 (16:50 +0200)]
d/postinst: always fixup termproxy user id and for all users

Anyone with a PAM account and Sys.Console access could have started a
termproxy session, adapt the regex.

Always test for broken entries and run the sed expression to make sure
eventually all occurences of the broken syntax are fixed.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
3 years agoui: DataStoreContent.js: fix wrong comma
Dominik Csapak [Tue, 1 Sep 2020 09:05:21 +0000 (11:05 +0200)]
ui: DataStoreContent.js: fix wrong comma

should be semicolon

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agoui: DataStoreContent: improve encrypted column
Dominik Csapak [Tue, 1 Sep 2020 09:05:20 +0000 (11:05 +0200)]
ui: DataStoreContent: improve encrypted column

do not count files where we do not have any information

such files exist in the backup dir, but are not in the manifest
so we cannot use those files for determining if the backups are
encrypted or not

this marks encrypted/signed backups with unencrypted client.log.blob files as
encrypted/signed (respectively) instead of 'Mixed'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agosrc/backup/verify.rs: use global hashes (instead of per group)
Dietmar Maurer [Tue, 1 Sep 2020 11:33:04 +0000 (13:33 +0200)]
src/backup/verify.rs: use global hashes (instead of per group)

This makes verify more predictable.

3 years agosrc/backup/data_blob.rs: avoid useless &, data is already a reference
Dietmar Maurer [Tue, 1 Sep 2020 10:47:17 +0000 (12:47 +0200)]
src/backup/data_blob.rs: avoid useless &, data is already a reference

3 years agosrc/backup/verify.rs: use separate thread to load data
Dietmar Maurer [Tue, 1 Sep 2020 09:17:13 +0000 (11:17 +0200)]
src/backup/verify.rs: use separate thread to load data

3 years agodebian/control: fix versions
Dietmar Maurer [Tue, 1 Sep 2020 08:19:40 +0000 (10:19 +0200)]
debian/control: fix versions

3 years agodepend on proxmox 0.3.4
Dietmar Maurer [Fri, 28 Aug 2020 04:32:33 +0000 (06:32 +0200)]
depend on proxmox 0.3.4

3 years agobump version to 0.8.13-1 v0.8.13
Thomas Lamprecht [Thu, 27 Aug 2020 14:15:31 +0000 (16:15 +0200)]
bump version to 0.8.13-1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agogc: use human readable units for summary
Thomas Lamprecht [Thu, 27 Aug 2020 13:55:57 +0000 (15:55 +0200)]
gc: use human readable units for summary

and avoid the "percentage done: X %" phrase

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agobump pxar dep to 0.6.0
Wolfgang Bumiller [Thu, 27 Aug 2020 10:16:03 +0000 (12:16 +0200)]
bump pxar dep to 0.6.0

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
3 years agobin/backup-proxy: assert that daemon runs as backup user/group
Thomas Lamprecht [Wed, 26 Aug 2020 08:26:20 +0000 (10:26 +0200)]
bin/backup-proxy: assert that daemon runs as backup user/group

Because if not, the backups it creates have bogus permissions and may
seem like they got broken once the daemon is started again with the
correct user/group.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agobackup: add BACKUP_GROUP_NAME const and backup_group helper
Thomas Lamprecht [Wed, 26 Aug 2020 08:02:18 +0000 (10:02 +0200)]
backup: add BACKUP_GROUP_NAME const and backup_group helper

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agobin/backup-proxy: remove outdated perl comments
Thomas Lamprecht [Wed, 26 Aug 2020 08:25:42 +0000 (10:25 +0200)]
bin/backup-proxy: remove outdated perl comments

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agobin/backup-proxy: return error directly in main
Thomas Lamprecht [Wed, 26 Aug 2020 08:24:32 +0000 (10:24 +0200)]
bin/backup-proxy: return error directly in main

anyhow makes this a nice error message, similar to the manual
wrapping used.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoui: datastore content: show last verify result from a snapshot
Thomas Lamprecht [Tue, 25 Aug 2020 15:30:28 +0000 (17:30 +0200)]
ui: datastore content: show last verify result from a snapshot

Double-click on the verify grid-cell of a specific snapshot (not the
group) opens the relevant task log.

The date of the last verify is shown as tool-tip.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agosave last verify result in snapshot manifest
Thomas Lamprecht [Tue, 25 Aug 2020 15:30:27 +0000 (17:30 +0200)]
save last verify result in snapshot manifest

Save the state ("ok" or "failed") and the UPID of the respective
verify task. With this we can easily allow to open the relevant task
log and show when the last verify happened.

As we already load the manifest when listing the snapshots, just add
it there directly.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agovarious typo fixes
Thomas Lamprecht [Tue, 25 Aug 2020 16:52:31 +0000 (18:52 +0200)]
various typo fixes

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoSnapshotListItem: add comment field also to schema
Thomas Lamprecht [Tue, 25 Aug 2020 13:24:04 +0000 (15:24 +0200)]
SnapshotListItem: add comment field also to schema

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agotools/format: implement from u64 for HumanByte helper type
Thomas Lamprecht [Tue, 25 Aug 2020 12:18:48 +0000 (14:18 +0200)]
tools/format: implement from u64 for HumanByte helper type

Could be problematic for systems where usize is 32 bit, but we do not
really support those.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoapi datastore: fix typo in error message
Thomas Lamprecht [Tue, 25 Aug 2020 12:16:40 +0000 (14:16 +0200)]
api datastore: fix typo in error message

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoupdate d/control for pxar 0.5.0
Wolfgang Bumiller [Tue, 25 Aug 2020 10:37:06 +0000 (12:37 +0200)]
update d/control for pxar 0.5.0

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
3 years agobump pxar dep to 0.5.0
Wolfgang Bumiller [Tue, 25 Aug 2020 10:36:54 +0000 (12:36 +0200)]
bump pxar dep to 0.5.0

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
3 years agoAdd section "Garbage Collection"
Dylan Whyte [Mon, 24 Aug 2020 10:14:50 +0000 (12:14 +0200)]
Add section "Garbage Collection"

Add the section "Garbage Collection" to section "Backup Server
Management". This briefly explains the "garbage-collection"
subcommand of "proxmox-backup-manager"

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoAdd section "Network Management"
Dylan Whyte [Mon, 24 Aug 2020 10:13:50 +0000 (12:13 +0200)]
Add section "Network Management"

Add the section "Network Management", which explains the
"network" subcommand of "proxmox-backup-manager"

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoadd note about TLS benchmark test.
Dietmar Maurer [Tue, 25 Aug 2020 07:36:12 +0000 (09:36 +0200)]
add note about TLS benchmark test.

3 years agoAdd further explanation to benchmarking
Dylan Whyte [Mon, 24 Aug 2020 08:18:01 +0000 (10:18 +0200)]
Add further explanation to benchmarking

Adds a note, explaing the percentages shown in the output
of the benchmark

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoadministration-guide.rst: remove debug output from code examples
Dietmar Maurer [Tue, 25 Aug 2020 07:29:52 +0000 (09:29 +0200)]
administration-guide.rst: remove debug output from code examples

3 years agoAdd section "Disk Management"
Dylan Whyte [Mon, 24 Aug 2020 08:17:42 +0000 (10:17 +0200)]
Add section "Disk Management"

Add the section "Disk Management" to the admin guide, explaining
the use of the "disk" subcommand of "proxmox-backup-manager"

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agodebian/control: update for new pxar 0.4 dependency
Dietmar Maurer [Tue, 25 Aug 2020 07:09:00 +0000 (09:09 +0200)]
debian/control: update for new pxar 0.4 dependency

3 years agobump version to 0.8.12-1 v0.8.12
Dietmar Maurer [Tue, 25 Aug 2020 06:57:12 +0000 (08:57 +0200)]
bump version to 0.8.12-1

3 years agoverify: speedup - only verify chunks once
Dietmar Maurer [Tue, 25 Aug 2020 06:52:24 +0000 (08:52 +0200)]
verify: speedup - only verify chunks once

We need to do the check before we load the chunk.

3 years agoverify: sort backup groups
Dietmar Maurer [Tue, 25 Aug 2020 06:38:47 +0000 (08:38 +0200)]
verify: sort backup groups

3 years agobump pxar dep to 0.4.0
Wolfgang Bumiller [Mon, 24 Aug 2020 09:55:57 +0000 (11:55 +0200)]
bump pxar dep to 0.4.0

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
3 years agodocs: fix PBS wiki link
Thomas Lamprecht [Fri, 21 Aug 2020 09:09:39 +0000 (11:09 +0200)]
docs: fix PBS wiki link

rst/sphinx and comments are a PITA...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agobump version to 0.8.11-1 v0.8.11
Thomas Lamprecht [Wed, 19 Aug 2020 17:20:22 +0000 (19:20 +0200)]
bump version to 0.8.11-1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoFix typo in program output
Dylan Whyte [Tue, 18 Aug 2020 11:46:50 +0000 (13:46 +0200)]
Fix typo in program output

Change "comptation" -> "computation"

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agod/postinst: fixup userid for older termproxy tasks
Thomas Lamprecht [Tue, 18 Aug 2020 16:41:30 +0000 (18:41 +0200)]
d/postinst: fixup userid for older termproxy tasks

At the time when we can fix this up the new (and possibly an old)
server daemon process is running, so use the flock CLI tool from
util-linux to ensure we do the same locking as the server and thus we
avoid a race condition.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoAdd "Benchmarking" section
Dylan Whyte [Tue, 18 Aug 2020 10:52:24 +0000 (12:52 +0200)]
Add "Benchmarking" section

This adds the "Benchmarking" section which discusses
the proxmox-backup-client benchmark subcommand.

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoAdd section describing acl tool
Dylan Whyte [Tue, 18 Aug 2020 10:51:18 +0000 (12:51 +0200)]
Add section describing acl tool

This adds a section how to use the acl subcommand
to manage user access control

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoCorrect erroneous instructions and add clarity
Dylan Whyte [Tue, 18 Aug 2020 10:50:07 +0000 (12:50 +0200)]
Correct erroneous instructions and add clarity

This patch changes the following:
- Provide extra clarity to instruction and information where
  appropriate.
- Fix examples and content that would lead to erroneous behavior
  in a command.
- Insert section about installing on Debian into a caution block

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agominor language and formatting fixup
Dylan Whyte [Tue, 18 Aug 2020 10:48:49 +0000 (12:48 +0200)]
minor language and formatting fixup

this fixes minor grammatical errors throughout the pbs docs
and rewords certain sections for improved readability.

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
3 years agoturn UPID into an API type
Wolfgang Bumiller [Tue, 18 Aug 2020 07:04:21 +0000 (09:04 +0200)]
turn UPID into an API type

It's a string-type.
Implement Serialize via Display, Deserialize via FromStr and
add an API_SCHEMA so that it can be used as a type within
the #[api] macro.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
3 years agostyle fixups
Wolfgang Bumiller [Tue, 18 Aug 2020 06:50:14 +0000 (08:50 +0200)]
style fixups

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
3 years agoremove map_struct helper
Wolfgang Bumiller [Mon, 17 Aug 2020 09:53:01 +0000 (11:53 +0200)]
remove map_struct helper

if we ever need this it should be marked as unsafe!

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
3 years agoadd methods to allocate a DynamicIndexHeader
Wolfgang Bumiller [Mon, 17 Aug 2020 09:50:32 +0000 (11:50 +0200)]
add methods to allocate a DynamicIndexHeader

to avoid `map_struct` which is actually unsafe because it
does not verify alignment constraints at all

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
3 years agoapi2/node/services: turn service api calls into workers
Dominik Csapak [Fri, 14 Aug 2020 10:03:08 +0000 (12:03 +0200)]
api2/node/services: turn service api calls into workers

to be in line with pve/pmg and be able to show the progress in the gui

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agofix #2904: zpool status: parse vdevs with state but without statistics
Dominik Csapak [Thu, 30 Jul 2020 08:02:16 +0000 (10:02 +0200)]
fix #2904: zpool status: parse vdevs with state but without statistics

some vdevs (e.g. spares) have a 'state' (e.g. AVAIL), but
not statistics like READ/WRITE/etc.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agozfs status: add test with spares
Dominik Csapak [Thu, 30 Jul 2020 08:02:15 +0000 (10:02 +0200)]
zfs status: add test with spares

this will fail for now, fixed in the next commit

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agocleanup last patch
Dietmar Maurer [Fri, 14 Aug 2020 05:30:05 +0000 (07:30 +0200)]
cleanup last patch

3 years agoapi2/node/../disks/directory: added DELETE endpoint for removal of mount-units
Hannes Laimer [Thu, 13 Aug 2020 10:58:52 +0000 (12:58 +0200)]
api2/node/../disks/directory: added DELETE endpoint for removal of mount-units

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
3 years agoFix #2926: parse_iface_attributes: always break on non-{attribitue, comment} token
Fabian Ebner [Thu, 13 Aug 2020 13:04:12 +0000 (15:04 +0200)]
Fix #2926: parse_iface_attributes: always break on non-{attribitue, comment} token

There is no requirement to have at least
a blank line, attribute or comment in between two
interface definitions, e.g.
iface lo inet loopback
iface lo inet6 loopback

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
3 years agoconfig/jobstate: replace Job:load with create_state_file
Dominik Csapak [Thu, 13 Aug 2020 12:30:19 +0000 (14:30 +0200)]
config/jobstate: replace Job:load with create_state_file

it really is not necessary, since the only time we are interested in
loading the state from the file is when we list it, and there
we use JobState::load directly to avoid the lock

we still need to create the file on syncjob creation though, so
that we have the correct time for the schedule

to do this we add a new create_state_file that overwrites it on creation
of a syncjob

for safety, we subtract 30 seconds from the in-memory state in case
the statefile is missing

since we call create_state_file from  proxmox-backup-api,
we have to chown the lock file after creating to the backup user,
else the sync job scheduling cannot aquire the lock

also we remove the lock file on statefile removal

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agocleanup: replace id from do_sync_job with info from job
Dominik Csapak [Thu, 13 Aug 2020 12:30:18 +0000 (14:30 +0200)]
cleanup: replace id from do_sync_job with info from job

we already have it inside the job itself

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agocleanup: merge endtime into TaskState
Dominik Csapak [Thu, 13 Aug 2020 12:30:17 +0000 (14:30 +0200)]
cleanup: merge endtime into TaskState

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agoui: syncjob: make some columns smaller
Dominik Csapak [Thu, 13 Aug 2020 08:29:21 +0000 (10:29 +0200)]
ui: syncjob: make some columns smaller

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agoui: syncjob: improve task text rendering
Dominik Csapak [Thu, 13 Aug 2020 08:29:20 +0000 (10:29 +0200)]
ui: syncjob: improve task text rendering

to also have the correct icons for warnings and unknown tasks

the text is here "ERROR: ..." now, so leave the 'Error' out

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agosyncjob: use do_sync_job also for scheduled sync jobs
Dominik Csapak [Thu, 13 Aug 2020 08:29:19 +0000 (10:29 +0200)]
syncjob: use do_sync_job also for scheduled sync jobs

and determine the last runtime with the jobstate

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agoapi2/pull: extend do_sync_job to also handle schedule and jobstate
Dominik Csapak [Thu, 13 Aug 2020 08:29:18 +0000 (10:29 +0200)]
api2/pull: extend do_sync_job to also handle schedule and jobstate

so that we can log if triggered by a schedule, and writing to a jobstatefile
also correctly polls now the abort_future of the worker, so that
users can stop a sync

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agoapi/{pull, sync}: refactor to do_sync_job
Dominik Csapak [Thu, 13 Aug 2020 08:29:17 +0000 (10:29 +0200)]
api/{pull, sync}: refactor to do_sync_job

and move the pull parameters into the worker, so that the task log
contains the error if there is one

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agoapi2/admin/sync: use JobState for faster access to state info
Dominik Csapak [Thu, 13 Aug 2020 08:29:16 +0000 (10:29 +0200)]
api2/admin/sync: use JobState for faster access to state info

and delete the statefile again on syncjob removal

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agoconfig: add JobState helper
Dominik Csapak [Thu, 13 Aug 2020 08:29:15 +0000 (10:29 +0200)]
config: add JobState helper

this is intended to be a generic helper to (de)serialize job states
(e.g., sync, verify, and so on)

writes a json file into '/var/lib/proxmox-backup/jobstates/TYPE-ID.json'

the api creates the directory with the correct permissions, like
the rrd directory

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 years agoserver/worker_task: let upid_read_status also return the endtime
Dominik Csapak [Thu, 13 Aug 2020 08:29:14 +0000 (10:29 +0200)]
server/worker_task: let upid_read_status also return the endtime

the endtime should be the timestamp of the last log line
or if there is no log at all, the starttime

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>