]> git.proxmox.com Git - pve-manager.git/log
pve-manager.git
2 years agofix #3505: ui/UploadToStorage: add checksum and algorithm
Lorenz Stechauner [Mon, 8 Nov 2021 08:53:48 +0000 (09:53 +0100)]
fix #3505: ui/UploadToStorage: add checksum and algorithm

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: refactor UploadToStorage.js
Lorenz Stechauner [Mon, 8 Nov 2021 08:53:47 +0000 (09:53 +0100)]
ui: refactor UploadToStorage.js

this also removes the "content" selector from the window.
as far as it seems, this selector was never able to select
more than one entry, so it was useless.

the check for FormData() is also removed, because this is
supported by all major browsers for a long time. therefore
doStandardSubmit() is also not necessary.

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: move upload window into UploadToStorage.js
Lorenz Stechauner [Mon, 8 Nov 2021 08:53:46 +0000 (09:53 +0100)]
ui: move upload window into UploadToStorage.js

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agod/control: bump versioned dependency for pve-cluster
Thomas Lamprecht [Tue, 9 Nov 2021 17:35:12 +0000 (18:35 +0100)]
d/control: bump versioned dependency for pve-cluster

ensure we got the notes property for the datacenter config and also
the newly registered/watched jobs.cfg for future pveschedule patches.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: close #3504: Add datacenter notes
Dominic Jäger [Wed, 22 Sep 2021 10:42:18 +0000 (12:42 +0200)]
ui: close #3504: Add datacenter notes

Like notes for nodes.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agod/control: bump b-d/depends
Fabian Grünbichler [Tue, 9 Nov 2021 16:47:26 +0000 (17:47 +0100)]
d/control: bump b-d/depends

for replication and protection changes

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2 years agoui: prune: also handle new 'renamed' keep reason
Fabian Ebner [Thu, 30 Sep 2021 11:42:15 +0000 (13:42 +0200)]
ui: prune: also handle new 'renamed' keep reason

The back-end no longer returns 'protected' for renamed backups, and
'protected' backups are now their own kind.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: backup views: add button to change protection status
Fabian Ebner [Thu, 30 Sep 2021 11:42:14 +0000 (13:42 +0200)]
ui: backup views: add button to change protection status

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: backup views: add protected column
Fabian Ebner [Thu, 30 Sep 2021 11:42:13 +0000 (13:42 +0200)]
ui: backup views: add protected column

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: storage content: avoid redundant options hasNotesColumn and hideColumns
Fabian Ebner [Thu, 30 Sep 2021 11:42:12 +0000 (13:42 +0200)]
ui: storage content: avoid redundant options hasNotesColumn and hideColumns

Replace both by a showColumns option instead. As the current use of
hasNotesColumn already indicates, when new content-specific columns
are added, it is more natural for each derived class to specify the
columns it wants, rather than those it doesn't.

For hideColumns, there was no user. For hasNotesColumn, the only user
was the backup view.

Set the column information in the storage.BackupView class itself
rather than the instance (like hasNotesColumn was).

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agovzdump: skip protected backups for dumpdir pruning
Fabian Ebner [Thu, 30 Sep 2021 11:42:11 +0000 (13:42 +0200)]
vzdump: skip protected backups for dumpdir pruning

Keeps the behavior consistent with what happens for storages. It also
is required to not get into conflict with the check in archive_remove,
i.e. pruning here marks a backup as 'remove' and then archive_remove
complains that it's protected.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agotest: replication: remove mocking for obsolete volume_snapshot_list
Fabian Ebner [Tue, 19 Oct 2021 07:54:59 +0000 (09:54 +0200)]
test: replication: remove mocking for obsolete volume_snapshot_list

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agotest: replication: mock volume_snapshot_info
Fabian Ebner [Tue, 19 Oct 2021 07:54:58 +0000 (09:54 +0200)]
test: replication: mock volume_snapshot_info

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agotest: replication: avoid implicit return for volume_snapshot
Fabian Ebner [Tue, 19 Oct 2021 07:54:57 +0000 (09:54 +0200)]
test: replication: avoid implicit return for volume_snapshot

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: guest remove: modernize code and cleanup
Thomas Lamprecht [Tue, 9 Nov 2021 10:00:39 +0000 (11:00 +0100)]
ui: guest remove: modernize code and cleanup

drop only partially used intermediate value, use template strings,
reduce line bloat while trying to keep it readable.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: lxc: resources: add Detach text for mountpoints
Aaron Lauterer [Mon, 8 Nov 2021 09:56:12 +0000 (10:56 +0100)]
ui: lxc: resources: add Detach text for mountpoints

Instead of showing 'Remove' for a mountpoint, change the text to
'Detach' and only show 'Remove' for unused volumes.

This aligns the behaviour with VMs and will make it clear, that a
mountpoint first needs to be detached before it can be fully removed.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agobump version to 7.0-14
Thomas Lamprecht [Sun, 7 Nov 2021 20:23:14 +0000 (21:23 +0100)]
bump version to 7.0-14

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoceph: fix version check shortcut
Dominik Csapak [Fri, 5 Nov 2021 14:23:47 +0000 (15:23 +0100)]
ceph: fix version check shortcut

with 'get_node_kv', we get a hash which contains the value for
all nodes in the cluster (with the nodename as key), so we have to use
the value from the hash corresponding to our nodename.

also the 'str' property is inside the 'version' hash

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: join info: rework error handling/checking for no-cluster
Thomas Lamprecht [Sun, 7 Nov 2021 20:01:30 +0000 (21:01 +0100)]
ui: join info: rework error handling/checking for no-cluster

check if error is set before trying to access it and check for the
new HTTP code a newer pve-cluster may return, and do a more fuzzy
match for older ones.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: join info: code cleanup and future proof
Thomas Lamprecht [Sun, 7 Nov 2021 19:57:37 +0000 (20:57 +0100)]
ui: join info: code cleanup and future proof

we may want to return null or an empty object for the join info on a
node without a cluster in the future (i.e., PVE 8.0+), so get
compatible for that now already as it costs not much and as we can
now use es2020 we even can write the object access nicer..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: dc/Cluster: show errors on 'join' info in the view
Dominik Csapak [Fri, 29 Oct 2021 09:14:08 +0000 (11:14 +0200)]
ui: dc/Cluster: show errors on 'join' info in the view

so instead of getting the 'standalone node' message, the grid
is masked with the actual api error

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: guest backup grid: monitor store errors
Fabian Ebner [Fri, 22 Oct 2021 09:07:50 +0000 (11:07 +0200)]
ui: guest backup grid: monitor store errors

so that users see when something went wrong.

Don't mask the grid directly, but rather only its view so that the
title bar can be used for selecting another storage during load.

Reported in the community forum:
https://forum.proxmox.com/threads/get-backups-from-proxmox-randomly-fails.98383/

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: window/Wizard: make it a little wider
Dominik Csapak [Tue, 5 Oct 2021 11:29:03 +0000 (13:29 +0200)]
ui: window/Wizard: make it a little wider

for the multi disk panel, we want it to be just a little wider, so
that all form fields are still readable

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoui: add qemu/MultiHDEdit and use it in the wizard
Dominik Csapak [Tue, 5 Oct 2021 11:29:02 +0000 (13:29 +0200)]
ui: add qemu/MultiHDEdit and use it in the wizard

uses the MultiDiskPanel as base and implements the necessary
functions/variables

this allows now to create a vm also without any disk

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoui: add lxc/MultiMPEdit and use in lxc/CreateWizard
Dominik Csapak [Tue, 5 Oct 2021 11:29:01 +0000 (13:29 +0200)]
ui: add lxc/MultiMPEdit and use in lxc/CreateWizard

uses the MultiDiskPanel as a base and implements the necessary
functions/values

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoui: add MultiDiskPanel
Dominik Csapak [Tue, 5 Oct 2021 11:29:00 +0000 (13:29 +0200)]
ui: add MultiDiskPanel

this adds a new panel where a user can add multiple disks, intended
for use in the wizard.

Has a simple grid for displaying the already added disks and displays
a warning triangle if the disk is not valid.

this is a base panel for adding multiple disks/mps for vms/ct
respectively.

this combines the shared behavior and layout and defines the functions
that subclasses must define

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoui: lxc/MPEdit: add selectFree toggle
Dominik Csapak [Tue, 5 Oct 2021 11:28:59 +0000 (13:28 +0200)]
ui: lxc/MPEdit: add selectFree toggle

that sets the given vmconfig at the start and selects the first
free mpid

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoui: lxc/MPEdit: fire diskidchange event
Dominik Csapak [Tue, 5 Oct 2021 11:28:58 +0000 (13:28 +0200)]
ui: lxc/MPEdit: fire diskidchange event

when the diskid changes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoui: lxc/MPEdit: add updateVMConfig
Dominik Csapak [Tue, 5 Oct 2021 11:28:57 +0000 (13:28 +0200)]
ui: lxc/MPEdit: add updateVMConfig

helper for the upcoming MultiMPEdit

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoui: qemu/SystemEdit: add spacing and heading for 'firmware' options
Dominik Csapak [Wed, 3 Nov 2021 14:01:04 +0000 (15:01 +0100)]
ui: qemu/SystemEdit: add spacing and heading for 'firmware' options

So that they are more visually seperated from the rest of the options.
Use the same style as in the realm sync panel.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: storage/PBSEdit: do not send server on edit
Dominik Csapak [Thu, 28 Oct 2021 13:54:49 +0000 (15:54 +0200)]
ui: storage/PBSEdit: do not send server on edit

it's a fixed value for the storage config, so the api would reject it

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: storage/PBSEdit: add port to server field
Lorenz Stechauner [Mon, 11 Oct 2021 09:52:00 +0000 (11:52 +0200)]
ui: storage/PBSEdit: add port to server field

this gives users the chance to supply the port nr in the gui,
without having to add a extra new field to the panel.

using the same implementation as in RemoteEdit.js in PBS.

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
2 years agoui: clarify labels for EFI/TPM storage
Thomas Lamprecht [Thu, 21 Oct 2021 11:41:06 +0000 (13:41 +0200)]
ui: clarify labels for EFI/TPM storage

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: add 'win11' ostype and set defaults in wizard
Stefan Reiter [Mon, 11 Oct 2021 12:55:20 +0000 (14:55 +0200)]
ui: add 'win11' ostype and set defaults in wizard

Windows 11 requires a TPM and secure boot, so try to auto-enable both.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoui: SystemEdit: promote advanced settings to normal
Stefan Reiter [Mon, 11 Oct 2021 12:55:19 +0000 (14:55 +0200)]
ui: SystemEdit: promote advanced settings to normal

and reorder the panel a bit, as otherwise I found it *very* cluttered.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agod/control: bump versioned dependency on libpve-storage-perl
Thomas Lamprecht [Thu, 21 Oct 2021 10:15:14 +0000 (12:15 +0200)]
d/control: bump versioned dependency on libpve-storage-perl

to ensure the new selectable `preallocation` property is available.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agofix 3850: ui: storage: using PreallocationSelector for file based storage types
Lorenz Stechauner [Tue, 12 Oct 2021 12:32:34 +0000 (14:32 +0200)]
fix 3850: ui: storage: using PreallocationSelector for file based storage types

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: add PreallocationSelector
Lorenz Stechauner [Tue, 12 Oct 2021 12:32:33 +0000 (14:32 +0200)]
ui: add PreallocationSelector

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: resourcetree: move guest position on template creation
Dominik Csapak [Mon, 4 Oct 2021 07:50:00 +0000 (09:50 +0200)]
ui: resourcetree: move guest position on template creation

we sort templates at the end normally, but if we convert a guest to a
template, it was not moved in the tree

add it to the list of attributes that are checked for a move

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agostatd: rebalance_lxc_containers: use grep instead of for+next-if
Thomas Lamprecht [Wed, 20 Oct 2021 15:01:48 +0000 (17:01 +0200)]
statd: rebalance_lxc_containers: use grep instead of for+next-if

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agostatd: rebalance_lxc_containers: code bload reduction
Thomas Lamprecht [Wed, 20 Oct 2021 14:37:05 +0000 (16:37 +0200)]
statd: rebalance_lxc_containers: code bload reduction

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agopvestatd: fix rebalancing cpusets for cgroupv2
Oguz Bektas [Thu, 14 Oct 2021 06:51:48 +0000 (08:51 +0200)]
pvestatd: fix rebalancing cpusets for cgroupv2

currently we only check the entry for cgroup v1 to decide if cores
should be rebalanced. extend the check to include cgroup v2 entries.

reported in forum [0]

[0]: https://forum.proxmox.com/threads/hard-set-streams-for-lxc-container.97768/

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoceph services: get_cluster_service: code cleanup
Thomas Lamprecht [Wed, 20 Oct 2021 14:28:01 +0000 (16:28 +0200)]
ceph services: get_cluster_service: code cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoceph services: return early if versions stayed the same
Thomas Lamprecht [Wed, 20 Oct 2021 14:26:44 +0000 (16:26 +0200)]
ceph services: return early if versions stayed the same

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoceph services: drop broadcasting legacy version pmxcfs KV
Thomas Lamprecht [Wed, 20 Oct 2021 14:25:09 +0000 (16:25 +0200)]
ceph services: drop broadcasting legacy version pmxcfs KV

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agopvenetcommit: better handle non-existent pending changes
Thomas Lamprecht [Wed, 20 Oct 2021 14:20:09 +0000 (16:20 +0200)]
pvenetcommit: better handle non-existent pending changes

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agovzdump: pbs: suppress output from upload-log command
Fabian Ebner [Mon, 11 Oct 2021 07:14:23 +0000 (09:14 +0200)]
vzdump: pbs: suppress output from upload-log command

which ended up in the backup task log and can be confusing to users:

> INFO: Backup finished at 2021-10-11 08:40:38
> Result: {
>       "data": null
> }
> INFO: Backup job finished successfully

For proxmox-backup-server < 2.0.11-1, there was no output for the
upload-log command.

Reported in the community forum:
https://forum.proxmox.com/threads/backup-finishes-ok-but-data-null-info-on-finish.97740/

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agod/control: depend on libproxmox-acme-plugins directly
Thomas Lamprecht [Sat, 9 Oct 2021 12:14:53 +0000 (14:14 +0200)]
d/control: depend on libproxmox-acme-plugins directly

was provided indirectly through libproxmox-acme-perl but we want to
downgrade it there to a recommends

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agodrop unused and ancient pvenetcommit shell sysv script
Thomas Lamprecht [Fri, 8 Oct 2021 14:01:13 +0000 (16:01 +0200)]
drop unused and ancient pvenetcommit shell sysv script

Handled by the pvenetcommit.service systemd unit nowadays

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agod/postinst: use reload-or-restart instead of try-reload-or-try-restart
Dominik Csapak [Thu, 7 Oct 2021 08:27:22 +0000 (10:27 +0200)]
d/postinst: use reload-or-restart instead of try-reload-or-try-restart

The only difference is that reload-or-try-restart does not do
anything if the service isn't already running, while
reload-or-restart also starts a stopped service.

We explicitly check if the service is enabled on upgrade before doing
any start/reload-or-restart action anyway. So, it would now start
daemons that were stopped but not disabled, which is not a really
valid state and would have happened on the next reboot anyway.

This starts new daemons (like the pvescheduler) automatically on a
package upgrade

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agobump version to 7.0-13
Thomas Lamprecht [Tue, 5 Oct 2021 18:25:08 +0000 (20:25 +0200)]
bump version to 7.0-13

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agowizard: code cleanup
Thomas Lamprecht [Tue, 5 Oct 2021 18:06:49 +0000 (20:06 +0200)]
wizard: code cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: vm create: allow configuring a TPM in wizard
Thomas Lamprecht [Tue, 5 Oct 2021 18:06:26 +0000 (20:06 +0200)]
ui: vm create: allow configuring a TPM in wizard

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: efi: default to new 4MB format and allow pre-enrolled keys
Thomas Lamprecht [Tue, 5 Oct 2021 18:05:20 +0000 (20:05 +0200)]
ui: efi: default to new 4MB format and allow pre-enrolled keys

to allow "real" secure boot, at least real enough for Windows 11 ;)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: efi/tpm: propagate disabled to child items
Thomas Lamprecht [Tue, 5 Oct 2021 18:03:19 +0000 (20:03 +0200)]
ui: efi/tpm: propagate disabled to child items

we'll need that soon once this is used int the wizard

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agobump version to 7.0-12
Thomas Lamprecht [Tue, 5 Oct 2021 06:07:48 +0000 (08:07 +0200)]
bump version to 7.0-12

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoceph: code/whitespace cleanups
Thomas Lamprecht [Tue, 5 Oct 2021 06:01:10 +0000 (08:01 +0200)]
ceph: code/whitespace cleanups

avoid line bloat, use same capitalization style in warnings as (most)
of the rest of code, some style nits

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoceph: use method to have a single source for install flag file
Thomas Lamprecht [Tue, 5 Oct 2021 06:00:46 +0000 (08:00 +0200)]
ceph: use method to have a single source for install flag file

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoceph install: improve ceph install checks during installation
Aaron Lauterer [Mon, 4 Oct 2021 08:02:25 +0000 (10:02 +0200)]
ceph install: improve ceph install checks during installation

Adding a flag file during the Ceph installation helps to cover the time
span in which the binary is already present but the installation not yet
done.

The most noticeable effect is that the 'Next' button in the GUI will
only become active once the installation is actually finished and not
earlier.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoui: lxc options: change CIFS to SMB/CIFS
Aaron Lauterer [Mon, 4 Oct 2021 10:25:43 +0000 (12:25 +0200)]
ui: lxc options: change CIFS to SMB/CIFS

For consistency with the Storage panel and it might also help people to
make the connection if they are not aware that CIFS is a name used for
SMB.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoui: storage: change CIFS to SMB/CIFS
Aaron Lauterer [Mon, 4 Oct 2021 10:25:42 +0000 (12:25 +0200)]
ui: storage: change CIFS to SMB/CIFS

This will hopefully help people to find the needed storage as not
everyone will be aware of the fact that CIFS is also a name used for it
(technically it was only SMB v1).

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoui: add support for adding TPM devices
Stefan Reiter [Mon, 4 Oct 2021 15:29:21 +0000 (17:29 +0200)]
ui: add support for adding TPM devices

Inspired by HDEfi for efidisks. Extends the DiskStorageSelector to allow
hiding the format, since tpmstate can only be stored in 'raw' format
(even on directory storages).

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2 years agod/lintian: update overrides
Thomas Lamprecht [Mon, 4 Oct 2021 10:12:02 +0000 (12:12 +0200)]
d/lintian: update overrides

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agobuildsys: lintian: do not ignore "binaries" anymore
Thomas Lamprecht [Mon, 4 Oct 2021 10:07:18 +0000 (12:07 +0200)]
buildsys: lintian: do not ignore "binaries" anymore

not required anymore and if it would be, we'd rather use the
debian/lintian-overrides file

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agopve6to7: improve manpage slightly
Thomas Lamprecht [Mon, 4 Oct 2021 09:13:51 +0000 (11:13 +0200)]
pve6to7: improve manpage slightly

this fixes a lintian complaint regarding "bad-whatis-entry"

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agodrop pve5to6 checker tool, not relevant in 7.x release
Thomas Lamprecht [Mon, 4 Oct 2021 09:11:03 +0000 (11:11 +0200)]
drop pve5to6 checker tool, not relevant in 7.x release

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agod/postinst: fix lintian: command-with-path-in-maintainer-script postinst:76 /usr...
Thomas Lamprecht [Mon, 4 Oct 2021 08:38:56 +0000 (10:38 +0200)]
d/postinst: fix lintian: command-with-path-in-maintainer-script postinst:76 /usr/bin/pvecm

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: qemu/OSTypeEdit: set ostype in viewmodel
Dominik Csapak [Wed, 22 Sep 2021 09:27:47 +0000 (11:27 +0200)]
ui: qemu/OSTypeEdit: set ostype in viewmodel

so that we can retrieve it in the MultiDiskPanel

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: form/ControllerSelector: add option for selecting free on inital config
Dominik Csapak [Wed, 22 Sep 2021 09:27:46 +0000 (11:27 +0200)]
ui: form/ControllerSelector: add option for selecting free on inital config

we will sometimes directly give it a config, so the id can be selected
at the start

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: Utils: add capture group for the id in bus_match
Dominik Csapak [Wed, 22 Sep 2021 09:27:45 +0000 (11:27 +0200)]
ui: Utils: add capture group for the id in bus_match

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: qemu/OSTypeEdit: drop throwing an error on multiple widgets
Dominik Csapak [Wed, 22 Sep 2021 09:27:44 +0000 (11:27 +0200)]
ui: qemu/OSTypeEdit: drop throwing an error on multiple widgets

we will have multiple panels with the same widget. Instead
of raising an error in that case, simply ignore it, since
we normally only want to set the default initially, not when
users configured something else

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: qemu/HDEdit: fire an event when the disk id changes
Dominik Csapak [Wed, 22 Sep 2021 09:27:43 +0000 (11:27 +0200)]
ui: qemu/HDEdit: fire an event when the disk id changes

e.g. from scsi0 to scsi1 or from scsi0 to virtio0

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: qemu/HDEdit: use me instead of this
Dominik Csapak [Wed, 22 Sep 2021 09:27:42 +0000 (11:27 +0200)]
ui: qemu/HDEdit: use me instead of this

more in line with our remaining code style

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: form/ControllerSelector: add updateVMConfig and getConfId
Dominik Csapak [Wed, 22 Sep 2021 09:27:41 +0000 (11:27 +0200)]
ui: form/ControllerSelector: add updateVMConfig and getConfId

those are helpers that will be useful when we want to change the
vmconfig for the ControllerSelector on the fly

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: refactor sortByPreviousUsage and nextFreeDisk
Dominik Csapak [Wed, 22 Sep 2021 09:27:40 +0000 (11:27 +0200)]
ui: refactor sortByPreviousUsage and nextFreeDisk

we'll use them outside of the controllerSelector soon

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: form/ControllerSelector: set correct max value for the device-id
Dominik Csapak [Wed, 22 Sep 2021 09:27:39 +0000 (11:27 +0200)]
ui: form/ControllerSelector: set correct max value for the device-id

the 'diskControllerMaxIDs' object in Utils does not describe the
'maximum ids', but the maximum *number* of ids, so the max is one less

correctly set that instead

the api rejected those values (e.g. ide4) already, so its only a ui change

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: qemu/HDEdit: move Bandwidth options to a different tab
Dominik Csapak [Wed, 22 Sep 2021 09:27:38 +0000 (11:27 +0200)]
ui: qemu/HDEdit: move Bandwidth options to a different tab

for that we have to nest the now two tabs in a tabpanel into an inputpanel.
to prevent the options to be collected twice, we override the
'getValues' function of the 'sub-inputpanels' to return an empty object.
(we could make that an option for the inputpanel, but not necessary for
now)

also we have to move the 'bodyPadding' of the wizard to the 'defaults'
so we can override it for specific panels

and we have to manually set the width of the edit window since it
believes we only have a single column ('twoColumns' could also be an
option of the edit window should we need that again)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: ceph install wizard: fix config exists note position
Aaron Lauterer [Tue, 10 Aug 2021 13:27:26 +0000 (15:27 +0200)]
ui: ceph install wizard: fix config exists note position

During the Ceph installation, in the configuration step, a note is shown
if there already is a Ceph configuration present. This notification
should be in the center of the wizard but is currently barely visible.

ExtJS is having trouble calculating the position and the result is that
the note is placed almost out of the visible area.

Setting a fixed height helps ExtJS calculate the vertical position.
Changing from the 'beforeshow' listener to the 'afterrender' one helps
for the horizontal position.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2 years agoapi: ceph: create osd: work around udev bug
Fabian Ebner [Tue, 28 Sep 2021 11:39:55 +0000 (13:39 +0200)]
api: ceph: create osd: work around udev bug

There is a udev bug [0] which can ultimately lead to the udev database
for certain devices not being actively updated. The Diskmanage package
relies upon lsblk for certain info, and lsblk queries the udev
database. Ensure the information is updated by manually calling
'udevadm trigger' for the changed devices.

Without the fix, and a bit of bad luck, a cleaned up disk could still
show up as an 'LVM2_member' for example.

[0]: https://github.com/systemd/systemd/issues/18525

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoapi: check: create osd: use wipe_blockdev from the Diskmanage package
Fabian Ebner [Tue, 28 Sep 2021 11:39:54 +0000 (13:39 +0200)]
api: check: create osd: use wipe_blockdev from the Diskmanage package

which is mostly a copy of the wipe_disks helper with the difference
that it also uses wipefs on the device and its partitions.

Remove the wipe_disks helper as no users remain.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoapi: ceph: create osd: re-check disk requirements after fork/lock
Fabian Ebner [Tue, 28 Sep 2021 11:39:53 +0000 (13:39 +0200)]
api: ceph: create osd: re-check disk requirements after fork/lock

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoinfluxdb: do not test the connection when entry is disabled
Dominik Csapak [Thu, 30 Sep 2021 11:38:34 +0000 (13:38 +0200)]
influxdb: do not test the connection when entry is disabled

We do the same already for in the parent's base-plugin method anyway
as else we cannot disable entries where influxdb is not reachable.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: cluster backup: only restrict storages to node when it's selected
Fabian Ebner [Tue, 21 Sep 2021 11:22:07 +0000 (13:22 +0200)]
ui: cluster backup: only restrict storages to node when it's selected

Previously, only the storages for the local node would be shown, which
prevented configuring a job for remote nodes when the storage is not
available on the local node.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: storage selector: add new clusterView option
Fabian Ebner [Tue, 21 Sep 2021 11:22:06 +0000 (13:22 +0200)]
ui: storage selector: add new clusterView option

which allows selecting storages available in the whole cluster and
controls whether usage information or node/shared information is
displayed. It is still possible to filter by node and content type.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: storage selector: only check for nodename before loading storage
Fabian Ebner [Tue, 21 Sep 2021 11:22:05 +0000 (13:22 +0200)]
ui: storage selector: only check for nodename before loading storage

but allow an empty nodename to be set. This is in preparation for
allowing a cluster view as well, where an empty node name will
indicate that no node is selected.

Since the reloadStorageList function still returns early if there is
no nodename, this should not lead to any issues.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agofix #3620: ui: dc/storage: delete empty pbs fingerprint on edit
Dominik Csapak [Mon, 13 Sep 2021 08:29:31 +0000 (10:29 +0200)]
fix #3620: ui: dc/storage: delete empty pbs fingerprint on edit

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: backup job detail view: factor out to own file
Thomas Lamprecht [Thu, 9 Sep 2021 15:45:13 +0000 (17:45 +0200)]
ui: backup job detail view: factor out to own file

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: improve ACME edit/apply button visibilty
Dominik Csapak [Thu, 9 Sep 2021 14:36:19 +0000 (16:36 +0200)]
ui: improve ACME edit/apply button visibilty

multiple users were confused[0], as they did not interpret the 'icon only'
in the toolbar as a button (and it did not help that we prevented
the cursor to change)

to improve it, make the button a normal one again, and add some
text for context (this is more inline what we do elsewhere in toolbars)

0: https://forum.proxmox.com/threads/acme-over-dnschallenge-failing.71902

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoui: backup job detail view: shrink code for set values of keep-X fields
Thomas Lamprecht [Wed, 8 Sep 2021 14:14:00 +0000 (16:14 +0200)]
ui: backup job detail view: shrink code for set values of keep-X fields

makes it quite concise, but there's nothing really complex happening,
so should be still easy to grasp (especially with the comment added)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: backup job detail view: show retention settings in three columns
Thomas Lamprecht [Wed, 8 Sep 2021 14:13:03 +0000 (16:13 +0200)]
ui: backup job detail view: show retention settings in three columns

to safe vertical space for the actual guest+disk list

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: backup job detail view: merge mail notification when/to fields
Thomas Lamprecht [Wed, 8 Sep 2021 14:09:40 +0000 (16:09 +0200)]
ui: backup job detail view: merge mail notification when/to fields

While it surely is nice to follow the layout of the job creation/edit
panel for sharing familiarity, it does not means that we need to show
the data 1:1, we can profit from the read-only fact and merge stuff a
bit, like the mail to/when field.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: backup job detail view: simplify node renderer
Thomas Lamprecht [Wed, 8 Sep 2021 14:09:19 +0000 (16:09 +0200)]
ui: backup job detail view: simplify node renderer

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: backup job detail view: simplify enabled renderer
Thomas Lamprecht [Wed, 8 Sep 2021 11:38:25 +0000 (13:38 +0200)]
ui: backup job detail view: simplify enabled renderer

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoui: backup job detail: also show retention settings
Fabian Ebner [Mon, 6 Sep 2021 11:32:30 +0000 (13:32 +0200)]
ui: backup job detail: also show retention settings

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: backup job detail view: fix coding style, xtype goes first
Thomas Lamprecht [Wed, 8 Sep 2021 11:32:33 +0000 (13:32 +0200)]
ui: backup job detail view: fix coding style, xtype goes first

the code is unnecessarily hard to read else and goes against our
common style.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agovzdump: include current backup when pruning dumpdir
Fabian Ebner [Tue, 7 Sep 2021 11:18:35 +0000 (13:18 +0200)]
vzdump: include current backup when pruning dumpdir

Not doing so leads to an off-by-one error, and pruning in a dumpdir
really should behave the same way as pruning in a storage.

Reported in the community forum:
https://forum.proxmox.com/threads/problem-mit-prune-backups.95737/

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: prune: fix order of keep reasons
Fabian Ebner [Tue, 7 Sep 2021 10:08:39 +0000 (12:08 +0200)]
ui: prune: fix order of keep reasons

This is the same as fix 40ff84b138bb7127ecc05a2f587cca4e7a917810 in
proxmox-backup. When returning a boolean instead of the expected
{negative, 0, positive}, the behavior is browser-dependent.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: rename pveEditPruneInputPanel to pveBackupJobPrunePanel
Thomas Lamprecht [Wed, 8 Sep 2021 10:38:03 +0000 (12:38 +0200)]
ui: rename pveEditPruneInputPanel to pveBackupJobPrunePanel

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agofix #1803: ui: cluster backup: handle job-specific retention options
Fabian Ebner [Mon, 6 Sep 2021 11:32:29 +0000 (13:32 +0200)]
fix #1803: ui: cluster backup: handle job-specific retention options

This was already possible via API (or manually editing vzdump.cron)
for a long time, but the settings were not visible in the UI at all.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2 years agoui: prune edit: prepare for being re-used for backup jobs
Fabian Ebner [Mon, 6 Sep 2021 11:32:28 +0000 (13:32 +0200)]
ui: prune edit: prepare for being re-used for backup jobs

1. Rename the isPBS variable to match the actual purpose. When editing
a backup job, the hint should not be shown, even if the storage is
PBS.

2. Allow specifying the text used for the fallback hint. For backup
jobs, the first fallback is the storage configuration, so the text
needs to be different there.

3. Make using keep-all=1 by default upon creation optional. For backup
jobs, the default should be "use fallback", i.e. no settings.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>