]>
git.proxmox.com Git - mirror_lxc.git/log
Christian Brauner [Thu, 25 Feb 2021 09:17:19 +0000 (10:17 +0100)]
commands: port lxc_cmd_get_init_pid() to new helpers
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 25 Feb 2021 09:16:55 +0000 (10:16 +0100)]
commands: port lxc_try_cmd() to new helpers
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 25 Feb 2021 09:16:03 +0000 (10:16 +0100)]
commands: add lxc_cmd_init() and lxc_cmd_data()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 25 Feb 2021 08:55:22 +0000 (09:55 +0100)]
commands: s/lxc_cmd_init()/lxc_server_init()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 25 Feb 2021 08:32:19 +0000 (09:32 +0100)]
commands: switch to bool
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 25 Feb 2021 08:23:27 +0000 (09:23 +0100)]
commands: use IN_SET() in lxc_cmd()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Wed, 24 Feb 2021 16:32:07 +0000 (11:32 -0500)]
Merge pull request #3695 from brauner/2021-02-24/fixes_3
commands: array hardening
Christian Brauner [Wed, 24 Feb 2021 15:48:23 +0000 (16:48 +0100)]
commands: ensure that non-NULL and MAX_STATE is always passed
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 15:44:11 +0000 (16:44 +0100)]
commands: annotate array argument
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Wed, 24 Feb 2021 15:36:10 +0000 (10:36 -0500)]
Merge pull request #3694 from brauner/2021-02-24/fixes_2
commands: rework and add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD
Christian Brauner [Wed, 24 Feb 2021 15:07:23 +0000 (16:07 +0100)]
commands: s/LXC_CMD_CONSOLE/LXC_CMD_GET_TTY_FD/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 11:01:27 +0000 (12:01 +0100)]
commands: add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD
and port cgroup_get() and cgroup_set(). This means no more useless cgroup
driver initialization on ever get or set.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 14:31:12 +0000 (15:31 +0100)]
commands: extend rsp_one_fd() to also handle additional data
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 14:25:19 +0000 (15:25 +0100)]
file_utils: actually open the file for reading
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 10:53:53 +0000 (11:53 +0100)]
commands: set rsp.ret to 0 for lxc_cmd_get_cgroup_ctx_callback()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 10:31:02 +0000 (11:31 +0100)]
cgroups: s/cgroup_layout/layout/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 10:11:08 +0000 (11:11 +0100)]
commands: add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 09:58:43 +0000 (10:58 +0100)]
commands: s/_LIMITING_/_LIMIT_/g and s/_limiting_/_limit_/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 08:47:40 +0000 (09:47 +0100)]
commands: simplify lxc_cmd_get_cgroup_ctx()
Instead of allowing individual hierarchy fd retrieval through
lxc_cmd_get_cgroup_ctx() let's add a dedicated method instead.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 08:46:07 +0000 (09:46 +0100)]
commands: fix alignment for lxc_cmd_get_cgroup_ctx()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 08:41:32 +0000 (09:41 +0100)]
cgroups: handle fallback gracefully
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 08:37:13 +0000 (09:37 +0100)]
cgroups: make use of ERRNO_IS_NOT_SUPPORTED()
This will hopefully prevent backwards compatibility fallback errors.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 08:19:12 +0000 (09:19 +0100)]
error_utils: copy over Lennart's IN_SET()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 08:17:03 +0000 (09:17 +0100)]
commands: tweak return values
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 08:16:09 +0000 (09:16 +0100)]
error_utils: move error helper to separate header
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 07:58:56 +0000 (08:58 +0100)]
cgroups: simple variable reordering
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Wed, 24 Feb 2021 01:17:52 +0000 (20:17 -0500)]
Merge pull request #3692 from brauner/2021-02-23/fixes
build fix & cgroup braino
Christian Brauner [Wed, 24 Feb 2021 00:53:05 +0000 (01:53 +0100)]
attach: be paranoid about file descriptors
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 00:26:22 +0000 (01:26 +0100)]
cgroups: fix braino during controller list creation
Co-mounted controllers are conventionally separated by ",".
Fixes: https://jenkins.linuxcontainers.org/job/lxd-github-commit/1905/arch=amd64,backend=dir,compiler=golang-1.15/consoleFull
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 24 Feb 2021 00:01:17 +0000 (01:01 +0100)]
commands: remove faulty use of access attribute
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Tue, 23 Feb 2021 21:53:23 +0000 (16:53 -0500)]
Merge pull request #3691 from brauner/2021-02-23/fixes
Fix issues reported by Coverity
Christian Brauner [Tue, 23 Feb 2021 21:10:56 +0000 (22:10 +0100)]
cgroups: fix error checking
Fixes: Coverity 1473310
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 21:08:48 +0000 (22:08 +0100)]
af_unix: prevent oob writes
Fixes: Coverity 1473309
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 21:07:11 +0000 (22:07 +0100)]
commands: only deref once
Fixes: Coverity 1473308
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Tue, 23 Feb 2021 20:49:38 +0000 (15:49 -0500)]
Merge pull request #3690 from brauner/2021-02-21/fixes
attach: improve attaching of new clients to old servers
Christian Brauner [Tue, 23 Feb 2021 20:06:56 +0000 (21:06 +0100)]
commands: handle old clients for LXC_CMD_GET_CGROUP_CTX
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 20:04:41 +0000 (21:04 +0100)]
attach: handle new and old clients
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 20:00:22 +0000 (21:00 +0100)]
attach: make fd sending more uniform
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 19:48:53 +0000 (20:48 +0100)]
terminal: dumb logging down
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Tue, 23 Feb 2021 20:08:04 +0000 (15:08 -0500)]
Merge pull request #3689 from brauner/2021-02-21/fixes
cgroups: introduce fd-only cgroup attach via LXC_CMD_GET_CGROUP_CTX
Christian Brauner [Tue, 23 Feb 2021 19:13:29 +0000 (20:13 +0100)]
attach: fix namespace preservation
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 18:31:29 +0000 (19:31 +0100)]
commands: verify expected file descriptors were sent
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 18:10:38 +0000 (19:10 +0100)]
commands: handle older clients gracefully
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 18:05:09 +0000 (19:05 +0100)]
attach: remove additional newline
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 18:00:42 +0000 (19:00 +0100)]
af_unix: add comment about cast
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 17:59:07 +0000 (18:59 +0100)]
attach: fix unsupported namespaces
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 15:21:55 +0000 (16:21 +0100)]
commands: lxc_cmd_add_state_client_callback()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 14:06:33 +0000 (15:06 +0100)]
commands: handle older clients elegantly
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 13:22:22 +0000 (14:22 +0100)]
commands: send ENOSYS response
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 13:01:59 +0000 (14:01 +0100)]
cgroups: introduce fd-only cgroup attach
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 13:00:54 +0000 (14:00 +0100)]
commands: introduce LXC_CMD_GET_CGROUP_CTX
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 12:58:39 +0000 (13:58 +0100)]
utils: add copy_struct_to_client()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 12:58:13 +0000 (13:58 +0100)]
log: add syswarn_set()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 07:45:32 +0000 (08:45 +0100)]
utils: add copy_struct_from_client()
Which is our variant of copy_struct_from_user() that Aleksa and I added to the
kernel.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 23 Feb 2021 07:45:21 +0000 (08:45 +0100)]
macro: add min() macro
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 22 Feb 2021 21:45:36 +0000 (22:45 +0100)]
cgroups: allow cgroup fd batch retrieval
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 22 Feb 2021 19:00:18 +0000 (20:00 +0100)]
commands: add LXC_CMD_GET_CGROUP_FD
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 22 Feb 2021 20:53:06 +0000 (21:53 +0100)]
commands: introduce rsp_many_fds()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 22 Feb 2021 20:51:19 +0000 (21:51 +0100)]
commands: introduce rsp_one_fd()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 22 Feb 2021 18:01:45 +0000 (19:01 +0100)]
commands: introduce lxc_cmd_rsp_send_reap()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 22 Feb 2021 17:24:49 +0000 (18:24 +0100)]
commands: be more explicit during command processing
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 22 Feb 2021 14:28:07 +0000 (15:28 +0100)]
state: _never_ return NULL from lxc_state2str()
Cc: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 22 Feb 2021 12:00:16 +0000 (13:00 +0100)]
cgroups: add cgroup_fds() helper
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 22 Feb 2021 11:39:13 +0000 (12:39 +0100)]
af_unix: improve SCM_RIGHTS file descriptor retrieval
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 22 Feb 2021 11:25:52 +0000 (12:25 +0100)]
commands: tweak validate_string_request()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 22 Feb 2021 11:12:32 +0000 (12:12 +0100)]
commands: explicitly number enums
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 19:03:45 +0000 (20:03 +0100)]
cgroups: close dfd_mon but keep dfd_con and dfd_lim open for all cgroup hierarchies
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 18:59:25 +0000 (19:59 +0100)]
cgroups: start stashing all fds
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 18:57:31 +0000 (19:57 +0100)]
cgroups: skip and warn about invalid file descriptors
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 18:48:11 +0000 (19:48 +0100)]
memory_utils: fix close_equal()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Mon, 22 Feb 2021 19:52:25 +0000 (14:52 -0500)]
Merge pull request #3688 from brauner/2021-02-19/fixes_2
cgroups: rework cgroup initialization
Christian Brauner [Sun, 21 Feb 2021 10:36:06 +0000 (11:36 +0100)]
cgroups: handle lxc.cgroup.use global parameter
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 10:30:46 +0000 (11:30 +0100)]
cgroups: fix cg_legacy_freeze() return type
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 10:28:31 +0000 (11:28 +0100)]
file_utils: tweak lxc_write_openat()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 13:32:56 +0000 (14:32 +0100)]
cgroups: improve utility controller handling
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 13:18:28 +0000 (14:18 +0100)]
cgroups: s/cgroup2_chown/delegate/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 10:22:59 +0000 (11:22 +0100)]
cgroups: move cgroup2 parameters into substruct
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 10:18:29 +0000 (11:18 +0100)]
cgroups: s/container_limit_path/path_lim/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 10:17:54 +0000 (11:17 +0100)]
cgroups: s/container_full_path/path_con/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 10:16:30 +0000 (11:16 +0100)]
cgroups: s/cgfd_limit/dfd_lim/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 10:15:37 +0000 (11:15 +0100)]
cgroups: s/cgfd_mon/dfd_mon/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 10:14:53 +0000 (11:14 +0100)]
cgroups: s/cgfd_con/dfd_con/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 10:11:37 +0000 (11:11 +0100)]
cgroups: s/mountpoint/at_mnt/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 10:09:27 +0000 (11:09 +0100)]
cgroups: s/container_base_path/at_base/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 09:54:23 +0000 (10:54 +0100)]
cgroups: rename cgroupfs mount fd
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 00:40:11 +0000 (01:40 +0100)]
cgroups: simplify and fix mounting on non-cgroup namespace aware kernels
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 00:28:45 +0000 (01:28 +0100)]
cgroups: introduce cgroup hierarchy type
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 00:25:49 +0000 (01:25 +0100)]
cgroups: remove unused helpers
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 00:09:33 +0000 (01:09 +0100)]
cgroups: s/add_hierarchy()/cgroup_hierarchy_add()/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 21 Feb 2021 00:05:39 +0000 (01:05 +0100)]
cgroups: split delegation checks into separate helpers
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Feb 2021 23:46:23 +0000 (00:46 +0100)]
cgroups: simplify string list handling
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Feb 2021 01:01:18 +0000 (02:01 +0100)]
cgroups: rework cgroup initialization
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Feb 2021 00:31:05 +0000 (01:31 +0100)]
cgroups: split out unified cgroup helpers
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Feb 2021 02:17:10 +0000 (03:17 +0100)]
memory_utils: adapt to new pointer error macros
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Feb 2021 00:30:33 +0000 (01:30 +0100)]
macro: add pointer error encoding support
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Feb 2021 00:32:49 +0000 (01:32 +0100)]
compiler: add likely() and unlikely() support
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Feb 2021 00:10:53 +0000 (01:10 +0100)]
cgroups: s/basecginfo/cgroup_info/g
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Feb 2021 00:07:43 +0000 (01:07 +0100)]
cgroups: simplify current cgroup retrieval on pure unified cgroup layouts
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Feb 2021 23:49:25 +0000 (00:49 +0100)]
cgroups: tweak return values
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Feb 2021 23:42:51 +0000 (00:42 +0100)]
cgroups: tweak lxc.cgroup.use handling in __cgroup_init()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
projects / mirror_lxc.git / log