]>
git.proxmox.com Git - grub2.git/log
Andrei Borzenkov [Mon, 16 Feb 2015 17:31:22 +0000 (20:31 +0300)]
build-sys: add syslinux test files to tarball
Vladimir Serbinenko [Mon, 16 Feb 2015 14:58:59 +0000 (15:58 +0100)]
Add test for syslinux converter
Vladimir Serbinenko [Mon, 16 Feb 2015 14:56:26 +0000 (15:56 +0100)]
Don't remove initrd= parameter.
Based on simplified patch by Lunar.
Reported by: Lunar
Vladimir Serbinenko [Mon, 16 Feb 2015 09:54:20 +0000 (10:54 +0100)]
syslinux_parse: Always output comments even if no entries are found.
Andrei Borzenkov [Sun, 15 Feb 2015 07:10:03 +0000 (10:10 +0300)]
diskfilter_make_raid: more memory leaks in failure path
Vladimir Serbinenko [Sat, 14 Feb 2015 19:31:00 +0000 (20:31 +0100)]
disk/lvm: Use zalloc to ensure that segments are initialised to sane value.
Reported by: EmanueL Czirai.
Daniel Kiper [Fri, 30 Jan 2015 17:59:24 +0000 (18:59 +0100)]
multiboot2: Fix information request tag size calculation
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
Andrei Borzenkov [Sat, 14 Feb 2015 16:08:58 +0000 (19:08 +0300)]
diskfilter: fix double free of lv names for mdraid
Avoid micro-optimization in grub_diskfilter_make_raid and make sure
name and fullname are independent strings. This avoids need to special
case it everywhere else.
Also fix memory leak in failure case in grub_diskfilter_make_raid.
Closes: 41582
Andrei Borzenkov [Sat, 14 Feb 2015 14:55:35 +0000 (17:55 +0300)]
diskfilter: fix crash in validate_lv for mdraid arrays
Commit
750f4bacd3262376ced3f837d8dc78f834ca233a put LV validation before
actual vg assignment. Make grub_diskfilter_make_raid to assign ->vg as
happens in other cases for consistency. Also clean up redundant code and add
explicit NULL lv->vg check in validate_lv.
Also fix segment validation in validate_lv; it became obvious when crash
was fixed.
Closes: 44199
Jiri Slaby [Thu, 12 Feb 2015 10:02:09 +0000 (11:02 +0100)]
util: mkimage, fix gcc5 build failure
gcc5 reports:
../util/mkimage.c: In function 'grub_install_get_image_target':
../util/mkimage.c:954:5: error: loop exit may only be reached after undefined behavior [-Werror=aggressive-loop-optimizations]
&& j < ARRAY_SIZE (image_targets[i].names); j++)
^
../util/mkimage.c:953:39: note: possible undefined statement is here
for (j = 0; image_targets[i].names[j]
^
Well, let's move the index 'j' test before accesing the array to:
1) make the loop obvious
2) make gcc happy
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Leif Lindholm [Tue, 3 Feb 2015 21:16:36 +0000 (21:16 +0000)]
arm: implement additional relocations generated by gcc 4.9 at -O3
GCC 4.9 also generates R_ARM_THM_MOVW_ABS_NC and R_ARM_THM_MOVT_ABS,
as an alternative to ABS32.
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Andrei Borzenkov [Fri, 30 Jan 2015 19:57:39 +0000 (22:57 +0300)]
setup: fix blocklist size calculation
Found by: Coverity scan.
Andrei Borzenkov [Fri, 30 Jan 2015 19:45:58 +0000 (22:45 +0300)]
grub-fstest: fix descriptor leak
Found by: Coverity scan.
Andrei Borzenkov [Fri, 30 Jan 2015 19:39:11 +0000 (22:39 +0300)]
net/pxe: fix error condition
Test return value of grub_netbuff_reserve(), buf itself cannot be
NULL here.
Found by: Coverity scan.
Andrei Borzenkov [Fri, 30 Jan 2015 19:26:05 +0000 (22:26 +0300)]
grub-mkimage: fix potential NULL pointer dereference
Move fatal check whether symtab_section is NULL before first reference.
Found by: Coverity scan.
Andrei Borzenkov [Fri, 30 Jan 2015 19:09:51 +0000 (22:09 +0300)]
net/ip: check result of grub_netbuff_push
Found by: Coverity scan.
Andrei Borzenkov [Fri, 30 Jan 2015 18:42:46 +0000 (21:42 +0300)]
tests: add test command file tests
This requires access to files in both host and grub image, so
implementing as separate test unit instead of script test was
more easy.
Andrei Borzenkov [Fri, 30 Jan 2015 17:31:20 +0000 (20:31 +0300)]
test: consistently use TMPDIR and same name pattern for temp files
Andrei Borzenkov [Fri, 30 Jan 2015 17:21:56 +0000 (20:21 +0300)]
test: fix previous commit - we need to return from subexpression
( ... ) was processed recursively, we need to return from it. Revert
this change.
Andrei Borzenkov [Fri, 30 Jan 2015 17:10:43 +0000 (20:10 +0300)]
test: do not stop after first file test or closing bracket
Closes: 44115
Leif Lindholm [Wed, 28 Jan 2015 20:17:18 +0000 (20:17 +0000)]
configure.ac: don't use -msoft-float for arm64
aarch64 toolchains do not support the -msoft-float option added by
commit
3661261f . Insted, for arm64 use -march=armv8-a+nofp+nosimd.
Reported-by: Ryan Harkin <ryan.harkin@linaro.org>
Andrei Borzenkov [Wed, 28 Jan 2015 17:35:28 +0000 (20:35 +0300)]
script/execute.c: fix memory leak.
Make sure to continue loop over array after failure to free
allocated strings.
Found by: Coverity scan.
Andrei Borzenkov [Wed, 28 Jan 2015 17:09:25 +0000 (20:09 +0300)]
syslinux_parse: fix memory leak.
Found by: Coverity scan.
Andrei Borzenkov [Tue, 27 Jan 2015 19:34:50 +0000 (22:34 +0300)]
Change quotes to match overall style in NEWS
Andrei Borzenkov [Tue, 27 Jan 2015 18:49:45 +0000 (21:49 +0300)]
loader/xnu: fix memory leak.
Foound by: Coverity scan.
Andrei Borzenkov [Tue, 27 Jan 2015 18:29:55 +0000 (21:29 +0300)]
util/grub-probe: fix memory leaks.
Found by: Coverity scan.
Andrei Borzenkov [Tue, 27 Jan 2015 18:19:28 +0000 (21:19 +0300)]
fs/hfsplus: fix memory leak.
Found by: Coverity scan.
Andrei Borzenkov [Tue, 27 Jan 2015 18:13:10 +0000 (21:13 +0300)]
fs/zfs/zfscrypt.c: fix indentation.
Andrei Borzenkov [Tue, 27 Jan 2015 18:12:19 +0000 (21:12 +0300)]
fs/zfs/zfscrypt.c: fix memory leaks.
Found by: Coverity scan.
Andrei Borzenkov [Tue, 27 Jan 2015 17:55:25 +0000 (20:55 +0300)]
commands/parttool: fix memory leak.
Found by: Coverity scan.
Andrei Borzenkov [Tue, 27 Jan 2015 17:52:27 +0000 (20:52 +0300)]
fs/zfs/zfs.c: fix memory leak.
Found by: Coverity scan.
Andrei Borzenkov [Tue, 27 Jan 2015 17:29:00 +0000 (20:29 +0300)]
linux/ofpath: fix descriptor leak
Found by: Coverity scan
Andrei Borzenkov [Tue, 27 Jan 2015 17:00:23 +0000 (20:00 +0300)]
linux/hostdisk: use strncpy instead of strlcpy
strlcpy is not available on Linux as part of standard libraries.
It probably is not worth extra configure checks espicially as we
need to handle missing function anyway.
Vladimir Serbinenko [Tue, 27 Jan 2015 16:17:58 +0000 (17:17 +0100)]
Document intentional fallthroughs.
Found by: Coverity scan.
Vladimir Serbinenko [Tue, 27 Jan 2015 15:49:49 +0000 (16:49 +0100)]
linux/ofpath: Fix error handling.
Found by: Coverity Scan.
Vladimir Serbinenko [Tue, 27 Jan 2015 15:48:53 +0000 (16:48 +0100)]
linux/hostdisk: Limit strcpy size to buffer size.
Found by: Coverity scan.
Vladimir Serbinenko [Tue, 27 Jan 2015 15:35:37 +0000 (16:35 +0100)]
fs/zfscrypt: Add missing explicit cast.
Found by: Coverity scan.
Vladimir Serbinenko [Tue, 27 Jan 2015 15:31:35 +0000 (16:31 +0100)]
fs/zfs: Fix error handling.
Found by: Coverity Scan.
Vladimir Serbinenko [Tue, 27 Jan 2015 09:30:43 +0000 (10:30 +0100)]
fs/{cbfs,cpio}: Remove useless check if mode is NULL.
Callers already ensure that it's not null.
Found by: Coverity Scan.
Vladimir Serbinenko [Tue, 27 Jan 2015 09:20:54 +0000 (10:20 +0100)]
commands/acpi: Use ALIGN_UP rather than manual expression.
Improves readability and hopefully automatic scanning.
Found by: Coverity Scan.
Andrei Borzenkov [Mon, 26 Jan 2015 19:44:45 +0000 (22:44 +0300)]
util/setup: fix memory leak.
Found by: Coverity scan.
Andrei Borzenkov [Mon, 26 Jan 2015 19:39:08 +0000 (22:39 +0300)]
util/mkimage: fix memory leaks.
Found by: Coverity scan.
Andrei Borzenkov [Mon, 26 Jan 2015 19:24:28 +0000 (22:24 +0300)]
util/grub-mount: fix descriptor leak.
Found by: Coverity scan.
Andrei Borzenkov [Mon, 26 Jan 2015 19:20:51 +0000 (22:20 +0300)]
util/grub-mkstandalone: fix memory leak.
Found by: Coverity scan.
Andrei Borzenkov [Mon, 26 Jan 2015 19:17:31 +0000 (22:17 +0300)]
util/grub-install: rearrange code to avoid memory leak.
Found by: Coverity scan.
Andrei Borzenkov [Mon, 26 Jan 2015 19:08:13 +0000 (22:08 +0300)]
linux/getroot: fix memory leak.
Found by: Coverity scan.
Andrei Borzenkov [Mon, 26 Jan 2015 18:11:32 +0000 (21:11 +0300)]
util/install: fix memory leak.
Found by: Coverity scan.
Andrei Borzenkov [Mon, 26 Jan 2015 18:07:19 +0000 (21:07 +0300)]
util/setup: fix memory leak.
Found by: Coverity scan.
Andrei Borzenkov [Mon, 26 Jan 2015 18:41:29 +0000 (21:41 +0300)]
linux/ofpath: fix various memory leaks.
Found by: Coverity scan.
Andrei Borzenkov [Mon, 26 Jan 2015 18:38:40 +0000 (21:38 +0300)]
linux/getroot: fix descriptor leak.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:56:24 +0000 (09:56 +0100)]
util/misc.c: Check ftello return value.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:55:58 +0000 (09:55 +0100)]
grub-macbless: Fix resource leak.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:55:30 +0000 (09:55 +0100)]
grub-install: Fix memory leak.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:54:50 +0000 (09:54 +0100)]
grub-install-common: Fix sizeof usage.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:54:14 +0000 (09:54 +0100)]
util/getroot: Add missing grub_disk_close.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:53:39 +0000 (09:53 +0100)]
vbe: Fix incorrect register usage.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:53:03 +0000 (09:53 +0100)]
unix/password: Fix file descriptor leak.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:51:48 +0000 (09:51 +0100)]
linux/getroot: Fix error handling.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:50:58 +0000 (09:50 +0100)]
linux/blocklist: Fix memory leak.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:50:27 +0000 (09:50 +0100)]
devmapper/getroot: Fix memory leak.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:49:32 +0000 (09:49 +0100)]
normal/misc: Close device on all pathes.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:48:46 +0000 (09:48 +0100)]
normal/main: Fix error handling.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:44:57 +0000 (09:44 +0100)]
xnu: Add missing error check.
Found by: Coveriy scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:44:33 +0000 (09:44 +0100)]
plan9: Add missing grub_device_close.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:43:52 +0000 (09:43 +0100)]
multiboot: Simplify to avoid confusing assignment.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:42:42 +0000 (09:42 +0100)]
bsd: Add missing null-pointer check.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:42:04 +0000 (09:42 +0100)]
lib/syslinux_parse: Add missing error check.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:41:24 +0000 (09:41 +0100)]
lib/syslinux_parse: Fix memory leak.
Found by: Coveriy scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:40:42 +0000 (09:40 +0100)]
lib/syslinux_parse: Add missing alloc check.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:38:11 +0000 (09:38 +0100)]
i386/pc/mmap: Fix memset size.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:37:39 +0000 (09:37 +0100)]
gfxmenu/theme_loader: Add missing allos error check.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:37:01 +0000 (09:37 +0100)]
gfxmenu/icon_manager: Fix null pointer dereference.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:36:19 +0000 (09:36 +0100)]
fs/ufs: Add missing error check.
Found by: Coverity scan.
Vladimir Serbinenko [Mon, 26 Jan 2015 08:35:44 +0000 (09:35 +0100)]
configure.ac: Always add -D_FILE_OFFSET_BITS=64.
Vladimir Serbinenko [Sun, 25 Jan 2015 12:33:03 +0000 (13:33 +0100)]
fs/sfs: Fix error check and add sanity check.
Found by: Coverity scan.
Vladimir Serbinenko [Sun, 25 Jan 2015 12:29:26 +0000 (13:29 +0100)]
fs/reiserfs: Fix sector count overflow.
Found by: Coverity scan.
Vladimir Serbinenko [Sun, 25 Jan 2015 12:28:50 +0000 (13:28 +0100)]
fs/ntfs: Add sizes sanity checks.
Found by: Coverity scan.
Vladimir Serbinenko [Sun, 25 Jan 2015 12:22:24 +0000 (13:22 +0100)]
fs/ntfs: Add missing free.
Found by: Coverity scan.
Vladimir Serbinenko [Sun, 25 Jan 2015 12:21:32 +0000 (13:21 +0100)]
fs/minix: Fix sector promotion to 64-bit.
While on it make GRUB_MINIX_ZONE2SECT into function.
Found by: Coverity scan
Vladimir Serbinenko [Sun, 25 Jan 2015 12:19:58 +0000 (13:19 +0100)]
grub_iso9660_read: Explicitly check read_node return value.
Not really needed as grub_errno is already checked but is nicer.
Found by: Coverity scan.
Andrei Borzenkov [Sun, 25 Jan 2015 13:36:30 +0000 (16:36 +0300)]
commands/fileXX: Fix remaining memory leak.
Found by: Coverity Scan.
Vladimir Serbinenko [Sun, 25 Jan 2015 10:32:29 +0000 (11:32 +0100)]
fs/hfs: Add pointer sanity checks.
Found by: Coverity scan.
Vladimir Serbinenko [Sun, 25 Jan 2015 00:28:17 +0000 (01:28 +0100)]
fs/hfs/hfs_open: Check that mount succeeded.
Found by: Coverity scan.
Vladimir Serbinenko [Sun, 25 Jan 2015 00:27:44 +0000 (01:27 +0100)]
fs/fat: Fix codepath to properly free on error.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 23:11:59 +0000 (00:11 +0100)]
fs/cpio_common: Add a sanity check on namesize.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 23:00:49 +0000 (00:00 +0100)]
fs/cbfs: Add missing free.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:55:18 +0000 (21:55 +0100)]
font: Add missing free.
Found by: Coverity Scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:50:30 +0000 (21:50 +0100)]
biosdisk: Add missing cast.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:47:51 +0000 (21:47 +0100)]
disk/geli: Add missing free.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:46:23 +0000 (21:46 +0100)]
disk/geli: Add missing seek success check.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:44:27 +0000 (21:44 +0100)]
disk/diskfilter: Add missing lv presence check.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:38:22 +0000 (21:38 +0100)]
disk/cryptodisk: Add missing error check.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:37:28 +0000 (21:37 +0100)]
disk/ahci: Fix device_map_range argument.
Argument is not used on x86, hence it's gone unnoticed.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:33:30 +0000 (21:33 +0100)]
disk/AFsplitter: check argument validity before doing any allocs.
This avoids possible memory leaks.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:29:19 +0000 (21:29 +0100)]
commands/wildcard: Add missing free.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:27:10 +0000 (21:27 +0100)]
commands/verify: Fix sha1 context zeroing-out.
Current code doesn't zero-out context completely. It's a minor issue
really as sha1 init already takes care of initing the context.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:25:42 +0000 (21:25 +0100)]
commands/tr: Simplify and fix missing parameter test.
Found by: Coverity scan
Vladimir Serbinenko [Sat, 24 Jan 2015 20:23:25 +0000 (21:23 +0100)]
commands/syslinux: Add missing free.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:22:02 +0000 (21:22 +0100)]
commands/parttool: Add missing device close.
Found by: Coverity scan.
Vladimir Serbinenko [Sat, 24 Jan 2015 20:18:36 +0000 (21:18 +0100)]
commands/nativedisk: Add missing device_close.
Found by: Coverity scan.