]> git.proxmox.com Git - mirror_frr.git/log
mirror_frr.git
3 years agoMerge pull request #8262 from reubendowle/fixes/nhrp-misc-fixes
Donald Sharp [Sun, 8 Aug 2021 11:27:41 +0000 (07:27 -0400)]
Merge pull request #8262 from reubendowle/fixes/nhrp-misc-fixes

nhrp misc fixes

3 years agoMerge pull request #8870 from anlancs/master-fix-reload-service
Donald Sharp [Sun, 8 Aug 2021 11:21:10 +0000 (07:21 -0400)]
Merge pull request #8870 from anlancs/master-fix-reload-service

tools: add "vni" to oneline list

3 years agoMerge pull request #9283 from ton31337/fix/documentation_for_aggregate-address
Donald Sharp [Sat, 7 Aug 2021 20:07:34 +0000 (16:07 -0400)]
Merge pull request #9283 from ton31337/fix/documentation_for_aggregate-address

doc: Specify how aggregate-address works for BGP

3 years agoMerge pull request #9253 from donaldsharp/igmp_no
Donatas Abraitis [Sat, 7 Aug 2021 19:49:25 +0000 (22:49 +0300)]
Merge pull request #9253 from donaldsharp/igmp_no

pimd: Allow more permisive versions of some no commands

3 years agoMerge pull request #9313 from idryzhov/bgp-zebra-opaque
Donald Sharp [Sat, 7 Aug 2021 19:12:02 +0000 (15:12 -0400)]
Merge pull request #9313 from idryzhov/bgp-zebra-opaque

BGP opaque data improvements

3 years agoMerge pull request #9315 from idryzhov/pathd-cli-fixes
Donald Sharp [Sat, 7 Aug 2021 19:10:05 +0000 (15:10 -0400)]
Merge pull request #9315 from idryzhov/pathd-cli-fixes

pathd: a couple of cli/doc fixes

3 years agoMerge pull request #9312 from opensourcerouting/topo-small-fixes
Christian Hopps [Fri, 6 Aug 2021 17:34:52 +0000 (13:34 -0400)]
Merge pull request #9312 from opensourcerouting/topo-small-fixes

topotests: small fixes for two tests

3 years agodoc: fix pathd example config
Igor Ryzhov [Thu, 5 Aug 2021 20:57:24 +0000 (23:57 +0300)]
doc: fix pathd example config

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoMerge pull request #9256 from idryzhov/dampening-revert
Donald Sharp [Fri, 6 Aug 2021 14:46:09 +0000 (10:46 -0400)]
Merge pull request #9256 from idryzhov/dampening-revert

BGP per-peer dampening revert

3 years agoMerge pull request #9280 from idryzhov/bgp-nb-revert-master
Donald Sharp [Fri, 6 Aug 2021 14:45:59 +0000 (10:45 -0400)]
Merge pull request #9280 from idryzhov/bgp-nb-revert-master

BGP NB revert

3 years agoMerge pull request #9294 from anlancs/fix-ospfd-init
Donald Sharp [Fri, 6 Aug 2021 14:33:08 +0000 (10:33 -0400)]
Merge pull request #9294 from anlancs/fix-ospfd-init

ospfd: fix coverity warning

3 years agobgpd: add protection against too large opaque data structure
Igor Ryzhov [Fri, 6 Aug 2021 14:09:46 +0000 (17:09 +0300)]
bgpd: add protection against too large opaque data structure

BGP opaque data shouldn't be larger than zebra's buffer.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agobgpd: use longer aspath string in opaque data
Igor Ryzhov [Fri, 6 Aug 2021 14:06:39 +0000 (17:06 +0300)]
bgpd: use longer aspath string in opaque data

32 bytes are not enough to carry relatively long AS paths so let's make
the buffer larger.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agotopotests: reduce convergence check frequency
Rafael Zalamena [Tue, 27 Jul 2021 12:47:03 +0000 (09:47 -0300)]
topotests: reduce convergence check frequency

Check for convergence less frequently to reduce resources usage.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
3 years agotopotests: skip daemons without configuration
Rafael Zalamena [Tue, 27 Jul 2021 12:46:12 +0000 (09:46 -0300)]
topotests: skip daemons without configuration

Lets not start daemons without configurations.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
3 years agotopotests: remove code that checks for version
Rafael Zalamena [Tue, 27 Jul 2021 12:45:41 +0000 (09:45 -0300)]
topotests: remove code that checks for version

We version the tests with FRR so we no longer need to check for version.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
3 years agotopotests: use new OSPFv3 interface area syntax
Rafael Zalamena [Tue, 27 Jul 2021 12:44:41 +0000 (09:44 -0300)]
topotests: use new OSPFv3 interface area syntax

The old one is not VRF aware and is being deprecated.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
3 years agotopotests: reduce MSDP topology
Rafael Zalamena [Fri, 6 Aug 2021 13:35:45 +0000 (10:35 -0300)]
topotests: reduce MSDP topology

Meanwhile we don't get all MSDP features (MSDP route validation via BGP
AS Path as described in RFC 4611 Section 2), kill one of the links of
the topology to avoid intermittent test failures due to different
traffic route.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
3 years agopathd: fix indentation and redundant space in index config
Igor Ryzhov [Thu, 5 Aug 2021 20:47:27 +0000 (23:47 +0300)]
pathd: fix indentation and redundant space in index config

Before:
```
segment-routing
 traffic-eng
  segment-list SL1
 index  10 mpls label 16010
```

After:
```
segment-routing
 traffic-eng
  segment-list SL1
   index 10 mpls label 16010
```

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agopathd: fix indentation for mpls-te config
Igor Ryzhov [Thu, 5 Aug 2021 20:45:44 +0000 (23:45 +0300)]
pathd: fix indentation for mpls-te config

Before:
```
segment-routing
 traffic-eng
 mpls-te on
 mpls-te import ospfv2
```

After:
```
segment-routing
 traffic-eng
  mpls-te on
  mpls-te import ospfv2
```

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoMerge pull request #9302 from ton31337/fix/comments
Mark Stapp [Thu, 5 Aug 2021 18:39:38 +0000 (14:39 -0400)]
Merge pull request #9302 from ton31337/fix/comments

bgpd: Fix misleading comments for some parts

3 years agoMerge pull request #9023 from idryzhov/static-nb
Donald Sharp [Thu, 5 Aug 2021 13:38:00 +0000 (09:38 -0400)]
Merge pull request #9023 from idryzhov/static-nb

staticd: simplify the northbound code

3 years agobgpd: Fix misleading comments for some parts
Donatas Abraitis [Thu, 5 Aug 2021 13:29:52 +0000 (16:29 +0300)]
bgpd: Fix misleading comments for some parts

Mostly just retrun => return and misleading comments at all.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
3 years agodoc: Specify how aggregate-address works for BGP
Donatas Abraitis [Wed, 4 Aug 2021 07:41:02 +0000 (10:41 +0300)]
doc: Specify how aggregate-address works for BGP

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
3 years agoospfd: fix coverity warning of one field initialization
anlan_cs [Wed, 4 Aug 2021 12:47:45 +0000 (08:47 -0400)]
ospfd: fix coverity warning of one field initialization

Add the initialization of prefixlen field in struct prefix.

Signed-off-by: anlan_cs <anlan_cs@tom.com>
3 years agoMerge pull request #9050 from LabNConsulting/chopps/reset-parallel
Mark Stapp [Wed, 4 Aug 2021 20:17:30 +0000 (16:17 -0400)]
Merge pull request #9050 from LabNConsulting/chopps/reset-parallel

Chopps/reset parallel

3 years agoMerge pull request #9261 from vivek-cumulus/fix_evpn_quick_flap
Sri Mohana Singamsetty [Wed, 4 Aug 2021 19:44:37 +0000 (12:44 -0700)]
Merge pull request #9261 from vivek-cumulus/fix_evpn_quick_flap

bgpd: Handle quick flaps of an EVPN prefix properly

3 years agoMerge pull request #9291 from donaldsharp/fix_long_sleep
Mark Stapp [Wed, 4 Aug 2021 16:54:25 +0000 (12:54 -0400)]
Merge pull request #9291 from donaldsharp/fix_long_sleep

tests: Remove sleep(200) from bgp-evpn-overlay-index-gateway

3 years agoMerge pull request #8182 from mjstapp/topotest_start_tgen
Donald Sharp [Wed, 4 Aug 2021 12:48:06 +0000 (08:48 -0400)]
Merge pull request #8182 from mjstapp/topotest_start_tgen

tests: make the topogen object available when starting daemons

3 years agotests: Remove sleep(200) from bgp-evpn-overlay-index-gateway
Donald Sharp [Wed, 4 Aug 2021 12:05:12 +0000 (08:05 -0400)]
tests: Remove sleep(200) from bgp-evpn-overlay-index-gateway

Remove a 200 second sleep from bgp-evpn-overlay-index-gateway.
There does not seem to be any evidence that this is needed
and I cannot make the test fail without it.

Fixes: #9035
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
3 years agoMerge pull request #9085 from mobash-rasool/pim-upst-4
Donald Sharp [Wed, 4 Aug 2021 01:21:14 +0000 (21:21 -0400)]
Merge pull request #9085 from mobash-rasool/pim-upst-4

pimd: memory leak fix and issue fix

3 years agoMerge pull request #9092 from rgirada/rmap
Donald Sharp [Wed, 4 Aug 2021 01:18:21 +0000 (21:18 -0400)]
Merge pull request #9092 from rgirada/rmap

ospfd: OSPF hello packets not sent with configured hello timer

3 years agoMerge pull request #9108 from opensourcerouting/ospf6d-range-fixes
Donald Sharp [Wed, 4 Aug 2021 01:15:12 +0000 (21:15 -0400)]
Merge pull request #9108 from opensourcerouting/ospf6d-range-fixes

ospf6d: fix argument processing in the "area ... range" command

3 years agoRevert "tests/bgpd: initialized candidate_config to vtysh"
Igor Ryzhov [Fri, 14 May 2021 12:36:24 +0000 (15:36 +0300)]
Revert "tests/bgpd: initialized candidate_config to vtysh"

This reverts commit 64fb3f86661c0f5ac2f9017a7b6b999dbcb8e2e4.

3 years agoRevert "tests: add bgp yang module registery to attr test"
Igor Ryzhov [Fri, 14 May 2021 00:06:04 +0000 (03:06 +0300)]
Revert "tests: add bgp yang module registery to attr test"

This reverts commit 15cbc382061ee8807dbe79827c96ae94a4aa90c6.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: register northbound callbacks to bootstrap"
Igor Ryzhov [Thu, 13 May 2021 23:57:30 +0000 (02:57 +0300)]
Revert "bgpd: register northbound callbacks to bootstrap"

This reverts commit e4a464160dee2b53f2851879b2c736139061e74c.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: bgp northbound callbacks prototypes"
Igor Ryzhov [Thu, 13 May 2021 23:21:54 +0000 (02:21 +0300)]
Revert "bgpd: bgp northbound callbacks prototypes"

This reverts commit a1950c80a570e721503de4cf86de7a247e900781.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: convert global config to transactional cli"
Igor Ryzhov [Thu, 13 May 2021 23:20:04 +0000 (02:20 +0300)]
Revert "bgpd: convert global config to transactional cli"

This reverts commit ff8a8a7ac10b3211d5586c29dfcc5a3b32841029.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: register nb routing hook"
Igor Ryzhov [Thu, 13 May 2021 23:16:29 +0000 (02:16 +0300)]
Revert "bgpd: register nb routing hook"

This reverts commit 374069da83f5f00f53156e1886372391c3f00b3f.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: shorten northbound callback names"
Igor Ryzhov [Thu, 13 May 2021 23:15:46 +0000 (02:15 +0300)]
Revert "bgpd: shorten northbound callback names"

This reverts commit 906ebeec9800d3aef0eddb70ce74b48e370cb5ce.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: correct bgp global context"
Igor Ryzhov [Thu, 13 May 2021 23:13:40 +0000 (02:13 +0300)]
Revert "bgpd: correct bgp global context"

This reverts commit 87ce25646be36bb9a27e75d177615e3d19a07df0.

3 years agoRevert "bgpd: move router bgp nb callback"
Igor Ryzhov [Thu, 13 May 2021 23:13:20 +0000 (02:13 +0300)]
Revert "bgpd: move router bgp nb callback"

This reverts commit 5e42cb2fb088a28202e60ec57a4116f3d1f0afd5.

3 years agoRevert "bgpd: no router bgp check candidate config"
Igor Ryzhov [Thu, 13 May 2021 23:13:15 +0000 (02:13 +0300)]
Revert "bgpd: no router bgp check candidate config"

This reverts commit 4b63e358bc213bfa9d1baeda6fbbdfa39df60d2e.

3 years agoRevert "bgpd: fix SA warnings in bgp northbound"
Igor Ryzhov [Thu, 13 May 2021 23:12:55 +0000 (02:12 +0300)]
Revert "bgpd: fix SA warnings in bgp northbound"

This reverts commit 082de39e7155e958416564f65286d4b57434ce4a.

3 years agoRevert "bgpd: Use default VRF name if using `router bgp` command"
Igor Ryzhov [Thu, 13 May 2021 23:12:49 +0000 (02:12 +0300)]
Revert "bgpd: Use default VRF name if using `router bgp` command"

This reverts commit 5ce106b72bac1c45567159c4dfcc9276164bd18b.

3 years agoRevert "bgpd: rename router bgp callbacks"
Igor Ryzhov [Thu, 13 May 2021 23:12:33 +0000 (02:12 +0300)]
Revert "bgpd: rename router bgp callbacks"

This reverts commit feded4118b89eba5a1629f45cfe623277612e404.

3 years agoRevert "bgpd: fix crash in bgp instance creation"
Igor Ryzhov [Thu, 13 May 2021 23:12:29 +0000 (02:12 +0300)]
Revert "bgpd: fix crash in bgp instance creation"

This reverts commit a5ab756f2483594a19837e0c30f6184cd966940f.

3 years agoRevert "bgpd: use common api in bgp_get"
Igor Ryzhov [Thu, 13 May 2021 23:12:24 +0000 (02:12 +0300)]
Revert "bgpd: use common api in bgp_get"

This reverts commit bdaadb91e8adc103197d8f57a6a3358ff313a23c.

3 years agoRevert "yang: update bgp module afi-safi parameters"
Igor Ryzhov [Thu, 13 May 2021 23:11:51 +0000 (02:11 +0300)]
Revert "yang: update bgp module afi-safi parameters"

This reverts commit 3b66fcef5833da4eeb2dd19922778b108a1c63c1.

3 years agoRevert "bgpd: convert addr-family clis to transactional clis"
Igor Ryzhov [Thu, 13 May 2021 23:11:43 +0000 (02:11 +0300)]
Revert "bgpd: convert addr-family clis to transactional clis"

This reverts commit 37a87b8f9865fe17a235b9a76a0dc47f03aae3df.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: add match-med nb support in aggregate cmd"
Igor Ryzhov [Thu, 13 May 2021 23:08:17 +0000 (02:08 +0300)]
Revert "bgpd: add match-med nb support in aggregate cmd"

This reverts commit fa423774ff303ffc62db91f8aa09995711e81d50.

3 years agoRevert "bgpd: add nb support for suppress-map in aggregate cmd"
Igor Ryzhov [Thu, 13 May 2021 23:08:11 +0000 (02:08 +0300)]
Revert "bgpd: add nb support for suppress-map in aggregate cmd"

This reverts commit 90e21f3535ff2d887cbb52f0e4e6fe4907095d70.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: neighbor peergrp config to transactional cli"
Igor Ryzhov [Thu, 13 May 2021 23:06:27 +0000 (02:06 +0300)]
Revert "bgpd: neighbor peergrp config to transactional cli"

This reverts commit f4b8ec07219cce13c8627efe311247ee06f3a8ab.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "*: shorten name of prefix-limit options"
Igor Ryzhov [Thu, 13 May 2021 22:52:29 +0000 (01:52 +0300)]
Revert "*: shorten name of prefix-limit options"

This reverts commit afe03f6094656c9f96150223c1ed5ee8e9a4ba93.

3 years agoRevert "bgpd: convert max prefix clis to transactional"
Igor Ryzhov [Thu, 13 May 2021 22:52:25 +0000 (01:52 +0300)]
Revert "bgpd: convert max prefix clis to transactional"

This reverts commit 04261decb9901c931f1800f27c459f3a0483776c.

3 years agoRevert "bgpd: convert neighbor peer config to transactional"
Igor Ryzhov [Thu, 13 May 2021 22:52:20 +0000 (01:52 +0300)]
Revert "bgpd: convert neighbor peer config to transactional"

This reverts commit 8611c7f3b6f33cb5ef8687bc126354d06eadbfcf.

3 years agoRevert "bgpd: shorten names for default originate nb callbacks"
Igor Ryzhov [Thu, 13 May 2021 22:52:15 +0000 (01:52 +0300)]
Revert "bgpd: shorten names for default originate nb callbacks"

This reverts commit cc4440c3177f312294ec0cec836f41e453b367fb.

3 years agoRevert "bgpd: default originate transactional callbacks"
Igor Ryzhov [Thu, 13 May 2021 22:52:10 +0000 (01:52 +0300)]
Revert "bgpd: default originate transactional callbacks"

This reverts commit 7c54def2926e85d760a7ab42f879a6545630878f.

3 years agoRevert "bgpd: Actually return the group peer"
Igor Ryzhov [Thu, 13 May 2021 22:51:34 +0000 (01:51 +0300)]
Revert "bgpd: Actually return the group peer"

This reverts commit e5209541f2f425c25ef016be2cade323b327ea17.

3 years agoRevert "bgpd: Check if peer is not NULL before calling peer_as_change()"
Igor Ryzhov [Thu, 13 May 2021 22:50:56 +0000 (01:50 +0300)]
Revert "bgpd: Check if peer is not NULL before calling peer_as_change()"

This reverts commit 7a68370285ed4d64e1ed9dcab60b17bfb26a0ba4.

3 years agoRevert "bgpd: Respect `-e X` value for multipath"
Igor Ryzhov [Thu, 13 May 2021 22:50:05 +0000 (01:50 +0300)]
Revert "bgpd: Respect `-e X` value for multipath"

This reverts commit 76bd07b6881add1fbeafa5dc11c48d9ad6a00f14.

3 years agoRevert "bgpd: fix compiler warnings in nbr cmd"
Igor Ryzhov [Thu, 13 May 2021 22:49:37 +0000 (01:49 +0300)]
Revert "bgpd: fix compiler warnings in nbr cmd"

This reverts commit 555c8ab7ad7a9f60c8d6cc9dd48705f0ee364797.

3 years agoRevert "bgpd: convert to yang modeled nbr cmds"
Igor Ryzhov [Thu, 13 May 2021 22:49:19 +0000 (01:49 +0300)]
Revert "bgpd: convert to yang modeled nbr cmds"

This reverts commit 232c75cd032a0ff8a6540f03a10cb1ae3143af06.

3 years agoRevert "bgpd: Prevent null deref"
Igor Ryzhov [Thu, 13 May 2021 22:44:16 +0000 (01:44 +0300)]
Revert "bgpd: Prevent null deref"

This reverts commit e80bc08944be7cbe4085c03653818139ccd616d1.

3 years agoRevert "bgpd: convert neighbor plist to transactional cli"
Igor Ryzhov [Thu, 13 May 2021 22:43:32 +0000 (01:43 +0300)]
Revert "bgpd: convert neighbor plist to transactional cli"

This reverts commit d9986d26c0a48f9cc2afeaa15fe304b094c041e4.

3 years agoRevert "yang: nbr plist nb conversion for more afi-safis"
Igor Ryzhov [Thu, 13 May 2021 22:43:28 +0000 (01:43 +0300)]
Revert "yang: nbr plist nb conversion for more afi-safis"

This reverts commit f4eac84c5ac136bc7dd37f2c950d375e94616bc4.

3 years agoRevert "bgpd: convert nbr rmap transactional cli"
Igor Ryzhov [Thu, 13 May 2021 22:43:23 +0000 (01:43 +0300)]
Revert "bgpd: convert nbr rmap transactional cli"

This reverts commit c6685575336566680aeb537e8ed5abb164be0268.

3 years agoRevert "bgpd: fix unsetting of multipath as-set"
Igor Ryzhov [Thu, 13 May 2021 22:42:38 +0000 (01:42 +0300)]
Revert "bgpd: fix unsetting of multipath as-set"

This reverts commit 174c5be33c433b9cc586d3aeee178407d282d97f.

3 years agoRevert "bgpd: fix removal of rd vpn export"
Igor Ryzhov [Thu, 13 May 2021 22:42:33 +0000 (01:42 +0300)]
Revert "bgpd: fix removal of rd vpn export"

This reverts commit c576dc6a4f5c62aeeb5e77e41c0f8efbf7f5797f.

3 years agoRevert "bgpd: Temp fix to allow numbered peers to be part of a peer group"
Igor Ryzhov [Thu, 13 May 2021 22:42:19 +0000 (01:42 +0300)]
Revert "bgpd: Temp fix to allow numbered peers to be part of a peer group"

This reverts commit 2a059a5448c37699eabd8802b44427978ec645ac.

3 years agoRevert "bgpd: Remove hidden `neighbor X route-map Y <in|out>` command"
Igor Ryzhov [Thu, 13 May 2021 22:42:07 +0000 (01:42 +0300)]
Revert "bgpd: Remove hidden `neighbor X route-map Y <in|out>` command"

This reverts commit 4c3e9f072a415aa02f367aaff1cc90dd6fda5d06.

3 years agoRevert "bgpd: fix 'neighbor X prefix-list Y in' SAFI VPN"
Igor Ryzhov [Thu, 13 May 2021 22:41:40 +0000 (01:41 +0300)]
Revert "bgpd: fix 'neighbor X prefix-list Y in' SAFI VPN"

This reverts commit 9fa7a8bf3769914620225826e4ca8ef3f8182106.

3 years agoRevert "bgpd: don't rely on northbound control plane protocol vrf pointer"
Igor Ryzhov [Thu, 13 May 2021 22:41:27 +0000 (01:41 +0300)]
Revert "bgpd: don't rely on northbound control plane protocol vrf pointer"

This reverts commit 3fa607bebacd4881053414d641e8376b4e4f6e83.

3 years agoRevert "bgpd: convert send-community to transactional cli"
Igor Ryzhov [Thu, 13 May 2021 22:40:02 +0000 (01:40 +0300)]
Revert "bgpd: convert send-community to transactional cli"

This reverts commit e48a9a90e07ccdeae8f6bcdff9c433f5d6ea0b39.

3 years agoRevert "bgpd: remove duplicated checks from CLI"
Igor Ryzhov [Thu, 13 May 2021 22:39:29 +0000 (01:39 +0300)]
Revert "bgpd: remove duplicated checks from CLI"

This reverts commit 45d1d7c9a2b7b41125e565af566e10d470349122.

3 years agoRevert "bgpd: don't use operational state in "router bgp" command"
Igor Ryzhov [Thu, 13 May 2021 22:39:24 +0000 (01:39 +0300)]
Revert "bgpd: don't use operational state in "router bgp" command"

This reverts commit 4062b455a6eacfe3f5107daa68351b18cc0ca7e7.

3 years agoRevert "bgpd: convert l2vpn evpn nbr route-map to nb"
Igor Ryzhov [Thu, 13 May 2021 22:39:10 +0000 (01:39 +0300)]
Revert "bgpd: convert l2vpn evpn nbr route-map to nb"

This reverts commit 8be861e60b7f6069c8a1c2aab75bbbbed3b57829.

3 years agoRevert "bgpd: prefix-list and route-map nb fixes"
Igor Ryzhov [Thu, 13 May 2021 22:39:03 +0000 (01:39 +0300)]
Revert "bgpd: prefix-list and route-map nb fixes"

This reverts commit 68a57089122b22414b04ebc28bd0db81051fdcbd.

3 years agoRevert "bgpd: vrf route leaking, fix the bgp instance delete and re-add"
Igor Ryzhov [Thu, 13 May 2021 22:38:33 +0000 (01:38 +0300)]
Revert "bgpd: vrf route leaking, fix the bgp instance delete and re-add"

This reverts commit ef7c53e244d5d0cd7c0ba2536fc931abf28df656.

3 years agoRevert "bgpd: fix bgp_get_vty return values"
Igor Ryzhov [Thu, 13 May 2021 22:38:09 +0000 (01:38 +0300)]
Revert "bgpd: fix bgp_get_vty return values"

This reverts commit d09328e5991c9f657758921264492825e7081175.

3 years agoRevert "bgpd: fix crash when as/type mismatches in config"
Igor Ryzhov [Thu, 13 May 2021 22:37:44 +0000 (01:37 +0300)]
Revert "bgpd: fix crash when as/type mismatches in config"

This reverts commit 0d6d0208a55c786513f472ad690bae1788e173fa.

3 years agoRevert "bgpd: simplify bgp_global_local_as_modify code"
Igor Ryzhov [Thu, 13 May 2021 22:37:38 +0000 (01:37 +0300)]
Revert "bgpd: simplify bgp_global_local_as_modify code"

This reverts commit debb7b1931cdf5b3e06ca244bf09bb009b5a8677.

3 years agoRevert "bgpd: forbid modification of bgp instance type"
Igor Ryzhov [Thu, 13 May 2021 22:37:27 +0000 (01:37 +0300)]
Revert "bgpd: forbid modification of bgp instance type"

This reverts commit d3e3677096e5cf30116ca63879caf44e25b080ad.

3 years agoRevert "bgpd: don't return error for GR no-op commands"
Igor Ryzhov [Thu, 13 May 2021 22:37:06 +0000 (01:37 +0300)]
Revert "bgpd: don't return error for GR no-op commands"

This reverts commit 895b0d0ad6e39ad54e82e5c3d9060aa390c8bdd8.

3 years agoRevert "bgpd: peer / peer group dampening profiles"
Igor Ryzhov [Mon, 2 Aug 2021 10:26:58 +0000 (13:26 +0300)]
Revert "bgpd: peer / peer group dampening profiles"

This reverts commit 40ec3340be9cdda62eea349fe9ee21e65156f422.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: vtysh commands for peer/group dampening profiles"
Igor Ryzhov [Mon, 2 Aug 2021 10:19:10 +0000 (13:19 +0300)]
Revert "bgpd: vtysh commands for peer/group dampening profiles"

This reverts commit 0221327c75d370648d20c2bc4d281c23f5738f74.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: Do not output peer doppleganger dampened output"
Igor Ryzhov [Mon, 2 Aug 2021 10:43:28 +0000 (13:43 +0300)]
Revert "bgpd: Do not output peer doppleganger dampened output"

This reverts commit 783492c7cdeaca5c73fb2debaeaa0b378ee734de.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: Consolidate dampening show run output with the rest of that code"
Igor Ryzhov [Mon, 2 Aug 2021 10:42:56 +0000 (13:42 +0300)]
Revert "bgpd: Consolidate dampening show run output with the rest of that code"

This reverts commit 39d8dd2d176e26cff9c62f48048b18cf4df9168a.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "doc: user doc for route-flap dampening commands"
Igor Ryzhov [Mon, 2 Aug 2021 10:17:42 +0000 (13:17 +0300)]
Revert "doc: user doc for route-flap dampening commands"

This reverts commit 54b34709f8603be3f7d13ae224aa8cade49b1741.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "tests: topotests for route-flap dampening"
Igor Ryzhov [Mon, 2 Aug 2021 10:15:45 +0000 (13:15 +0300)]
Revert "tests: topotests for route-flap dampening"

This reverts commit cd32a1a4eecf2a29dbfd2493573f7473e20096d9.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoRevert "bgpd: clear ip bgp dampening was not triggering the route calculation for...
Igor Ryzhov [Mon, 2 Aug 2021 10:05:22 +0000 (13:05 +0300)]
Revert "bgpd: clear ip bgp dampening was not triggering the route calculation for the prefix"

This reverts commit c8ddbd48040be6bf33c4f0ab3e470f290f9b165a.

3 years agoRevert "bgpd: Remove useless reuselist_node assignment before while loop"
Igor Ryzhov [Mon, 2 Aug 2021 10:01:48 +0000 (13:01 +0300)]
Revert "bgpd: Remove useless reuselist_node assignment before while loop"

This reverts commit 53048d33d124e60ce01ae6bf149ae03561930694.

3 years agoRevert "bgpd: Do not test against bdc again since we already validated"
Igor Ryzhov [Mon, 2 Aug 2021 10:01:44 +0000 (13:01 +0300)]
Revert "bgpd: Do not test against bdc again since we already validated"

This reverts commit 63fc789a109cf5e086d7494cea7a9f516550839c.

3 years agoRevert "bgpd: fix double free in dampening code"
Igor Ryzhov [Mon, 2 Aug 2021 10:01:38 +0000 (13:01 +0300)]
Revert "bgpd: fix double free in dampening code"

This reverts commit 96d6b8cc29bf5124ae93433ecfc16b3fd69be5ea.

3 years agoRevert "bgpd: Drop double-pointer for bgp_damp_info_free()"
Igor Ryzhov [Mon, 2 Aug 2021 10:01:32 +0000 (13:01 +0300)]
Revert "bgpd: Drop double-pointer for bgp_damp_info_free()"

This reverts commit 19971c9a9218b31e6e1c3f7ebb23654f833bb4ef.

3 years agoRevert "bgpd: fix missing list add in dampening"
Igor Ryzhov [Mon, 2 Aug 2021 10:01:26 +0000 (13:01 +0300)]
Revert "bgpd: fix missing list add in dampening"

This reverts commit cd58568b1889df753aa258ee61b6d949b1ce6fb9.

3 years agoRevert "bgpd: fix incorrect usage of slist in dampening"
Igor Ryzhov [Mon, 2 Aug 2021 10:01:18 +0000 (13:01 +0300)]
Revert "bgpd: fix incorrect usage of slist in dampening"

This reverts commit 5054cfcbbc8c776a91e9390d36cff891d0890b4f.

3 years agoRevert "bgpd: cleanup bgp_damp_info_free"
Igor Ryzhov [Mon, 2 Aug 2021 10:01:06 +0000 (13:01 +0300)]
Revert "bgpd: cleanup bgp_damp_info_free"

This reverts commit 97766ac8aa40ff8868a854ba8515c9e6441e4b7c.

3 years agoRevert "bgpd: fix missing damp info free when cleaning bgp path"
Igor Ryzhov [Mon, 2 Aug 2021 10:33:09 +0000 (13:33 +0300)]
Revert "bgpd: fix missing damp info free when cleaning bgp path"

This reverts commit 4538f89552a01e6ab3504f8a59ef156b9a14ce1c.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
3 years agoMerge pull request #9264 from ak503/nhrp_fix
Russ White [Tue, 3 Aug 2021 17:42:48 +0000 (13:42 -0400)]
Merge pull request #9264 from ak503/nhrp_fix

nhrp: fix display of nhs command.