]> git.proxmox.com Git - pve-manager.git/log
pve-manager.git
8 years agofix bug #821: add systemd-timesyncd to service list.
Wolfgang Bumiller [Tue, 1 Dec 2015 09:41:53 +0000 (10:41 +0100)]
fix bug #821: add systemd-timesyncd to service list.

8 years agoext6migrate: remove redundant code to set the default active tab
Emmanuel Kasper [Mon, 30 Nov 2015 14:00:43 +0000 (15:00 +0100)]
ext6migrate: remove redundant code to set the default active tab

If the default activeTab is *undefined* and *not* null, activeTab defaults to 0,
so we don't need to set this explicitely.

dug from ExtJS tabPanel:
activeTab = me.activeTab !== null ? (me.activeTab || 0) : null;

8 years agoext6migrate: listen to 'activate' events for panels inside a tabpanel
Emmanuel Kasper [Mon, 23 Nov 2015 14:13:12 +0000 (15:13 +0100)]
ext6migrate: listen to 'activate' events for panels inside a tabpanel

Using ExtJS6 a browser refresh (F5) do not send the 'show' event which we use to display the store as it did with ExtJS4.

At the momment only for tabs inside the datacenter tabpanel, since node and lxc tabpanels are not yet in manager6/

8 years agobump version to 4.0-63
Dietmar Maurer [Fri, 27 Nov 2015 12:31:18 +0000 (13:31 +0100)]
bump version to 4.0-63

8 years agopveproxy.service: start after remote-fs and ceph
Dietmar Maurer [Fri, 27 Nov 2015 08:14:11 +0000 (09:14 +0100)]
pveproxy.service: start after remote-fs and ceph

8 years agoinfluxdb : use multi values measurement
Alexandre Derumier [Wed, 25 Nov 2015 06:57:02 +0000 (07:57 +0100)]
influxdb : use multi values measurement

influxdb (> 0.9.5) now support fastly multiple values by mesuerement,
through a new column store engine.

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
8 years agoadd qemu agent gui option
Alexandre Derumier [Mon, 23 Nov 2015 13:39:16 +0000 (14:39 +0100)]
add qemu agent gui option

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
8 years agopve-manager.service: start after pve-ha-crm.service and pve-ha-lrm.service
Dietmar Maurer [Wed, 25 Nov 2015 12:23:25 +0000 (13:23 +0100)]
pve-manager.service: start after pve-ha-crm.service and pve-ha-lrm.service

To priorize HA VMs.

8 years agopve-manager.service: start after spiceproxy
Dietmar Maurer [Wed, 25 Nov 2015 12:17:54 +0000 (13:17 +0100)]
pve-manager.service: start after spiceproxy

8 years agopveproxy.service: add Wants=ssh.service
Dietmar Maurer [Wed, 25 Nov 2015 12:06:55 +0000 (13:06 +0100)]
pveproxy.service: add Wants=ssh.service

and make sure sshd is running while pveproxy is active

8 years agopve-manager.service: do not invoke old init.d script
Dietmar Maurer [Wed, 25 Nov 2015 12:00:38 +0000 (13:00 +0100)]
pve-manager.service: do not invoke old init.d script

redirect stdout/stderr to null, because we already log to pve task log.

8 years agoimprove log messages at sytem shutdown
Dietmar Maurer [Wed, 25 Nov 2015 08:46:33 +0000 (09:46 +0100)]
improve log messages at sytem shutdown

8 years agopvesh: use PVE::SafeSyslog
Dietmar Maurer [Wed, 25 Nov 2015 10:56:31 +0000 (11:56 +0100)]
pvesh: use PVE::SafeSyslog

8 years agopvestatd: use 'priv' environment for service
Dietmar Maurer [Wed, 25 Nov 2015 07:03:25 +0000 (08:03 +0100)]
pvestatd: use 'priv' environment for service

8 years agobump version to 4.0-62
Dietmar Maurer [Tue, 24 Nov 2015 16:31:38 +0000 (17:31 +0100)]
bump version to 4.0-62

8 years agoremove unused var
Dietmar Maurer [Tue, 24 Nov 2015 16:29:57 +0000 (17:29 +0100)]
remove unused var

8 years agopvedaemon.service: Wants=corosync.service to fix shutdown order
Dietmar Maurer [Tue, 24 Nov 2015 16:25:50 +0000 (17:25 +0100)]
pvedaemon.service: Wants=corosync.service to fix shutdown order

To make sure /etc/pve/ is functional while pvedaemon is running.

8 years agopve-manager.service: add dependencies to fix shutdown order
Dietmar Maurer [Tue, 24 Nov 2015 16:22:09 +0000 (17:22 +0100)]
pve-manager.service: add dependencies to fix shutdown order

8 years agobump version to 4.0-61
Dietmar Maurer [Fri, 20 Nov 2015 09:06:00 +0000 (10:06 +0100)]
bump version to 4.0-61

8 years agoceph.conf : remove auth_supported
Alexandre Derumier [Thu, 19 Nov 2015 08:41:41 +0000 (09:41 +0100)]
ceph.conf : remove auth_supported

It's not used since ceph 0.50,
replaced by the 3 others auth config options

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
8 years agoAllow email adresses with a top level domain of up to 63 characters
Emmanuel Kasper [Tue, 17 Nov 2015 15:34:18 +0000 (16:34 +0100)]
Allow email adresses with a top level domain of up to 63 characters

Reapply fix for  https://bugzilla.proxmox.com/show_bug.cgi?id=716
which was missing in manager6/ directory

8 years agoCorrect whitespaces and comment non obvious class properties
Emmanuel Kasper [Tue, 17 Nov 2015 15:34:17 +0000 (16:34 +0100)]
Correct whitespaces and comment non obvious class properties

8 years agoext6migrate: move class static properties out of initComponent()
Emmanuel Kasper [Mon, 16 Nov 2015 13:02:16 +0000 (14:02 +0100)]
ext6migrate: move class static properties out of initComponent()

This fixes the Auth realm selection while login with ExtJS6

8 years agoext6migrate: move static class properties out of initComponent()
Emmanuel Kasper [Mon, 16 Nov 2015 13:02:15 +0000 (14:02 +0100)]
ext6migrate: move static class properties out of initComponent()

Besides fitting more with the declarative style of ExtJS, this has the
interesting side effect of allowing comboboxes to work with ExtJS6

8 years agoext6migrate: force an empty array as default value for filters
Emmanuel Kasper [Mon, 16 Nov 2015 13:02:14 +0000 (14:02 +0100)]
ext6migrate: force an empty array as default value for filters

Without this, filters.add() in line 73 file fails

8 years agofix bug #575: fork at shutdown, so that partent starts new worker
Dietmar Maurer [Tue, 10 Mar 2015 07:23:18 +0000 (08:23 +0100)]
fix bug #575: fork at shutdown, so that partent starts new worker

8 years agoext6migrate: Replace deprecated function which is missing in Ext6
Emmanuel Kasper [Thu, 12 Nov 2015 12:15:28 +0000 (13:15 +0100)]
ext6migrate: Replace deprecated function which is missing in Ext6

See http://docs.sencha.com/extjs/5.1/5.1.0-apidocs/#!/api/Ext.container.Container-method-doLayout

This allows the pve manager to load

8 years agoSwitch to triton theme as default theme in ExtJS6
Emmanuel Kasper [Thu, 12 Nov 2015 12:15:27 +0000 (13:15 +0100)]
Switch to triton theme as default theme in ExtJS6

8 years agoAdd mime type for woff2 fonts, also update mime type for ttf fonts
Emmanuel Kasper [Thu, 12 Nov 2015 12:15:26 +0000 (13:15 +0100)]
Add mime type for woff2 fonts, also update mime type for ttf fonts

application/font-woff2 is still in discussion but works in main three browsers
This is needed for ExtJS6, which includes some woff2 fonts

ttf font mime type is taken from the official IANA assignment, and works as
well in main three browsers

8 years agoremove old extJS5 files
Dietmar Maurer [Fri, 13 Nov 2015 06:20:48 +0000 (07:20 +0100)]
remove old extJS5 files

8 years agorename manager5 to manager6
Dietmar Maurer [Fri, 13 Nov 2015 06:16:44 +0000 (07:16 +0100)]
rename manager5 to manager6

8 years agoupdate build infrastucture to be able to develop with Ext6
Emmanuel Kasper [Tue, 10 Nov 2015 13:36:09 +0000 (14:36 +0100)]
update build infrastucture to be able to develop with Ext6

8 years agobump version to 4.0-60
Dietmar Maurer [Tue, 10 Nov 2015 06:49:19 +0000 (07:49 +0100)]
bump version to 4.0-60

8 years agomake startall wait up to 60 seconds for quorum
Thomas Lamprecht [Mon, 9 Nov 2015 10:44:25 +0000 (11:44 +0100)]
make startall wait up to 60 seconds for quorum

Previously we waited 10 seconds, in PVE 4 system sometimes need more
time to initialize all services so the didn't execute the startall
command even if a few seconds later cfs quorum was etablished.
This is a background process started from the pve-manager init
script, thus waiting doesn't interferes with other processes, so
wait long enough.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 years agobump version to 4.0-59
Dietmar Maurer [Fri, 6 Nov 2015 09:21:18 +0000 (10:21 +0100)]
bump version to 4.0-59

8 years agoSytem Report: place download button at bottom/right
Dietmar Maurer [Fri, 6 Nov 2015 09:19:29 +0000 (10:19 +0100)]
Sytem Report: place download button at bottom/right

8 years agoAdd report modal window, containing pvereport content
Emmanuel Kasper [Thu, 5 Nov 2015 16:20:16 +0000 (17:20 +0100)]
Add report modal window, containing pvereport content

Signed-off-by: Emmanuel Kasper <e.kasper@proxmox.com>
8 years agoUse protected mode to be able to execute root system commands
Emmanuel Kasper [Thu, 5 Nov 2015 16:20:15 +0000 (17:20 +0100)]
Use protected mode to be able to execute root system commands

Signed-off-by: Emmanuel Kasper <e.kasper@proxmox.com>
8 years agoreport: change return type to string
Dietmar Maurer [Tue, 3 Nov 2015 17:14:51 +0000 (18:14 +0100)]
report: change return type to string

8 years agoAdd REST endpoint for /report call
Emmanuel Kasper [Tue, 3 Nov 2015 15:42:17 +0000 (16:42 +0100)]
Add REST endpoint for /report call

8 years agoMove pvereport functionality into a separate PVE package
Emmanuel Kasper [Tue, 3 Nov 2015 15:42:16 +0000 (16:42 +0100)]
Move pvereport functionality into a separate PVE package

8 years agobump version to 4.0-58
Dietmar Maurer [Fri, 30 Oct 2015 15:13:45 +0000 (16:13 +0100)]
bump version to 4.0-58

8 years agoImprove HA UI for users with restricted permissions
Thomas Lamprecht [Fri, 30 Oct 2015 14:15:00 +0000 (15:15 +0100)]
Improve HA UI for users with restricted permissions

Only show edit dialogs for HA resources and groups when an user
has the privileges to edit them.

8 years agobump version to 4.0-57
Dietmar Maurer [Fri, 30 Oct 2015 06:18:08 +0000 (07:18 +0100)]
bump version to 4.0-57

8 years agoPretty format the output of multiple files in a directory
Emmanuel Kasper [Thu, 29 Oct 2015 13:35:16 +0000 (14:35 +0100)]
Pretty format the output of multiple files in a directory

Also, don't "cat" non existing files

8 years agoadd Galician to GUI
Dietmar Maurer [Wed, 28 Oct 2015 12:01:39 +0000 (13:01 +0100)]
add Galician to GUI

8 years agobump version to 4.0-56
Dietmar Maurer [Wed, 28 Oct 2015 10:53:57 +0000 (11:53 +0100)]
bump version to 4.0-56

8 years agoadd bios report to pvereport
Wolfgang Link [Wed, 28 Oct 2015 09:54:04 +0000 (10:54 +0100)]
add bios report to pvereport

8 years agoadd mouint point to GUI
Wolfgang Link [Wed, 28 Oct 2015 08:44:31 +0000 (09:44 +0100)]
add mouint point to GUI

8 years agoadd resize LXC Mountpoint at the GUI
Wolfgang Link [Wed, 28 Oct 2015 08:44:30 +0000 (09:44 +0100)]
add resize LXC Mountpoint at the GUI

8 years agomove Root Disk form Options to Resources and add icon for it
Wolfgang Link [Wed, 28 Oct 2015 08:44:29 +0000 (09:44 +0100)]
move Root Disk form Options to Resources and add icon for it

8 years agoadd icons to resources
Wolfgang Link [Wed, 28 Oct 2015 08:44:28 +0000 (09:44 +0100)]
add icons to resources

8 years agoadd swap icon for LXC resources
Wolfgang Link [Wed, 28 Oct 2015 08:44:27 +0000 (09:44 +0100)]
add swap icon for LXC resources

8 years agoRBD: select 'images' content type by default
Dietmar Maurer [Wed, 28 Oct 2015 10:14:39 +0000 (11:14 +0100)]
RBD: select 'images' content type by default

because we also do not set KRBD flag by default.

8 years agobump version to 4.0-55
Dietmar Maurer [Wed, 28 Oct 2015 08:26:22 +0000 (09:26 +0100)]
bump version to 4.0-55

8 years agopve-manager service : start after open-iscsi
Alexandre Derumier [Tue, 27 Oct 2015 16:37:33 +0000 (17:37 +0100)]
pve-manager service : start after open-iscsi

Currently,if we have vms on lvm on top of iscsi,

pve-manager service start them too early at host boot,
before open-iscsi daemon, and vm don't start.

Reported-by: Philippe Guy <ph.guy@decidem.fr>
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
8 years agopveceph install : use release repository
Alexandre Derumier [Tue, 27 Oct 2015 13:19:37 +0000 (14:19 +0100)]
pveceph install : use release repository

and increase git release key retrieval.
(ceph.com git seem to be quite slow currently)

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
8 years agoAdd new pvereport command
Emmanuel Kasper [Thu, 22 Oct 2015 08:46:05 +0000 (10:46 +0200)]
Add new pvereport command

8 years agoremove old/usused init.d files in postinst
Dietmar Maurer [Sat, 24 Oct 2015 08:35:20 +0000 (10:35 +0200)]
remove old/usused init.d files in postinst

8 years agobump version to 4.0-54
Dietmar Maurer [Sat, 24 Oct 2015 07:55:15 +0000 (09:55 +0200)]
bump version to 4.0-54

8 years agofix lxc crteate wizard
Dietmar Maurer [Sat, 24 Oct 2015 07:54:22 +0000 (09:54 +0200)]
fix lxc crteate wizard

8 years agofix create CT: this fix the create CT what happend in previous refactoring.
Wolfgang Link [Fri, 23 Oct 2015 13:33:19 +0000 (15:33 +0200)]
fix create CT: this fix the create CT what happend in previous refactoring.

8 years agobump version to 4.0-52
Dietmar Maurer [Fri, 23 Oct 2015 11:41:02 +0000 (13:41 +0200)]
bump version to 4.0-52

8 years agofix bug #781: separate CPU and memory in editor
Wolfgang Link [Fri, 23 Oct 2015 09:04:48 +0000 (11:04 +0200)]
fix bug #781: separate CPU and memory in editor

This is necessary because CPU are not hot-plug-able and memory are hot-plug-able.
also this will be useful for the new resource window.

8 years agobump version to 4.0-51
Dietmar Maurer [Tue, 20 Oct 2015 07:52:07 +0000 (09:52 +0200)]
bump version to 4.0-51

8 years agoFix check if vm is ha managed in get_start_stop_list
Thomas Lamprecht [Mon, 19 Oct 2015 16:02:47 +0000 (18:02 +0200)]
Fix check if vm is ha managed in get_start_stop_list

The check used was completely wrong and so the startall and stopall
API calls touched HA managed service, which they shouldn't.

Using the vm_is_ha_managed call from the HA stack fixes that.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 years agofix lxc config key in get_start_stop_list sub
Thomas Lamprecht [Mon, 19 Oct 2015 16:02:46 +0000 (18:02 +0200)]
fix lxc config key in get_start_stop_list sub

When adding the new LXC config format we forgot to adapt the
get_start_stop_list and do s/pve.startup/onboot/

This fixes that qemu VMs were started always before LXC CTs,
irregardless of the defined order.

This also let's us simplify the surrounding code and reduce code
reuse.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 years agobump version to 4.0-50
Dietmar Maurer [Thu, 15 Oct 2015 15:42:09 +0000 (17:42 +0200)]
bump version to 4.0-50

8 years agofix bug #756: force macro setting to emtpy string when user erases the content
Dietmar Maurer [Thu, 15 Oct 2015 15:38:56 +0000 (17:38 +0200)]
fix bug #756: force macro setting to emtpy string when user erases the content

8 years agoGUI: add new vtype ConfigId, use it for snapshot names
Dietmar Maurer [Mon, 12 Oct 2015 06:09:34 +0000 (08:09 +0200)]
GUI: add new vtype ConfigId, use it for snapshot names

8 years agos/Realtec/Realtek/
Dietmar Maurer [Fri, 9 Oct 2015 12:37:59 +0000 (14:37 +0200)]
s/Realtec/Realtek/

correct brand name

8 years agobump version to 4.0-49
Dietmar Maurer [Fri, 9 Oct 2015 06:17:16 +0000 (08:17 +0200)]
bump version to 4.0-49

8 years agoIP4_cidr_match: allow short masks like /8
Dietmar Maurer [Fri, 9 Oct 2015 06:16:00 +0000 (08:16 +0200)]
IP4_cidr_match: allow short masks like /8

8 years agobump version to 4.0-48
Dietmar Maurer [Mon, 5 Oct 2015 15:47:48 +0000 (17:47 +0200)]
bump version to 4.0-48

8 years agolxc/dns: ipv6 support
Wolfgang Bumiller [Mon, 5 Oct 2015 12:50:09 +0000 (14:50 +0200)]
lxc/dns: ipv6 support

8 years agobump version to 4.0-47
Dietmar Maurer [Mon, 5 Oct 2015 10:34:35 +0000 (12:34 +0200)]
bump version to 4.0-47

8 years agoDNS ui/api: ipv6 support
Wolfgang Bumiller [Mon, 5 Oct 2015 07:32:47 +0000 (09:32 +0200)]
DNS ui/api: ipv6 support

8 years agobump version to 4.0-46
Dietmar Maurer [Sat, 3 Oct 2015 13:33:09 +0000 (15:33 +0200)]
bump version to 4.0-46

8 years agofix bug #719: vzdump - only call cleanup after prepare
Dietmar Maurer [Sat, 3 Oct 2015 13:30:45 +0000 (15:30 +0200)]
fix bug #719: vzdump - only call cleanup after prepare

8 years agobump version to 4.0-45
Dietmar Maurer [Fri, 2 Oct 2015 09:43:52 +0000 (11:43 +0200)]
bump version to 4.0-45

8 years agosources.list: prepare for final 4.0 release - use pve-enterprise repository
Dietmar Maurer [Fri, 2 Oct 2015 09:41:07 +0000 (11:41 +0200)]
sources.list: prepare for final 4.0 release - use pve-enterprise repository

8 years agoAPI: return correct version (instead of 4.0Beta)
Dietmar Maurer [Fri, 2 Oct 2015 09:37:08 +0000 (11:37 +0200)]
API: return correct version (instead of 4.0Beta)

8 years agocleanup: use new run_cli_handler() method
Dietmar Maurer [Fri, 2 Oct 2015 09:28:01 +0000 (11:28 +0200)]
cleanup: use new run_cli_handler() method

8 years agobump version to 4.0-44
Dietmar Maurer [Thu, 1 Oct 2015 11:04:43 +0000 (13:04 +0200)]
bump version to 4.0-44

8 years agoadd content type selector to LVM storage editor
Dietmar Maurer [Thu, 1 Oct 2015 11:03:13 +0000 (13:03 +0200)]
add content type selector to LVM storage editor

8 years agobump version to 4.0-43
Dietmar Maurer [Tue, 29 Sep 2015 05:17:59 +0000 (07:17 +0200)]
bump version to 4.0-43

8 years agocheck for ext5 dir to avoid missing directory errors
Thomas Lamprecht [Mon, 28 Sep 2015 08:28:03 +0000 (10:28 +0200)]
check for ext5 dir to avoid missing directory errors

As we, for now, default to exclude ext5 from our build it's better
to make an check if its directory exists, and only then allow to
load from it. Else we can get errors on proxy startup, and when
someone passes the ext5 parameter.

Also make a indent/whitespace cleanup.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 years agobump version to 4.0-42
Dietmar Maurer [Sat, 26 Sep 2015 09:15:04 +0000 (11:15 +0200)]
bump version to 4.0-42

8 years agoupdate OS Type descriptions
Dietmar Maurer [Sat, 26 Sep 2015 09:13:54 +0000 (11:13 +0200)]
update OS Type descriptions

8 years agoCephTools: improve abs_path error handling
Wolfgang Bumiller [Fri, 25 Sep 2015 07:41:40 +0000 (09:41 +0200)]
CephTools: improve abs_path error handling

verify_blockdev_path didn't check the result of abs_path
causing commands like `pveceph createosd bad/path` to error
with a meaningless "Use of uninitialized value" message.

8 years agobump version to 4.0-41
Dietmar Maurer [Fri, 25 Sep 2015 05:19:30 +0000 (07:19 +0200)]
bump version to 4.0-41

8 years agodo not install extJS 5 framework by default
Dietmar Maurer [Fri, 25 Sep 2015 05:17:39 +0000 (07:17 +0200)]
do not install extJS 5 framework by default

We don't want to have development code in final 4.0 release.

8 years agoNetworkEdit : add support for vlan interfaces.
Alexandre Derumier [Tue, 22 Sep 2015 06:26:57 +0000 (08:26 +0200)]
NetworkEdit : add support for vlan interfaces.

Edit only for now, create will come soon in another patch

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
8 years agobump version to 4.0-40
Dietmar Maurer [Thu, 24 Sep 2015 05:03:08 +0000 (07:03 +0200)]
bump version to 4.0-40

8 years agos/pveBackButton/pveReloadButton/
Dietmar Maurer [Thu, 24 Sep 2015 04:54:57 +0000 (06:54 +0200)]
s/pveBackButton/pveReloadButton/

8 years agobetter formating and UI of task viewer and task list
Thomas Lamprecht [Wed, 23 Sep 2015 15:54:46 +0000 (17:54 +0200)]
better formating and UI of task viewer and task list

[TaskList]:
* format task date on the same node as the title. If space isn't
  there, the date goes on it's own line.
* Truncate output of task status to a maximum of 160 characters to
  fix formating, also the list should only give an overview.
* set list flex to 1, this fixes height and scrolling issues
* Put affected node and status on a own line.

[TaskViewer]
* Only show task status, the exit status is in the log below,
  also some long statuses break this page completely.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 years agoformat cpu load value better
Thomas Lamprecht [Wed, 23 Sep 2015 15:54:45 +0000 (17:54 +0200)]
format cpu load value better

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 years agouse new VMSummaryBase class for lxc and qemu summary
Thomas Lamprecht [Wed, 23 Sep 2015 15:54:44 +0000 (17:54 +0200)]
use new VMSummaryBase class for lxc and qemu summary

also the keys to display from the lxc config where updated as some
from OpenVZ times where used.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 years agoImplement VMSummaryBase class
Thomas Lamprecht [Wed, 23 Sep 2015 15:54:43 +0000 (17:54 +0200)]
Implement VMSummaryBase class

As the lxc and qemu summary pages share almost all the code we
implement a base class which provides the shared functionality.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 years agouse new PVEBar instead of TitleBar
Thomas Lamprecht [Wed, 23 Sep 2015 15:54:42 +0000 (17:54 +0200)]
use new PVEBar instead of TitleBar

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>