redhat: remove obsolete %clean section

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: remove obsolete BuildRoot tag

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: use one BuildRequires per line

Makes for easier diffing

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: remove BuildRequires for patch

Nothing seems to need it

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: don't Requires initscript on systemd based distros

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: remove superfluous Requires for json-c

json-c-devel is already a BuildRequires, and rpm will add the Requires
itself.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: indent some stuff in spec file

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: replace hardcoded directory

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: use 'service' command to restart frr

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: replace /etc/ with _sysconfdir where we can

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: stop overriding _localstatedir

It is defined by rpm and points at /var

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: remove some defaults from configure options

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: stop overriding _sysconfdir

This macro is defined by rpm and points at /etc.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: remove enable-poll option from specfile

It was removed from configure.ac in 16764760

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

Merge pull request #2485 from pacovn/cppcheck_ldpd_redundant_condition

ldpd: redundant condition (cppcheck)

Merge pull request #2461 from pacovn/Coverity_1399380_Untrusted_value_as_argument

bgpd: Untrusted argument (Coverity 1399380)

Merge pull request #2495 from pacovn/fixme_all_digit

bgpd, lib, ospfd, zebra: all_digit moved to frrstr

Merge pull request #2496 from pacovn/fixme_group1

isisd, zebra: FIXME fixes (grouped)

Merge pull request #2499 from donaldsharp/routemap_kisses

Some route-map prep

Merge pull request #2500 from msablic/pim_doc2

doc: added parameters to two PIM commands

Merge pull request #2446 from pacovn/Coverity_1452454_1452455_1452456_Out-of-bounds_access

ospfd: OoB access (Cov 1452454 1452455 1452456)

doc: added parameters to two PIM commands

ip igmp join and mtrace have parameters which were missing from
the command spec.

Signed-off-by: Mladen Sablic <mladen.sablic@gmail.com>

bgpd, lib, zebra: Remove unnecessary return

The route_map_walk_update_list callback function
never uses the return code, so just remove it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Don't expose a function that is never used

route_map_clear_updated is only used by routemap.c,
don't expose it too be used by the outside world.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Add initial framework to keep track of changed route-maps

Add some basic code for zebra to start to keep track
of route-maps that have changed.  At this point we
are not doing anything.  As we fix code to handle
route-maps better, code will be shifted around.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

pimd: Remove unused code

pim does not even use route-maps, remove the
unneded code.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd, lib, pimd: Remove unused variable.

route_map_mark_updated has a `int del_later` variable
that is passed in but never used.  Just remove it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

isisd, zebra: FIXME fixes

Signed-off-by: F. Aragon <paco@voltanet.io>

bgpd, lib, ospfd, zebra: all_digit moved to frrstr

This solves a pending FIXME

Signed-off-by: F. Aragon <paco@voltanet.io>

Merge pull request #2459 from pacovn/Coverity_1469898_Uninitialized_scalar_variable

lib: uninitialized variable (Coverity 1469898)

Merge pull request #2373 from rubenk/specfile-cleanups

Red Hat spec file cleanup

bgpd: Untrusted argument (Coverity 1399380)

Signed-off-by: F. Aragon <paco@voltanet.io>

Merge pull request #2445 from ppmathis/feature/bgp-pg-overrides

bgpd: Improve peer-group override implementation

Merge pull request #2450 from ppmathis/bugfix/bgp-filtered-routes

bgpd: Fix crash when showing filtered routes

Merge pull request #2465 from qlyoung/fix-build-am-cppflags-warning

tests: fixup minor autotools nit

Merge pull request #2468 from qlyoung/docuser

doc: update workflow.rst

Merge pull request #2470 from chiragshah6/mdev

zebra: Hide default vrf instance of l3vni cmd

Merge pull request #2474 from donaldsharp/vty_thread_cancel_writes

Add 'show thread poll'

Merge pull request #2478 from pacovn/Coverity_1408766_Dereference_after_null_check

bgpd: null check (Coverity 1408766)

Merge pull request #2479 from dslicenc/zebra-vrf-statics

zebra: re-install static routes needed vrf when the vrf intf comes up

Merge pull request #2481 from pacovn/security_vpn_null_check

bgpd: vpn null check

Merge pull request #2483 from pacovn/clang_scan_bgpd_updgrp_deref

bgpd: null check (Clang scan-build)

Merge pull request #2491 from pacovn/cppcheck_no_effect

eigrpd, isisd, lib, ospfd: no effect (cppcheck)

Merge pull request #2492 from pacovn/cppcheck_security1

eigrpd, lib, tests, vtysh: security (cppcheck)

eigrpd, lib, tests, vtysh: security (cppcheck)

Signed-off-by: F. Aragon <paco@voltanet.io>

eigrpd, isisd, lib, ospfd: no effect (cppcheck)

Assignment of function parameter has no effect outside the function.

Signed-off-by: F. Aragon <paco@voltanet.io>

redhat: fix else cases in spec file

As pointed out during review, disable the options when the macros are
false.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: spec file: specify file only once

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: spec file: no need for custom attr for service file

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: add missing dependencies on chkconfig in spec file

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: remove a few superfluous Requires from spec file

rpm adds these automatically

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: remove a few superfluous BuildRequires from spec file

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: depend on info package instead of binary in specfile

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: install-info is not called from %pre in spec file

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: remove wrong comment from spec file

systemd support needs watchfrr

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: spec file: all supported Fedora versions use systemd

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: use default permissions for logrotate file in spec file

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: spec file: we ship only one logrotate file

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: be consistent in adding ./configure options in spec file

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: use Github for SOURCE0 in spec file

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: Use https for URL in spec file

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: remove trailing whitespace from spec file

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

redhat: fix tabs vs spaces in spec file

rpmlint reports:
redhat/frr.spec:282: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 282)

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>

Merge pull request #2476 from pacovn/Coverity_1433544_Explicit_null_dereferenced

bgpd: null check (Coverity 1433544, 1433543, 1433542)

Merge pull request #2482 from pacovn/clang_scan_bgpd_bgp_rpki_deref

bgpd: null check (Clang scan-build)

bgpd: null check (Clang scan-build)

Signed-off-by: F. Aragon <paco@voltanet.io>

Merge pull request #2484 from pacovn/cppcheck_unused_vars

eigrpd, lib: unused vars (cppcheck)

Merge pull request #2486 from pacovn/cppcheck_fmt_validation

babeld, lib, ospfd, tests: fmt fixes (cppcheck)

Merge pull request #2489 from pacovn/cppcheck_reduntant_pointer_op

ldpd: redundant pointer operation (cppcheck)

Merge pull request #2488 from pacovn/cppcheck_nhrpd_limit_check

nhrpd: array limit check (cppcheck)

Merge pull request #2487 from pacovn/cppcheck_redundant_memset

ospfd, pimd: redundant memset (cppcheck)

Merge pull request #2490 from pacovn/cppcheck_unsigned_check

babeld, eigrpd, ospfd: unsigned negative check (cppcheck, grouped)

Merge pull request #2417 from pacovn/Coverity_1399373_Structurally_dead_code

bgpd: dead code (Coverity 1399373)

ldpd: redundant condition (cppcheck)

Signed-off-by: F. Aragon <paco@voltanet.io>

babeld, eigrpd, ospfd: unsigned negative check

After Cppcheck 1.72 feedback

Signed-off-by: F. Aragon <paco@voltanet.io>

ldpd: redundant pointer operation (cppcheck)

Signed-off-by: F. Aragon <paco@voltanet.io>

nhrpd: array limit check (cppcheck)

Signed-off-by: F. Aragon <paco@voltanet.io>

ospfd, pimd: redundant memset (cppcheck)

Signed-off-by: F. Aragon <paco@voltanet.io>

Merge pull request #2457 from pacovn/Coverity_1465491_Untrusted_value_as_argument

pimd: Untrusted val as argument (Coverity 1465491)

Merge pull request #2464 from pacovn/Coverity_1399309_Out-of-bounds_access

isisd: out-of-bounds access (Coverity 1399309)

babeld, lib, ospfd, tests: fmt fixes (cppcheck)

Signed-off-by: F. Aragon <paco@voltanet.io>

eigrpd, lib, vtysh: unused vars (cppcheck)

Signed-off-by: F. Aragon <paco@voltanet.io>

bgpd: null check (Clang scan-build)

Signed-off-by: F. Aragon <paco@voltanet.io>

bgpd: null chk (Coverity 1433544 1433543 1433542)

Signed-off-by: F. Aragon <paco@voltanet.io>

bgpd: vpn null check

Can be reproduced with following vtysh sequence (an intentionaly wrong
sequence):

['configure terminal\n router bgp 255 vrf l3vrf-6\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\nbgp router-id 10.255.255.1\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nlabel vpn export 45000\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrd vpn export 255:5\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute isis\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute ospf\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute connected\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nimport vpn\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nexport vpn\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrt vpn import 255:1\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrt vpn export 255:1\n'
]

Signed-off-by: F. Aragon <paco@voltanet.io>

Merge pull request #2466 from pacovn/clang_scan_bgpd_dereference1

bgpd: null check (Clang scan-build)

Merge pull request #2456 from pacovn/Coverity_1399306_Out-of-bounds_access

bgpd: out-of-bounds access (Coverity 1399306)

zebra: re-install static routes needed vrf when the vrf intf comes up

Problem reported that if the vrf device is taken down and then brought
back up, any static route referencing that vrf device was not
re-installed.  This fix runs back thru the static routes that
reference the vrf device coming up and re-install them.

Signed-off-by: Don Slice <dslice@cumulusnetworks.com>

bgpd: null check (Coverity 1408766)

Signed-off-by: F. Aragon <paco@voltanet.io>

lib: A small optimization for the hash iterate and walk functions

When we are iterating through the hash, keep count of how many
we've called and if we have finished calling the hash->size
iterator times, then short-circuit and stop looping over
the entire array.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib, vtysh: Add 'show thread poll' command

Add a 'show thread poll' command that displays the
poll information and fd's setup.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #2467 from pacovn/Coverity_1399274_Dereference_after_null_check

bgpd: null check (Coverity 1399274)

bgpd: fix default RD value in running-cfg

When bgp vrf is configured with non-default
RD value, config flag is set.
Upon removing non-default RD value the flag was not reset,
thus displayed default RD value in running-config.

router bgp 5550 vrf vrf1
 rd 45.0.2.2:5

Unset the RD configuration flag under bgp_vrf instance.

Ticket:CM-20206

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

zebra: Hide default vrf instance of l3vni cmd

Hide following l3vni config from DEFAULT_VRF instance
until it is fully supported.

TORS1(config)# vni 2222456 prefix-routes-only

Ticket:CM-20572

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

doc: update workflow.rst

* Rewrap lines to 80 characters
* Update some portions to reflect current practices
* Clean up some formatting (indent, markup, etc)
* Reorganize sections on patch submission
* Remove link to nonexistent github wiki page

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: ignore user CFLAGS when building Clippy

Unfortunately user CFLAGS causes #define conflicts with #defines in
Python development headers, which causes build failures under certain
platforms when using -Werror.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

bgpd: null check (Coverity 1399274)

Signed-off-by: F. Aragon <paco@voltanet.io>

bgpd: null check (Clang scan-build)

Signed-off-by: F. Aragon <paco@voltanet.io>

tests: fixup minor autotools nit

Makes super strict builds fail due to a warning.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: uninitialized variable (Coverity 1469898)

Signed-off-by: F. Aragon <paco@voltanet.io>