[libnozzle] add nozzle_get_handle_by_name tests

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add nozzle_get_mac / nozzle_set_mac / nozzle_reset_mac tests

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add nozzle_get_mtu / nozzle_set_mtu / nozzle_reset_mtu tests

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] move multi nozzle device test to api_nozzle_open

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] clean up code in set_up test

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] improve set_down test

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add api_nozzle_set_(up|down) tests

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] drop unnecessary indirection to call set_down

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] drop redundant check

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add api_nozzle_close_test

also, share more code in test-common, fix another BSD build issue

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] fix test suite build on BSD

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add api_nozzle_open test

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] prepare Makefile.am to explode with API tests

also fix nozzle_test for using global compiler flags

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] fix API check paths

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add per-API call test coverage check

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] re-instate error checking in nozzle_get_ips

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] add comment about BSD ip_add status

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] cleanup nozzle_get_ips public API

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] fix whitespaces

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[global] Update copyright across

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] Update copyright

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] fix build on BSD

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] remove error_string requirement from many API calls and mark them as final

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libtap] move nozzle_run_updown to completed section

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[tests] properly check symbols on PPC64

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[tests] remove debugging sleep()

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] enable libnl3 < 3.3 build workaround

fixes build on opensuse-42

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] Use libnl3.0 for ip address management on Linux

BSD will follow next using internal ioctls and drop usage of forking a shell

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] whitespace cleanup

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] expand buffers to deal with strncpy and -Werror=stringop-truncatio

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] drop duplicated code

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] enable libnozzle build by default

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move man pages to top level dir

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] fix man page generation

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] propagate errors all the way

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] fix build on BSD

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] nozzle_open and nozzle_close should be stable now

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move set up and down to the stable API section

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] decouple running pre-up.d/up.d/down.d/post-down.d from interface status (part 4)

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] decouple running pre-up.d/up.d/down.d/post-down.d from interface status (part 3)

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] decouple running pre-up.d/up.d/down.d/post-down.d from interface status (part 2)

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] decouple running pre-up.d/up.d/down.d/post-down.d from interface status (part 1)

provide the facility to do it via nozzle_run_updown but delegate the task to
the application.

This has the benefit of much better fine grained control over errors during those
code paths.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move find_ip to internals

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move ipv4 broadcast to internals

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup mac address functions

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move code around to reflect public API and internal functions

cleanup _get_mtu in the process

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] move code around to reflect completion and drop copy of code from internals.c

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] rename _check to is_valid_nozzle, make it more useful and fixup error code checking

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] be more explicit on function naming (part 2)

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] be more explicit on function naming

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] start cleaning internal function names

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] split code around to separate libnozzle and testsuite

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[build] split tests, man pages and build dirs

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] rename lib_mutex to config_mutex

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[build] fix build on BSD

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[cleanup] document nozzle_iface struct, drop unnecessary ifr struct and cleanup names

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[cleanup] rename ip_addr to ipaddr

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[cleanup] rename sockfd to ioctlfd

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[cleanup] rename struct _ip to struct nozzle_ip and cleanup related defines

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] rename _config to nozzle_lib_config

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[cleanup] start splitting the code across multiple files

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_get_fd

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_get_name_by_handle

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_get_handle_by_name

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_(re)set_mac

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_get_mac

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

Tidy some English

[nozzle] cleanup and document nozzle_set_mtu and nozzle_reset_mtu

couldn't split those 2 because they are stricly related

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_get_mtu

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] fix test on BSD

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_get_ips (part 1)

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_del_ip

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_add_ip

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] re-order functions in order of importance

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_set_down

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup and document nozzle_set_up

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] start to cleanup nozzle_close to be more informative and effective

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] cleanup nozzle_open coding style and return codes

also update the header file for Doxygen man pages

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] rename last tap bits to nozzle

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] rename API from tap_ to nozzle_

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] fix pkg-config to point to nozzle

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] rename struct _iface to nozzle_iface (looks better on public headers)

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] rename tap_t to nozzle_t

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] include net/if.h to define IFNAMSIZ instead of redefine

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[nozzle] add Doxygen header

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libnozzle] rename libtap to libnozzle (part 1)

Our fearless Debian maintainer wferi made us aware that TAP is an overloaded
term already and it would be very confusing to add yet another one.

nozzle is a good pick from http://www.thesaurus.com/browse/tap

I am sure lib*cock* would have cause havoc :-)

This commit only rename files and allow builds. The API needs to be renamed too,
but that will come over time with major code cleanup as documented here:
https://trello.com/c/pyEKd4UH/396-libnozzle-make-it-production-ga-ready

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libtap] BSD: switch to ioctl to destroy tap devices

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libtap] define IFNAMSIZ for applications that don't need/want to include net/if.h

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libtap] update README for BSD

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libtap] port to freebsd and fix a bunch of small bugs

- tap_open: do mutex lock only after malloc to avoid deadlock
- fix test suite to increase randomness when testing named tap devices
- remove hardcoded paths to /bin/true /bin/false and /bin/grep

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libtap] tests: add better IPv6 private address space randomization

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[libtap] tests: allow random localhost IPs for testing

- avoids clashing with machine routing
- allows parallel testing

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

UDP: Cope with EPERM returned from sendmsg/sendto

IPtables can cause -EPERM to be returned from socket sends, so
we need to be able to handle it without going into a spin.

SCTP seems to be unaffected.

Signed-off-by: Christine Caulfield <ccaulfie@redhat.com>

[misc] fix a few typos/stylistics

Signed-off-by: Jan Pokorný <jpokorny@redhat.com>

[tests] update error message in api_knet_{addrtostr,strtoaddr}.c

Signed-off-by: Chen Jingpiao <jchen@suse.com>

[tests] fix check condition in api_knet_{addrtostr,strtoaddr}.c

Signed-off-by: Chen Jingpiao <jchen@suse.com>

clear the errno in each exported API when the call success

Signed-off-by: Chen Jingpiao <jchen@suse.com>

[openssl] fix return type for pthread_self

spotted on freebsd-devel

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

[tx] fix tx_uncompressed_packets stats collect in _parse_recv_from_sock

Signed-off-by: Chen Jingpiao <jchen@suse.com>

[rx] fix incorrect packet length in _parse_recv_from_links

Signed-off-by: Chen Jingpiao <jchen@suse.com>