]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/log
mirror_ubuntu-artful-kernel.git
9 years agogreybus: es1.c: wait until the last possible minute to start the svc messages
Greg Kroah-Hartman [Thu, 22 Jan 2015 13:19:25 +0000 (21:19 +0800)]
greybus: es1.c: wait until the last possible minute to start the svc messages

When initializing the USB device, we were starting up the svc message
queue before the cport urbs were allocated.  This might not be an issue
for "slower" machines, but not having any allocated urbs for a cport
might be an issue if we were to handle svc messages.

So wait until everything is properly initialized and allocated before
starting the svc urb.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: ap.c: our workqueue should be ordered
Greg Kroah-Hartman [Thu, 22 Jan 2015 12:33:41 +0000 (20:33 +0800)]
greybus: ap.c: our workqueue should be ordered

SVC messages come in in an "order", so don't mess them up by processing
them out of order.  Fix this by making our work queue ordered, which
should keep everything in line.

Reported-by: Perry Hung <perry@leaflabs.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: build: android: add all greybus modules to the build
Michael Scott [Fri, 23 Jan 2015 00:22:47 +0000 (16:22 -0800)]
greybus: build: android: add all greybus modules to the build

We now have several modules generated by the greybus build.
Let's add any *.ko files we find to the buid.

Signed-off-by: Michael Scott <michael.scott@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: build: android: replace hard-coded build destination with variable
Michael Scott [Fri, 23 Jan 2015 00:22:20 +0000 (16:22 -0800)]
greybus: build: android: replace hard-coded build destination with variable

Make sure destination for greybus modules is consistent and easier to maintain

Signed-off-by: Michael Scott <michael.scott@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: Revert "protocol: dedup protocol find code"
Greg Kroah-Hartman [Fri, 23 Jan 2015 02:06:24 +0000 (10:06 +0800)]
greybus: Revert "protocol: dedup protocol find code"

This reverts commit 241b5fefc54eae95239b0f7dc4e2b0db49457729 as it's
wrong, we want to insert into the correct place in the list.

Reported-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: Revert "protocol.c: fix a kernel panic caused by __gb_protocol_register"
Greg Kroah-Hartman [Fri, 23 Jan 2015 02:05:58 +0000 (10:05 +0800)]
greybus: Revert "protocol.c: fix a kernel panic caused by __gb_protocol_register"

This reverts commit 57131bf309d34568dd3b8f8e9da7a7ba25e9495e, it isn't
going to be needed as the patch this fixes will be reverted.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: i2c: fix name conflict between function and struct: gb_i2c_transfer_request
Viresh Kumar [Thu, 22 Jan 2015 06:40:38 +0000 (12:10 +0530)]
greybus: i2c: fix name conflict between function and struct: gb_i2c_transfer_request

'gb_i2c_transfer_request' is the name given to a function and a struct. Though
we don't get any compilation errors/warnings about it, but the names should be
unique.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: i2c: fix name conflict between function and struct: gb_i2c_transfer_response
Viresh Kumar [Thu, 22 Jan 2015 07:12:39 +0000 (12:42 +0530)]
greybus: i2c: fix name conflict between function and struct: gb_i2c_transfer_response

'gb_i2c_transfer_response' is the name given to a function and a struct. Though
we don't get any compilation errors/warnings about it, but the names should be
unique.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: protocol.c: fix a kernel panic caused by __gb_protocol_register
Alexandre Bailon [Thu, 22 Jan 2015 07:23:37 +0000 (15:23 +0800)]
greybus: protocol.c: fix a kernel panic caused by __gb_protocol_register

__gb_protocol_register check if the protocol is not already registred,
and then register it. It register in existing->lists but at this point,
existing is always NULL (we exist just before if not).
Use gb_protocols instead.

Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: remove unused version-response structs
Viresh Kumar [Wed, 21 Jan 2015 12:42:37 +0000 (18:12 +0530)]
greybus: remove unused version-response structs

These aren't used anymore and so can be removed.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: create get_version() routines with the help of a macro
Viresh Kumar [Wed, 21 Jan 2015 12:42:36 +0000 (18:12 +0530)]
greybus: create get_version() routines with the help of a macro

This gets rid of lots of duplication of code.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: uart: s/REQ/TYPE
Viresh Kumar [Wed, 21 Jan 2015 12:42:35 +0000 (18:12 +0530)]
greybus: uart: s/REQ/TYPE

Request type for all other protocols is defined like: GB_<protocol>_TYPE_<operation>,
but for UART is like: GB_<protocol>_REQ_<operation>.

Replace REQ with TYPE to make it consistent. It will also be useful in a later
patch that creates get_version() routines with the help of a macro.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: Remove "gb-" prefix from .c files
Viresh Kumar [Wed, 21 Jan 2015 10:40:41 +0000 (16:10 +0530)]
greybus: Remove "gb-" prefix from .c files

Some files are still prefixed with "gb-" with the reasoning that the modules
would be named so, i.e.  gb-*.ko. But this can be done by playing a bit in
Makefile instead and keep uniform naming of .c files.

Lets try it.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: Remove "-gb" suffix from .c files
Viresh Kumar [Wed, 21 Jan 2015 10:40:40 +0000 (16:10 +0530)]
greybus: Remove "-gb" suffix from .c files

Some files are prefixed with "gb-" and some are suffixed with "-gb". The
rationale behind the first one is that the modules would be named so, i.e.
gb-*.ko. But there is no reason to keep the "-gb" suffix in the second case.

Remove the unnecessary suffix.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: es2: add ES2 Greybus Host driver
Greg Kroah-Hartman [Wed, 21 Jan 2015 02:24:15 +0000 (10:24 +0800)]
greybus: es2: add ES2 Greybus Host driver

This is just a copy of ES1 for now, things will start to diverge soon.
Any common functionality will be factored out over time.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: es1: no need to assign a variable we return directly
Greg Kroah-Hartman [Wed, 21 Jan 2015 01:47:21 +0000 (09:47 +0800)]
greybus: es1: no need to assign a variable we return directly

In next_free_urb(), just return usb_alloc_urb(), don't waste the time
assigning it to a local variable that we then return.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: protocol: dedup protocol find code
Rui Miguel Silva [Tue, 20 Jan 2015 17:26:18 +0000 (17:26 +0000)]
greybus: protocol: dedup protocol find code

in protocol register replace the protocol find code with the call to the already
existing function.

Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: es1: release urb on error path
Rui Miguel Silva [Tue, 20 Jan 2015 16:38:44 +0000 (16:38 +0000)]
greybus: es1: release urb on error path

if error is return when submiting the urb, we need to make sure to release the
urb from the pool, or from the dinamicly allocated. As in it, factor out the free
code and create the free_urb function.

Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: es1: remove useless statement
Rui Miguel Silva [Tue, 20 Jan 2015 16:31:45 +0000 (16:31 +0000)]
greybus: es1: remove useless statement

just return the result of usb_alloc_urb up, no need to rededunt check for NULL

Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: gb_operation: drop operation refcount on cancel
Perry Hung [Wed, 14 Jan 2015 21:19:27 +0000 (16:19 -0500)]
greybus: gb_operation: drop operation refcount on cancel

An extra reference is taken out on an operation in
gb_operation_request_send(). If the response never arrives, we need to
put back the reference.

Signed-off-by: Perry Hung <perry@leaflabs.com>
Tested-by: Mitchell Tasman <tasman@leaflabs.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: gb_operation: replace timeout workqueue
Perry Hung [Wed, 14 Jan 2015 21:19:26 +0000 (16:19 -0500)]
greybus: gb_operation: replace timeout workqueue

If an operation is issued and the response never comes back,
gb_operation_timeout() cancels the operation but never wakes up the
waiter in gb_operation_request_send().

This patch removes the timeout workqueue and changes the request wait to
wait_for_completion_interruptible_timeout(), with timeout set to
OPERATION_TIMEOUT_DEFAULT.

Signed-off-by: Perry Hung <perry@leaflabs.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: gpio-gb: remove checks for negative offset variable
Bill Pemberton [Fri, 16 Jan 2015 18:57:32 +0000 (13:57 -0500)]
greybus: gpio-gb: remove checks for negative offset variable

offset is defined as unsigned so there is no point checking for
negative values of offset.

Signed-off-by: Bill Pemberton <wfp5p@worldbroken.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: Add FIXME warnings for possible NULL dereferences
Bill Pemberton [Fri, 16 Jan 2015 02:18:27 +0000 (21:18 -0500)]
greybus: Add FIXME warnings for possible NULL dereferences

Signed-off-by: Bill Pemberton <wfp5p@worldbroken.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: gb-vibrator: remove useless if in timeout_store()
Bill Pemberton [Fri, 16 Jan 2015 02:18:26 +0000 (21:18 -0500)]
greybus: gb-vibrator: remove useless if in timeout_store()

val is an unsigned long so there is no point in checking if it is less
than zero.

Signed-off-by: Bill Pemberton <wfp5p@worldbroken.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: Move the es1_ap_desc.c file to Documentation directory
Greg Kroah-Hartman [Thu, 15 Jan 2015 01:08:03 +0000 (17:08 -0800)]
greybus: Move the es1_ap_desc.c file to Documentation directory

This .c file isn't needed by the kernel driver, it's there for firmware
developers only, so just move it into the Documentation directory to
reduce confusion.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: rename es1-ap-usb.ko to gb-es1.ko
Greg Kroah-Hartman [Thu, 15 Jan 2015 01:08:02 +0000 (17:08 -0800)]
greybus: rename es1-ap-usb.ko to gb-es1.ko

Use the "gb-" prefix for the ES1 Host controller driver.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: rename battery-gb.c to gb-battery.c
Greg Kroah-Hartman [Thu, 15 Jan 2015 01:08:01 +0000 (17:08 -0800)]
greybus: rename battery-gb.c to gb-battery.c

Use the "gb" prefix for module names, not a suffix.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: rename vibrator-gb.ko to gb-vibrator.ko
Greg Kroah-Hartman [Thu, 15 Jan 2015 01:08:00 +0000 (17:08 -0800)]
greybus: rename vibrator-gb.ko to gb-vibrator.ko

Use the "gb" prefix for module names, not a suffix.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: rename gpbridge.ko to gb-phy.ko
Greg Kroah-Hartman [Thu, 15 Jan 2015 01:07:59 +0000 (17:07 -0800)]
greybus: rename gpbridge.ko to gb-phy.ko

This module provides the Bridged PHY protocols, so name the thing
properly.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: Makefile: provide install target
Greg Kroah-Hartman [Wed, 14 Jan 2015 22:55:24 +0000 (14:55 -0800)]
greybus: Makefile: provide install target

Provide an install Makefile target for those that want to install the
kernel modules.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
--
v3: resend to list, somehow this thread got taken private and v2 never
    made it there.

v2: add -a option to depmod, thanks to Mitchell

9 years agogreybus: i2c-gb: fix bad message size in gb_i2c
Alexandre Bailon [Wed, 14 Jan 2015 09:23:49 +0000 (10:23 +0100)]
greybus: i2c-gb: fix bad message size in gb_i2c

The data_in_size variable was set to 1 for the status byte.
But now, the status byte has move to header. Then, the status byte
is "allocated" twice and cause bad message size error.

Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: sysfs: put a \n at the end of all sysfs files
Greg Kroah-Hartman [Wed, 24 Dec 2014 00:09:26 +0000 (16:09 -0800)]
greybus: sysfs: put a \n at the end of all sysfs files

Right now some sysfs attributes have \n and some do not, so fix that and
put \n at the end of all of them to make it easier to parse things
properly in userspace.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: protocol: fix oops when no protocol is assigned
Greg Kroah-Hartman [Wed, 24 Dec 2014 21:12:10 +0000 (13:12 -0800)]
greybus: protocol: fix oops when no protocol is assigned

When removing a connection with no protocol assigned to it, the kernel
oopses as we always thought protocols were always there.

Fix that problem, oopses are bad.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: protocol: name protocols.
Greg Kroah-Hartman [Wed, 24 Dec 2014 21:01:45 +0000 (13:01 -0800)]
greybus: protocol: name protocols.

We want to be able to "blame" a protocol for things at times, so give
them a name we can refer to them by.  Announce when they are added or
removed from the system so we have a chance to know what is going on
in the kernel logs.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: module: get rid of global list of modules
Greg Kroah-Hartman [Wed, 24 Dec 2014 21:01:46 +0000 (13:01 -0800)]
greybus: module: get rid of global list of modules

Use the list that the driver core keeps of our structure, no need to
duplicate it with a local list as well.  This gets rid of a static lock
too, always a nice thing to do.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: i2c-gb: move i2c protocol into the gpbridge driver
Greg Kroah-Hartman [Wed, 24 Dec 2014 21:01:44 +0000 (13:01 -0800)]
greybus: i2c-gb: move i2c protocol into the gpbridge driver

The i2c protocol belongs in the gpbridge driver, so move it
there.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: gpb: Create a "GP Bridge" kernel module
Greg Kroah-Hartman [Wed, 24 Dec 2014 21:01:43 +0000 (13:01 -0800)]
greybus: gpb: Create a "GP Bridge" kernel module

This bundles together the existing GP Bridged PHY protocols that were
part of the Greybus core: USB, UART, SDIO, PWM, and GPIO.  This is now a
stand-alone kernel module.  More logic will be moving here in the future
to handle bridged devices.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: battery-gb: move the battery protocol out to a stand-alone module
Greg Kroah-Hartman [Wed, 24 Dec 2014 21:01:42 +0000 (13:01 -0800)]
greybus: battery-gb: move the battery protocol out to a stand-alone module

This moves the battery class protocol to be a stand-alone kernel module.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: vibrator-gb: move vibrator protocol to a stand-alone module.
Greg Kroah-Hartman [Wed, 24 Dec 2014 21:01:41 +0000 (13:01 -0800)]
greybus: vibrator-gb: move vibrator protocol to a stand-alone module.

We can't use the gb_protocol_driver() macro here as we need to do some
init and exit logic when loading and removing, so "open code" the module
init and exit functions.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: protocol: add a module owner to a protocol
Greg Kroah-Hartman [Wed, 24 Dec 2014 21:01:40 +0000 (13:01 -0800)]
greybus: protocol: add a module owner to a protocol

Now that protocols can be in a module, we need to reference count them
to lock them into memory so they can't be removed while in use.  So add
a module owner structure, and have it automatically be assigned when
registering the protocol.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: bundle: create GB_DEVICE_ID_BAD
Greg Kroah-Hartman [Wed, 24 Dec 2014 21:01:39 +0000 (13:01 -0800)]
greybus: bundle: create GB_DEVICE_ID_BAD

Use a "name" for when we don't have a valid device id yet, instead of a
magic value of 0xff.

Reported-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: i2c-gb: split out into a stand-alone kernel module.
Greg Kroah-Hartman [Tue, 23 Dec 2014 23:16:54 +0000 (15:16 -0800)]
greybus: i2c-gb: split out into a stand-alone kernel module.

This splits the i2c-gb protocol into a stand-alone kernel module.

It's not going to stay in this fashion for long, this was done to test
the "can a protcol be loaded later" logic.  Future refactoring is going
to move the gpbridge protocols to a separate kernel module, where this
protocol is going to live.

But for now, split it out, it is good to test with, and shows a bug in
gbsim at the moment.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: protocol: split binding of prototcols to connections out of init
Greg Kroah-Hartman [Tue, 23 Dec 2014 23:16:53 +0000 (15:16 -0800)]
greybus: protocol: split binding of prototcols to connections out of init

When adding a new protocol to the system, walk all bundles and try to
hook up any connections that do not have a protocol already.  This sets
the stage to allow for protocols to be loaded at any time, not just
before the device is seen in the system.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: export needed symbols for protocols
Greg Kroah-Hartman [Tue, 23 Dec 2014 23:16:52 +0000 (15:16 -0800)]
greybus: export needed symbols for protocols

Protocol handlers need some greybus symbols, so export them so that they
can be built outside of the greybus core.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: protocol: switch gb_protocol_register() to return an int
Greg Kroah-Hartman [Tue, 23 Dec 2014 23:16:51 +0000 (15:16 -0800)]
greybus: protocol: switch gb_protocol_register() to return an int

We will want to return this value as a return value for module_init()
and bool does not play well with module_init().  So make it a "real"
error value and return int and fix up all callers of the function.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: interface: remove global manifest_descs list
Greg Kroah-Hartman [Tue, 23 Dec 2014 23:16:50 +0000 (15:16 -0800)]
greybus: interface: remove global manifest_descs list

The list was global and had no locking.  It's not like we were ever
parsing more than one manifest at the same time right now, but we might
in the future.  And we really want this to be local to the interface
itself, for future work redoing how to bind protocols to bundles, so
move the list to the interface structure.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: add module support
Greg Kroah-Hartman [Sun, 21 Dec 2014 22:10:26 +0000 (14:10 -0800)]
greybus: add module support

Modules in the greybus system sit above the interface, so insert them
early in the sysfs tree.  We dynamically create them when we have an
interface that references a module, as we don't get a "module create"
message directly.  They also dynamically go away when the last interface
associated with a module is removed.

Naming scheme for modules/interfaces/bundles/connections is bumped up by
one ':', and now looks like the following:

/sys/bus/greybus $ tree
.
├── devices
│   â”œâ”€â”€ 7 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7
│   â”œâ”€â”€ 7:7 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7
│   â”œâ”€â”€ 7:7:0 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7/7:7:0
│   â””── 7:7:0:1 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7/7:7:0/7:7:0:1
├── drivers
├── drivers_autoprobe
├── drivers_probe
└── uevent

6 directories, 3 files
/sys/bus/greybus $ grep . devices/*/uevent
devices/7/uevent:DEVTYPE=greybus_module
devices/7:7/uevent:DEVTYPE=greybus_interface
devices/7:7:0/uevent:DEVTYPE=greybus_bundle
devices/7:7:0:1/uevent:DEVTYPE=greybus_connection

We still have some "confusion" about interface ids and module ids, which
will be cleaned up later when the svc control protocol changes die down,
right now we just name a module after the interface as we don't have any
modules that have multiple interfaces in our systems.

This has been tested with gbsim.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: interface: rename gb_modules_lock -> gb_interfaces_lock
Greg Kroah-Hartman [Fri, 19 Dec 2014 22:56:37 +0000 (14:56 -0800)]
greybus: interface: rename gb_modules_lock -> gb_interfaces_lock

It's a local interface lock, not a modules lock, so rename it.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: greybus_host_device: rename modules -> interfaces
Greg Kroah-Hartman [Fri, 19 Dec 2014 22:56:36 +0000 (14:56 -0800)]
greybus: greybus_host_device: rename modules -> interfaces

This is really a list of interfaces, not modules, so rename it so that
we don't get confused when we really do add modules to the whole system
later on.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: interface: we really are creating/destroying interfaces not modules.
Greg Kroah-Hartman [Fri, 19 Dec 2014 22:56:35 +0000 (14:56 -0800)]
greybus: interface: we really are creating/destroying interfaces not modules.

rename gb_add_module     -> gb_add_interface
rename gb_remove_modules -> gb_remove_interfaces
rename gb_remove_module  -> gb_remove_interface

And move the function prototypes to interface.h, where they belong.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: greybus_id.h: minor typo fixes
Greg Kroah-Hartman [Fri, 19 Dec 2014 22:56:34 +0000 (14:56 -0800)]
greybus: greybus_id.h: minor typo fixes

Align up the BIT() #defines and properly comment the include block
define.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: interface.h: remove unused #defines
Greg Kroah-Hartman [Fri, 19 Dec 2014 22:56:33 +0000 (14:56 -0800)]
greybus: interface.h: remove unused #defines

MAX_CPORTS_PER_MODULE and MAX_STRINGS_PER_MODULE are not used anywhere
anymore, so remove them lest someone thing we have limits.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: interface: rename greybus_interface_block_id to greybus_interface_id
Greg Kroah-Hartman [Fri, 19 Dec 2014 22:56:32 +0000 (14:56 -0800)]
greybus: interface: rename greybus_interface_block_id to greybus_interface_id

This moves the id structure name to not have "block" in it, as that
doesn't make sense anymore with the renaming of the gb_interface
structure.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: interface: s/gb_interface_block/gb_interface/g
Greg Kroah-Hartman [Fri, 19 Dec 2014 22:56:31 +0000 (14:56 -0800)]
greybus: interface: s/gb_interface_block/gb_interface/g

Rename struct gb_interface_block to struct gb_interface

Lots of renaming, and variable renames as well (gb_ib->intf), but all
should be sane with regards to the new naming scheme we are using.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: rename interface_block.[c|h] -> interface.[c|h]
Greg Kroah-Hartman [Fri, 19 Dec 2014 22:56:30 +0000 (14:56 -0800)]
greybus: rename interface_block.[c|h] -> interface.[c|h]

Interface_block is being renamed to interface, so move the file first.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: interface_block.c: rename the "interfaces" list "bundles"
Greg Kroah-Hartman [Fri, 19 Dec 2014 22:56:29 +0000 (14:56 -0800)]
greybus: interface_block.c: rename the "interfaces" list "bundles"

Alex pointed out one rename I missed previously, this fixes up the
interface_block list of bundles name.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: bundle: s/gb_interface/gb_bundle/g
Greg Kroah-Hartman [Fri, 12 Dec 2014 22:10:17 +0000 (17:10 -0500)]
greybus: bundle: s/gb_interface/gb_bundle/g

Rename struct gb_interface to struct gb_bundle

It's a lot of renaming, some structures got renamed and also some
fields, but the goal was to rename things to make sense with the new
naming of how the system is put together in the 'driver model' view.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: es1-ap-usb: don't protest when getting -EPROTO USB errors
Greg Kroah-Hartman [Fri, 12 Dec 2014 22:10:18 +0000 (17:10 -0500)]
greybus: es1-ap-usb: don't protest when getting -EPROTO USB errors

-EPROTO happens when devices are starting to go away in a system, or
there is something wrong on the USB connection.  Either way, it's safe
to resubmit the urb for this error, don't complain to userspace about
this, as the user will see this for every device removed, which looks
scary, but means nothing.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: bundle: rename interface.[c|h] to bundle.[c|h]
Greg Kroah-Hartman [Fri, 12 Dec 2014 22:10:16 +0000 (17:10 -0500)]
greybus: bundle: rename interface.[c|h] to bundle.[c|h]

We are renameing the "interface" term to "bundle" so rename the files
before we start changing structure names to make it easier for people to
see what really is happening in the changes.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
9 years agogreybus: add Linaro copyrights
Alex Elder [Fri, 12 Dec 2014 18:08:42 +0000 (12:08 -0600)]
greybus: add Linaro copyrights

I was asked to add a Linaro copyright to all Greybus source files
that anyone at Linaro has modified.  This patch does that.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: driver matching: Greybus drivers bind to interface blocks, not modules
Greg Kroah-Hartman [Thu, 11 Dec 2014 22:11:02 +0000 (17:11 -0500)]
greybus: driver matching: Greybus drivers bind to interface blocks, not modules

Because of this, rename greybus_module_id to greybus_interface_block_id.

We still need to add a way for a "class" driver to be bound to an
interface, but for now, all we really need is the vendor/product pair as
the GP Bridge interface block is going to be our main user.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: interface: document sysfs files
Greg Kroah-Hartman [Thu, 11 Dec 2014 22:11:01 +0000 (17:11 -0500)]
greybus: interface: document sysfs files

Yes, an interface has a device id sysfs file, so we need to document it.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: connection: document the sysfs files
Greg Kroah-Hartman [Thu, 11 Dec 2014 22:11:00 +0000 (17:11 -0500)]
greybus: connection: document the sysfs files

Document what the sysfs files are for connections, so that people have a
chance to understand what they can be used for.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: interface_block: move sysfs files into the interface_block.c file
Greg Kroah-Hartman [Thu, 11 Dec 2014 22:10:59 +0000 (17:10 -0500)]
greybus: interface_block: move sysfs files into the interface_block.c file

No need to keep these out in sysfs.c, move them into the
interface_block.c file so that we can see them easier, and remove some
variable definitions by taking advantage of the attribute group macro.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: sysfs documentation: Document the greybus interface block sysfs files.
Greg Kroah-Hartman [Thu, 11 Dec 2014 22:10:58 +0000 (17:10 -0500)]
greybus: sysfs documentation: Document the greybus interface block sysfs files.

Documentation, what, really?

Yes.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: interface_block: rename the sysfs files to not have 'module' in them
Greg Kroah-Hartman [Thu, 11 Dec 2014 22:10:57 +0000 (17:10 -0500)]
greybus: interface_block: rename the sysfs files to not have 'module' in them

The sysfs files for an interface block should not have 'module' in them.
This was a hold-over from when we thought we were going to have
all attributes of a "module" in one directory.  Remove the prefix as
it's not needed, and is confusing considering modules can not have
strings or any of these attributes.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: interface_block: s/gb_module/gb_interface_block/
Greg Kroah-Hartman [Thu, 11 Dec 2014 22:10:56 +0000 (17:10 -0500)]
greybus: interface_block: s/gb_module/gb_interface_block/

Rename struct gb_module to struct gb_interface_block

It's a complex rename, some functions got their name changed where
needed, but primarily this change is focused on the structure and where
it is used.  Future changes will clean up the remaining usages of the
term "module" in individual changes, this one spanned the whole
subsystem so do it all at once.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: interface_block: rename module.[c|h] to interface_block.[c|h]
Greg Kroah-Hartman [Thu, 11 Dec 2014 22:10:55 +0000 (17:10 -0500)]
greybus: interface_block: rename module.[c|h] to interface_block.[c|h]

"modules" in the driver model here, are really "interface blocks" as
that is what they are physically tied to.  So rename the files before we
start changing the code to make it obvious what is going on.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: module: remove obsolete gb_tty pointer
Greg Kroah-Hartman [Thu, 11 Dec 2014 22:10:54 +0000 (17:10 -0500)]
greybus: module: remove obsolete gb_tty pointer

We aren't using this anymore, so remove gb_tty from struct gb_module.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: module versions: remove them
Greg Kroah-Hartman [Thu, 11 Dec 2014 22:10:53 +0000 (17:10 -0500)]
greybus: module versions: remove them

We removed the module version from the spec, so remove them from the
code as well.  It's still in the manifest as we need to sync with gbsim
/ firmware when we do that, which will happen sometime in the next
weeks.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: uart-gb.c: don't include module.h
Greg Kroah-Hartman [Thu, 11 Dec 2014 22:10:52 +0000 (17:10 -0500)]
greybus: uart-gb.c: don't include module.h

No need to specifically include the greybus module.h here, greybus.h
already does so and we will be renaming it soon.

Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: switch cport id used for sends
Alex Elder [Thu, 11 Dec 2014 22:48:38 +0000 (16:48 -0600)]
greybus: switch cport id used for sends

In talking with Perry today I learned that the CPort id expected to
supplied over the HSIC interface to the APB is different from the
way I understood it.

My understanding was that the CPort id to supply always specified
the CPort id on the other end of a connection.  However, Perry says
the mapping between local CPort id and remote CPort id (and device
id) is done by the host UniPro interface.

So whether sending or receiving data, the CPort id that the Greybus
code should supply to the AP Bridge is the one representing the AP
side of a connection.

This patch fixes this.  The receive side already used that CPort id;
it's only the sending code that needed to be changed.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: ENODEV can be an expected error too
Alex Elder [Wed, 10 Dec 2014 20:50:48 +0000 (14:50 -0600)]
greybus: ENODEV can be an expected error too

When probing for i2c devices, a read transfer operation can be used.
In this case, it is expected that some devices will not be found, so
ENODEV is an expected failure.  Don't issue a warning if the return
value is -ENODEV.

Note:  I anticipate we might have to be more precise in identifying
this specific case, but for now this eliminates a bogus warning when
probing i2c devices.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: define GB_OP_NONEXISTENT
Alex Elder [Wed, 10 Dec 2014 14:43:33 +0000 (08:43 -0600)]
greybus: define GB_OP_NONEXISTENT

The i2c protocol needs a way to indicate an i2c device doesn't exist
(which is not necessarily an error).  Define GB_OP_NONEXISTENT to
indicate this, and updating the status<->errno mapping functions
accordingly.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: greybus_manifest.h: add FIXME for version
Greg Kroah-Hartman [Tue, 9 Dec 2014 19:57:04 +0000 (14:57 -0500)]
greybus: greybus_manifest.h: add FIXME for version

The version field is going to go away, but after the demo, not before.
Note that in the header file.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: battery-gb.c: add new functions from Greybus spec document.
Greg Kroah-Hartman [Mon, 8 Dec 2014 22:45:10 +0000 (17:45 -0500)]
greybus: battery-gb.c: add new functions from Greybus spec document.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: record type in operation structure
Alex Elder [Wed, 3 Dec 2014 18:27:46 +0000 (12:27 -0600)]
greybus: record type in operation structure

I've gone back and forth on this, but now that I'm looking at
asynchronous operations I know that the asynchronous callback will
want to know what type of operation it is handling, and right now
that's only available in the message header.

So record an operation's type in the operation structure, and use
it in a few spots where the header type was being used previously.
Pass the type to gb_operation_create_incoming() so it can fill
it in after the operation has been created.

Clean up the crap comments above the definition of the operation
structure.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: use null pointer for empty payload
Alex Elder [Wed, 3 Dec 2014 18:27:45 +0000 (12:27 -0600)]
greybus: use null pointer for empty payload

Currently message->payload always points to the address immediately
following the header in a message.  If the payload length is 0, this
is not a valid pointer.

Change the code to assign a null pointer to the payload in this
case.  I have verified that no code dereferences the payload pointer
unless the payload is known to have non-zero size.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: only record message payload size
Alex Elder [Wed, 3 Dec 2014 18:27:44 +0000 (12:27 -0600)]
greybus: only record message payload size

An asynchronous operation will want to know how big the response
message it receives is.  Rather than require the sender to record
that information, expose a new field "payload_size" available to
the protocol code for this purpose.

An operation message consists of a header and a payload.  The size
of the message can be derived from the size of the payload, so
record only the payload size and not the size of the whole message.
Reorder the fields in a message structure.

Update the description of the message header structure.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: don't let i2c code assume non-null payload pointer
Alex Elder [Wed, 3 Dec 2014 18:27:43 +0000 (12:27 -0600)]
greybus: don't let i2c code assume non-null payload pointer

This is in preparation for an upcoming patch, which makes the
payload pointer be NULL when a message has zero bytes of payload.

It ensures a null payload pointer never gets dereferenced.  To do
this we pass the response structure to gb_i2c_transfer_response()
rather than just its data, and if it's null, returning immediately.

Rearrange the logic in gb_i2c_transfer_operation() a bit.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: set up connection->private properly
Alex Elder [Wed, 3 Dec 2014 18:27:42 +0000 (12:27 -0600)]
greybus: set up connection->private properly

The connection->private pointer should refer to a protocol-specific
data structure.  Change two protocol drivers (USB and vibrator) so
they now set this.

In addition, because the setup routine may need access to the
data structure, the private pointer should be set early--as
early as possible.  Make the UART, i2c, and GPIO protocol drivers
set the private pointer earlier.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: fix an error message
Alex Elder [Wed, 3 Dec 2014 18:27:41 +0000 (12:27 -0600)]
greybus: fix an error message

The error message printed by gb_operation_sync() if the operation
fails is wrong.  Fix it.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: introduce gb_operation_request_send_sync()
Alex Elder [Wed, 3 Dec 2014 14:35:09 +0000 (08:35 -0600)]
greybus: introduce gb_operation_request_send_sync()

Define a new function used to initiate a synchronous operation.
It sends the operation request message and doesn't return until
the response has been received and/or the operation's result
has been set.

This gets rid of the convention that a null callback pointer
signifies a synchronous operation.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: make op_cycle atomic (again)
Alex Elder [Wed, 3 Dec 2014 14:35:08 +0000 (08:35 -0600)]
greybus: make op_cycle atomic (again)

There's no need to protect updating a connections operation id cycle
counter with the operations spinlock.   That spinlock protects
connection lists, which do not interact with the cycle counter.
All that we require is that it gets updated atomically, and we
can express that requirement in its type.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: get rid of pending operations list
Alex Elder [Wed, 3 Dec 2014 14:35:07 +0000 (08:35 -0600)]
greybus: get rid of pending operations list

A connection has two lists of operations, and an operation is always
on one or the other of them.  One of them contains the operations
that are currently "in flight".

We really don't expect to have very many in-flight operations on any
given connection (in fact, at the moment it's always exactly one).
So there's no significant performance benefit to keeping these in a
separate list.  An in-flight operation can also be distinguished by
its errno field holding -EINPROGRESS.

Get rid of the pending list, and search all operations rather than
the pending list when looking up a response message's operation.
Rename gb_pending_operation_find() accordingly.

There's no longer any need to remove operations from the pending
list, and the insertion function no longer has anything to do with a
pending list.  Just open code what was the insertion function (it
now has only to do with assigning the operation id).

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: don't use 0 as an operation id
Alex Elder [Wed, 3 Dec 2014 14:35:06 +0000 (08:35 -0600)]
greybus: don't use 0 as an operation id

Stop allowing 0x0000 to be used as an operation id.  That id will be
reserved for use by operations that will return no response message.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: define the invalid operation type symbolically
Alex Elder [Tue, 2 Dec 2014 23:25:11 +0000 (17:25 -0600)]
greybus: define the invalid operation type symbolically

Use a symbolic constant (rather than just "0") to represent an
explicitly invalid operation type.  The protocols have all reserved
that value for that purpose--this just makes it explicit in the core
code (since we now leverage its existence).  Fix the code so it uses
the new symbolic value.

Define it in "operation.h" for all to see.  Move the common
definition of the GB_OPERATION_TYPE_RESPONSE flag mask there
as well.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: fix a bug in gb_operation_sync()
Alex Elder [Tue, 2 Dec 2014 23:03:51 +0000 (17:03 -0600)]
greybus: fix a bug in gb_operation_sync()

The memcpy of request data into the request payload was
copying the data into the wrong location.  Fix that.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: use little-endian in PWM requests
Alex Elder [Tue, 2 Dec 2014 21:48:09 +0000 (15:48 -0600)]
greybus: use little-endian in PWM requests

The PWM config request defines two 32-bit values using u32. All
over-the-wire values have to be in little-endian format.  Fix this.

Signed-off-by: Alex Elder <elder@linaro.org>
Acked-by: Matt Porter <mporter@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: send operation response messages
Alex Elder [Tue, 2 Dec 2014 14:30:39 +0000 (08:30 -0600)]
greybus: send operation response messages

Define a helper function gb_operation_response_alloc() and use it
to allocate the response buffer for outgoing operations in
gb_operation_create_common(.

Use it also in  gb_operation_response_send() if the caller has not
allocated a response buffer.

Once a response buffer is allocated, fill in its result code and
send it.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: introduce gb_operation_errno_map()
Alex Elder [Tue, 2 Dec 2014 14:30:38 +0000 (08:30 -0600)]
greybus: introduce gb_operation_errno_map()

Define gb_operation_errno_map(), which maps an operation->errno
into the u8 value that represents it in the status field of an
operation response header.  It'll be used in an upcoming patch.

Make gb_operation_status_map() a private function.  It's not used
outside "operation.c" and I don't believe it ever should be.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: activate incoming request handling
Alex Elder [Tue, 2 Dec 2014 14:30:37 +0000 (08:30 -0600)]
greybus: activate incoming request handling

Un-comment gb_operation_request_handle(), which was recently
disabled to avoid distraction.

In gb_connection_recv_request(), activate handling incoming
requests by defining gb_operation_request_handle() as an
incoming operation's callback function.

Incoming operation requests have

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: set result in gb_operation_response_send()
Alex Elder [Tue, 2 Dec 2014 14:30:36 +0000 (08:30 -0600)]
greybus: set result in gb_operation_response_send()

Change gb_operation_response_send() so it takes an errno to assign
as an operation's result.  This emphasizes that setting the result
should be the last thing done to an incoming operation before
sending its response.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: create a slab cache for simple messages
Alex Elder [Tue, 2 Dec 2014 14:30:35 +0000 (08:30 -0600)]
greybus: create a slab cache for simple messages

A large number of request and response message types have no payload.
Such "simple" messages have a known, fixed maximum size, so we can
preallocate and use a pool (slab cache) of them.

Here are two benefits to doing this:
    - There can be (small) performance and memory utilization
      benefits to using a slab cache.
    - Error responses can be sent with no payload; the cache is
      likely to have a free entry to use for an error response even
      in a low memory situation.

The plan here is that an incoming request handler that has no
response payload to fill will not need to allocate a response
message.  If no message has been allocated when a response is to be
sent, one will be allocated from the cache by the core code.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: enforce a buffer headroom maximum size
Alex Elder [Tue, 2 Dec 2014 14:30:34 +0000 (08:30 -0600)]
greybus: enforce a buffer headroom maximum size

Define a maximum size that a host device can use for its private
area ahead of the payload space used by Greybus in a message buffer.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: introduce gb_operation_message_init()
Alex Elder [Tue, 2 Dec 2014 14:30:33 +0000 (08:30 -0600)]
greybus: introduce gb_operation_message_init()

Separate the allocation of a message structure from its basic
initialization.  This will allow very common fixed-size operation
response buffers to be allocated from a slab cache.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: use operation type 0 to signal incoming data
Alex Elder [Tue, 2 Dec 2014 14:30:32 +0000 (08:30 -0600)]
greybus: use operation type 0 to signal incoming data

When incoming data is going to be handled as a request, we create a
new operation whose request buffer will hold the received data.
There is no need to initialize the message header in such a request
buffer because it will be immediately overwritten.

Use operation type value of 0x00 in gb_operation_create_common()
to signal that we are creating an incoming operation, and therefore
do not need to initialize the request message header.  This allows
us to get rid of the Boolean "outgoing" parameter.

As a result, we can stop supplying the "type" parameter to both
gb_operation_create_incoming() and gb_connection_recv_request().

Update the header comments for gb_operation_message_alloc() and
gb_operation_create_common().

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: enforce non-zero operation type requirement
Alex Elder [Tue, 2 Dec 2014 14:30:31 +0000 (08:30 -0600)]
greybus: enforce non-zero operation type requirement

The operation type 0x00 is reserved as an explicitly invalid
operation type in all protocols.  Enforce this.

Add a check for callers who erroneously have the RESPONSE message
type flag set in the operation type passed in gb_operation_create().

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: pass result in gb_connection_recv_response()
Alex Elder [Tue, 2 Dec 2014 14:30:30 +0000 (08:30 -0600)]
greybus: pass result in gb_connection_recv_response()

Pass the operation result to gb_connection_recv_response() as a
parameter.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
9 years agogreybus: short message is OK for errors
Alex Elder [Tue, 2 Dec 2014 14:30:29 +0000 (08:30 -0600)]
greybus: short message is OK for errors

We enforce a rule that a response message must completely fill the
buffer that's been allocated to hold it.  However, if an error
occurs, the payload is off limits, so we should allow a short
message to convey an error result.

Change gb_connection_recv_response() to require the right message
size only if there's no error.

One other thing:  The arriving data is only being copied into the
response buffer if the request was successful.  That means the
response message header is assumed to have been initialized.  That
isn't a valid assumption.  So change it so that if an error is
seen, the header portion of the message is copied into the
response buffer--but only the header.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>