Thomas Lamprecht [Thu, 29 Jun 2017 14:37:32 +0000 (16:37 +0200)]
replication: reuse fitting translations
while it does not makes sense do over-reuse translations for the sake
of translating less, imo, here we can safely reuse already existing
ones and pull out the unit 'MB/s' from the gettext.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Thu, 29 Jun 2017 09:22:53 +0000 (11:22 +0200)]
replication; merge status and status text and add to dc mode
It was a bit strange to have two separate status columns, which do
effectively the same thing. So merge them together to save a bit
space and have less columns.
We do not need to translate 'Status Text' as a nice side effect.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 28 Jun 2017 07:19:49 +0000 (09:19 +0200)]
grid/replication: show textual description of default value
When a user sees this the first time and wants to add a job he
shouldn't be confused what the default value means, so display this
through the emptyText property, which does not get submitted to the
backend.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
tests: mock PVE::Cluster::get_members and adapt fail test
Commit 3385399339c94 ("replication: keep retrying every 30 minutes in
error state") changed the retry behavior to not stop after the 3rd error
and then stick to half-hour intervals. This needs to be reflected in the
tests. The numbers here match. (1900 + 30*60 = 3700).
Commit fd844180a7efa ("replication: don't sync to offline targets on
error states) changed the retry behavior to check whether the target
node is online. If this is not the case we fail right away. This
introduced a dependency on PVE::Cluster::get_members which we now need
to mock. Tests currently use node names "node{1,2,3}", so I just mock
those 3.
Thomas Lamprecht [Tue, 27 Jun 2017 13:01:26 +0000 (15:01 +0200)]
replication/ui: improve wording for job removal
Delete the strange sounding Note from the Removal dialog.
This was added to make sure that an user isn't confused that a Job is
still shown after 'removing' it. But it isn't needed as there is
already noted in the jobs status that it will get removed soon after
doing so, so the user sees that his action had the desired effect, no
extra note needed.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Emmanuel Kasper [Tue, 27 Jun 2017 07:52:39 +0000 (09:52 +0200)]
Add a Skip replication option on Disk Panel
This will allow to disable replication, when for instance we
add a disk on a non-replicatable storage.
The option is hidden in the wizard, because at that time no VM
replication has been set.
Dominik Csapak [Fri, 23 Jun 2017 09:36:37 +0000 (11:36 +0200)]
fix lxc hostname input window
we used a static emptytext at creation, which is wrong after editing
now copied from qemu/Options.js (the name), but instead of deleting the
hostname on the backend on an empty field, we set it to CT<VMID>
(this is also the default in the wizard)
Dominik Csapak [Fri, 23 Jun 2017 09:00:58 +0000 (11:00 +0200)]
fix reselection on vm/ct migrate in gui
there were a number of problems in how we reselected vms when they
migrated and selected:
we relied on the data in the configpanel to be static, but since
pveselnode is a reference, it actually changes when the resourcestore
changes
also, handling the reselection as a response to the statusstore failure
is very inconsistent, because we know exactly when a vm moves node in
the tree
this patch removes the whole configpanel vm migration code,
and lets the tree handle it
for this, we have to check if we have to reselect the entry,
deselect it manually and after the treeupdate reselect it
also in the right click selection check we have to check if it is
already selected, else the next selection will get canceled
Dominik Csapak [Mon, 19 Jun 2017 14:25:49 +0000 (16:25 +0200)]
change default replication status text to 'OK'
The status '-' can confuse users, as it could indicate something is
missing, whereas OK indicates everything is alright (which is the status
we want to show)
Thomas Lamprecht [Wed, 17 May 2017 10:40:27 +0000 (12:40 +0200)]
OSD: rename 'remove' to 'destroy'
To have consistency with the CLI tools `pveceph destroyosd` command.
This is also more clear about the resulting action, as 'Remove' could
also just mean 'Remove from Config', for example.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
pvereport: improve output and add timeouts to commands
Each command may not run longer than 10 seconds. This avoids
situations where no output gets generated because of a infinitely
hanging command (e.g. check for dead NFS storage)
Also ensure that commands are separated with a new line from each
other to improve readability.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Emmanuel Kasper [Wed, 14 Jun 2017 09:22:20 +0000 (11:22 +0200)]
Fix SafeDestroy when entering a numeric resource ID
In a previous commit, the inputField of SafeDestroy.js was converted
from a numberfield to a textfield to allow ceph pools names to be
entered.
This means the type of 'value' changed from number to string and
the strong equal test === was failing against a numeric id.
To solve this, we now always stringify the resource id before comparing.
Dominik Csapak [Wed, 14 Jun 2017 06:52:59 +0000 (08:52 +0200)]
use correct vmid for id when in vm replication panel
values.guest is only available when the field 'guest' is not a
displayfield (e.g. when in vm replication panel), so we have to
use the given vmid first and only when this is not available, fall back
to the value of the field
Dominik Csapak [Tue, 13 Jun 2017 12:56:03 +0000 (14:56 +0200)]
add calendarevent form field
this is a freely editable combobox, which shows five usable examples and
their syntax, allowing users to deduct how the syntax works without
reading documentation
explicit set button focus respecting the 'dangerous' option
The line:
> Ext.MessageBox.defaultButton = me.dangerous ? 2 : 1;
just set the button which should get triggered on an keyboard "Enter"
if no button is focused currently.
But often the 'Yes' buttons is focused so an enter press would
trigger it, even on a as 'dangerous' marked option.
Fix this, as else a to fast "Enter" press can cause more problems
than needed.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Reviewed-By: Dominik Csapak <d.csapak@proxmox.com>
Otherwise the user running the tests may either create (and
end up being the ownderof) the system wide
/var/lock/pve-manager/* files, or the tests will fail (or
loop endlessly) if the user doesn't have access to them.
projects / pve-manager.git / log