]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/log
mirror_ubuntu-artful-kernel.git
8 years agostaging: greybus: audio: delete unnecessary parentheses
Eva Rachel Retuya [Wed, 21 Sep 2016 05:03:24 +0000 (13:03 +0800)]
staging: greybus: audio: delete unnecessary parentheses

Eliminate unneeded parentheses around the right hand side of an assignment.
Coccinelle semantic patch used:

@@
expression e1, e2;
identifier v;
@@

(
 v = (e1 == e2)
|
 v = (e1 != e2)
|
 v = (e1 <= e2)
|
 v = (e1 >= e2)
|
 v =
- (
e1
- )
)

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: greybus: camera: simplify NULL test
Eva Rachel Retuya [Wed, 21 Sep 2016 04:59:29 +0000 (12:59 +0800)]
staging: greybus: camera: simplify NULL test

Replace direct comparisons to NULL i.e. 'x == NULL' with '!x' for consistency.
Coccinelle semantic patch used:

@@
identifier func;
expression x;
statement Z;
@@

x = func(...);

if (
(
+ !
x
- == NULL
|
+ !
- NULL ==
x
)
   ) Z

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: most: replace MOST_CH_ISOC_AVP with MOST_CH_ISOC
Andrey Shvetsov [Wed, 21 Sep 2016 12:49:10 +0000 (14:49 +0200)]
staging: most: replace MOST_CH_ISOC_AVP with MOST_CH_ISOC

This patch replaces the enum value MOST_CH_ISOC_AVP with the more
appropriate MOST_CH_ISOC.

Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: most: clean up configuration strings
Christian Gromm [Wed, 21 Sep 2016 12:49:09 +0000 (14:49 +0200)]
staging: most: clean up configuration strings

This patch adds the strings 'rx', 'tx' and 'isoc' to the list of accepted
identifiers when setting up a channel configuration. To keep consistency it
removes the prefix "dir_" from strings returned by the attributes
set_direction and available_directions and it removes the suffix "_avp"
from the string "isoc_avp" returned by the attributes set_datatype and
available_datatypes.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: most: core: remove trailing zero from text property
Andrey Shvetsov [Wed, 21 Sep 2016 12:49:08 +0000 (14:49 +0200)]
staging: most: core: remove trailing zero from text property

This patch removes trailing zeros from the strings returned by the
attributes available_datatypes and available_directions.

Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: most: make function most_submit_mbo return void
Christian Gromm [Wed, 21 Sep 2016 12:49:05 +0000 (14:49 +0200)]
staging: most: make function most_submit_mbo return void

Function most_submit_mbo() causes an exception only if either the pointer
mbo or mbo->context equals NULL. From the underlying architecture's point
of view both cases must _not_ come true and would happen only, if something
has tampered with the pointers. This would render runtime code unable to
recover anyway. So, instead trying to hide that things are already
critically out of control we're better off with a WARN_ON() assertion.

This patch replaces the return type of the function most_submit_mbo() with
'void' and adds a WARN_ONCE() assertion. Additionally, code calling the
function is adapted accordingly.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wlan-ng: fixed block comment formatting
Juliana Rodrigues [Thu, 22 Sep 2016 03:24:40 +0000 (00:24 -0300)]
staging: wlan-ng: fixed block comment formatting

This patch fixes a checkpatch warning in
a block comment by adapting it to the community
preferred coding style.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wlan-ng: fixed alignment not matching
Juliana Rodrigues [Thu, 22 Sep 2016 05:49:50 +0000 (02:49 -0300)]
staging: wlan-ng: fixed alignment not matching

This patch fixes a checkpatch warning by moving
arguments to the right and aligning them to their open
parenthesis.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wlan-ng: fixed parenthesis alignment
Juliana Rodrigues [Thu, 22 Sep 2016 05:50:56 +0000 (02:50 -0300)]
staging: wlan-ng: fixed parenthesis alignment

This patch fixes a checkpatch warning by moving
arguments to the right and aligning them to the open
parenthesis above.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wlan-ng: fixed block comment trailing
Juliana Rodrigues [Thu, 22 Sep 2016 06:01:28 +0000 (03:01 -0300)]
staging: wlan-ng: fixed block comment trailing

Moved trailing */ to a new line and added * to subsequent lines on a
block comment.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: greybus: add maintainer for greybus platform drivers
Vaibhav Hiremath [Wed, 21 Sep 2016 10:58:13 +0000 (16:28 +0530)]
staging: greybus: add maintainer for greybus platform drivers

Add Vaibhav Hiremath as a Maintainer of Greybus platform
drivers.

Signed-off-by: Vaibhav Hiremath <hvaibhav.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: greybus: fix up camera Kconfig dependancies
Greg Kroah-Hartman [Wed, 21 Sep 2016 10:35:13 +0000 (12:35 +0200)]
staging: greybus: fix up camera Kconfig dependancies

CONFIG_MEDIA is not a thing, but CONFIG_MEDIA_SUPPORT is, so use that.

Reported-by: Valentin Rothberg <valentinrothberg@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: include: remove unused ULTRA_CHANNELCLI_STRING
David Kershner [Tue, 20 Sep 2016 20:29:02 +0000 (16:29 -0400)]
staging: unisys: include: remove unused ULTRA_CHANNELCLI_STRING

The inline ULTRA_CHANNELCLI_STRING is not being used so remove it.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: include: remove unused spar_channel_client_release_os
David Kershner [Tue, 20 Sep 2016 20:29:01 +0000 (16:29 -0400)]
staging: unisys: include: remove unused spar_channel_client_release_os

The function spar_channel_client_release_os is not being
used so remove it.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: include: remove unused spar_channel_client_acquire_os
David Kershner [Tue, 20 Sep 2016 20:29:00 +0000 (16:29 -0400)]
staging: unisys: include: remove unused spar_channel_client_acquire_os

The function spar_channel_client_acquire_os is not being used so
remove it.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: include: remove unused function pathname_last_n_nodes
David Kershner [Tue, 20 Sep 2016 20:28:59 +0000 (16:28 -0400)]
staging: unisys: include: remove unused function pathname_last_n_nodes

The function pathname_last_n_nodes is not used, get rid of it.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorhba: remove prototypes for visorhba_main.c
David Kershner [Tue, 20 Sep 2016 17:14:05 +0000 (13:14 -0400)]
staging: unisys: visorhba: remove prototypes for visorhba_main.c

Remove not needed prototypes in visorhba.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visornic: remove poll_for_irq prototype
David Kershner [Tue, 20 Sep 2016 15:42:06 +0000 (11:42 -0400)]
staging: unisys: visornic: remove poll_for_irq prototype

Remove poll_for_irq prototype not needed.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visornic: remove visornic_poll prototype
David Kershner [Tue, 20 Sep 2016 15:42:05 +0000 (11:42 -0400)]
staging: unisys: visornic: remove visornic_poll prototype

Remove visornic_poll prototype, because it is not needed.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visornic: remove visornic debugfs protoyptes
David Kershner [Tue, 20 Sep 2016 15:42:04 +0000 (11:42 -0400)]
staging: unisys: visornic: remove visornic debugfs protoyptes

Remove visornic debugfs prototypes, they are not needed.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visornic: remove prototypes
David Kershner [Tue, 20 Sep 2016 15:42:03 +0000 (11:42 -0400)]
staging: unisys: visornic: remove prototypes

Remove unneeded prototypes from visornic_main.c

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: greybus: add maintainer for greybus audio protocol driver
Vaibhav Agarwal [Wed, 21 Sep 2016 08:47:05 +0000 (14:17 +0530)]
staging: greybus: add maintainer for greybus audio protocol driver

Add Vaibhav as maintainer of some Greybus Audio protocol drivers.

Signed-off-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: ptlrpc: re-export lustre_swab_lov_mds_md
James Simmons [Tue, 20 Sep 2016 17:31:09 +0000 (13:31 -0400)]
staging: lustre: ptlrpc: re-export lustre_swab_lov_mds_md

Being over zealous in removing unused EXPORT_SYMBOLs the function
lustre_swab_lov_mds_md exports were removed. They need to be
exported so this patch restores those EXPORT_SYMBOLS. Same
mistake was done when porting to the upstream client.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: http://review.whamcloud.com/14545
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6486
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: greybus: add Viresh as maintainer of few greybus protocol drivers
Viresh Kumar [Wed, 21 Sep 2016 06:40:16 +0000 (12:10 +0530)]
staging: greybus: add Viresh as maintainer of few greybus protocol drivers

Add Viresh Kumar as Maintainer of some of the Greybus protocol drivers.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rts5208: Remove space after cast
Rehas Sachdeva [Tue, 20 Sep 2016 11:16:24 +0000 (16:46 +0530)]
staging: rts5208: Remove space after cast

Removes unnecessary space after a cast. Issue found by checkpatch.

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rts5208: Use BIT(x) macro
Rehas Sachdeva [Tue, 20 Sep 2016 11:16:05 +0000 (16:46 +0530)]
staging: rts5208: Use BIT(x) macro

Replaces left shift operation (1 << x) by BIT(x). Issue found by checkpatch.

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rts5208: Put constant on right side of comparison
Rehas Sachdeva [Tue, 20 Sep 2016 11:15:48 +0000 (16:45 +0530)]
staging: rts5208: Put constant on right side of comparison

Replaces position of constant from left to right side of a comparison.
Additionally, modifies logical continuations to be on the previous line and
fixes alignment to match open parenthesis. Issues found by checkpatch.

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rts5208: Fix indentation
Rehas Sachdeva [Tue, 20 Sep 2016 11:15:33 +0000 (16:45 +0530)]
staging: rts5208: Fix indentation

Fixes indentation by removing unnecessary TAB. Issue found by checkpatch.

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rts5208: Add spaces around operators
Rehas Sachdeva [Tue, 20 Sep 2016 11:15:04 +0000 (16:45 +0530)]
staging: rts5208: Add spaces around operators

Adds spaces on either side of arithmetic and relational operators like
'-', '<' and '*'. Issue found by checkpatch.

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rts5208: Remove unnecessary parentheses
Rehas Sachdeva [Tue, 20 Sep 2016 11:14:51 +0000 (16:44 +0530)]
staging: rts5208: Remove unnecessary parentheses

Removes unnecessary parentheses from an expression of the form &(x).
Issue found by checkpatch.

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: comedi: Use vma_pages function on vma object instead of explicit computation
sayli karnik [Mon, 19 Sep 2016 21:51:38 +0000 (03:21 +0530)]
staging: comedi: Use vma_pages function on vma object instead of explicit computation

This patch uses vma_pages function on vma object instead of explicit
computation.

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: vt6655: baseband: Remove unnecessary space after a cast
Sandhya Bankar [Mon, 19 Sep 2016 12:14:43 +0000 (17:44 +0530)]
Staging: vt6655: baseband: Remove unnecessary space after a cast

No space is necessary after a cast. This issue was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: vt6655: card: Remove unnecessary space after a cast
Sandhya Bankar [Mon, 19 Sep 2016 12:17:21 +0000 (17:47 +0530)]
Staging: vt6655: card: Remove unnecessary space after a cast

No space is necessary after a cast. This issue was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: sm750fb: Add spaces around '|'
Rehas Sachdeva [Mon, 19 Sep 2016 13:56:32 +0000 (19:26 +0530)]
staging: sm750fb: Add spaces around '|'

Adds spaces on either side of a '|'. Issue found by checkpatch.

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wlan-ng: Remove unnecessary variable usage
Rehas Sachdeva [Mon, 19 Sep 2016 19:35:54 +0000 (01:05 +0530)]
staging: wlan-ng: Remove unnecessary variable usage

Instead of storing the return value into a variable and then returning it, we
can club the two into a single return statement. This change was made using
the following semantic patch by Coccinelle:

@@
local idexpression ret;
expression e;
@@

-ret =
+return
     e;
-return ret;

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: most: hdm-usb: convert pr_warn() to dev_warn()
Eva Rachel Retuya [Tue, 20 Sep 2016 03:09:05 +0000 (11:09 +0800)]
staging: most: hdm-usb: convert pr_warn() to dev_warn()

Replace pr_warn() call with its respective dev_warn() counterpart.
Semantic patch used to detect and apply the transformation:

@a@
identifier dev;
expression E;
@@

struct device *dev = E;
<+... when != dev == NULL
- pr_warn(
+ dev_warn(dev,
...);
...+>

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: media: cxd2099: replace printk with dev_info
Eva Rachel Retuya [Tue, 20 Sep 2016 07:00:49 +0000 (15:00 +0800)]
staging: media: cxd2099: replace printk with dev_info

Use dev_info() instead of printk(). Majority of the conversion was done
previously on this commit:
011b2aa [media] staging/media: Use dev_ printks in cxd2099/cxd2099.[ch]

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: media: bcm2048: Merge assignment with return
Rehas Sachdeva [Tue, 20 Sep 2016 08:00:24 +0000 (13:30 +0530)]
staging: media: bcm2048: Merge assignment with return

Instead of storing the return value into a variable and then returning it, we
can club the two into a single return statement. This change was made using
the following semantic patch by Coccinelle:

@@
local idexpression ret;
expression e;
@@

-ret =
+return
     e;
-return ret;

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: media: davinci_vpfe: Merge assignment with return
Rehas Sachdeva [Tue, 20 Sep 2016 08:00:47 +0000 (13:30 +0530)]
staging: media: davinci_vpfe: Merge assignment with return

Instead of storing the return value into a variable and then returning it, we
can club the two into a single return statement. This change was made using
the following semantic patch by Coccinelle:

@@
local idexpression ret;
expression e;
@@

-ret =
+return
     e;
-return ret;

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rts5208: Add space around operator.
Sandhya Bankar [Mon, 19 Sep 2016 11:30:16 +0000 (17:00 +0530)]
Staging: rts5208: Add space around operator.

Add space around operator. This patch was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rts5208: rtsx: Use x instead of x != NULL.
Sandhya Bankar [Mon, 19 Sep 2016 09:15:04 +0000 (14:45 +0530)]
Staging: rts5208: rtsx: Use x instead of x != NULL.

Use x instead of x != NULL. This patch was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rts5208: ms: Use x instead of x != NULL.
Sandhya Bankar [Mon, 19 Sep 2016 09:12:24 +0000 (14:42 +0530)]
Staging: rts5208: ms: Use x instead of x != NULL.

Use x instead of x != NULL. This patch was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rts5208: rtsx_card.c: Fixed brace style issues
Cathal Mullaney [Sun, 18 Sep 2016 19:08:45 +0000 (20:08 +0100)]
Staging: rts5208: rtsx_card.c: Fixed brace style issues

Fixed several minor brace coding style issues.

Signed-off-by: Cathal Mullaney <chuckleberryfinn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: ks7010: michael_mic: Use "foo *bar" instead of "foo * bar".
Sandhya Bankar [Tue, 20 Sep 2016 07:41:39 +0000 (13:11 +0530)]
Staging: ks7010: michael_mic: Use "foo *bar" instead of "foo * bar".

This issue was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: ks7010: Use "foo *bar" instead of "foo * bar".
Sandhya Bankar [Tue, 20 Sep 2016 07:39:58 +0000 (13:09 +0530)]
Staging: ks7010: Use "foo *bar" instead of "foo * bar".

This issue was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: ks7010: Use "foo *bar" instead of "foo * bar"
Sandhya Bankar [Tue, 20 Sep 2016 06:45:15 +0000 (12:15 +0530)]
Staging: ks7010: Use "foo *bar" instead of "foo * bar"

This patch was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: ks7010: Use sizeof structure *pointer over sizeof structure in kzalloc()
Sandhya Bankar [Tue, 20 Sep 2016 06:25:47 +0000 (11:55 +0530)]
Staging: ks7010: Use sizeof structure *pointer over sizeof structure in kzalloc()

This issue was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: ks7010: Remove unnecessary variable used to store return value
sayli karnik [Sun, 18 Sep 2016 20:16:34 +0000 (01:46 +0530)]
staging: ks7010: Remove unnecessary variable used to store return value

This patch removes an unnecessary variable used to store return values in order
to reduce memory usage.
Done using coccinelle:
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
return
- ret
+ C
;

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: ks7010: fixes typo in ks_hostif.c
Hariharan R [Mon, 19 Sep 2016 00:16:03 +0000 (20:16 -0400)]
staging: ks7010: fixes typo in ks_hostif.c

Fixes typo,
FAILUER -> FAILURE
Recieve -> Receive

Signed-off-by: Hariharan R <hariharanrangasamy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: fsl-mc: Use !x instead of x == NULL.
Sandhya Bankar [Sat, 17 Sep 2016 23:37:21 +0000 (05:07 +0530)]
Staging: fsl-mc: Use !x instead of x == NULL.

Use !x instead of x == NULL. This issue was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: octeon: Add missing of_node_put after calling of_parse_phandle.
Sandhya Bankar [Sun, 18 Sep 2016 17:32:33 +0000 (23:02 +0530)]
Staging: octeon: Add missing of_node_put after calling of_parse_phandle.

of_node_put needs to be called when the device node which is got
from of_parse_phandle is no longer used.
This patch is found by below coccinelle script:

@@
expression e,e1,e2;
@@
*e = of_parse_phandle(...)
... when != of_node_put(e)
    when != true e == NULL
    when != e2 = e
e = e1

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: i4l: act2000: Move assignment out of if statement
sayli karnik [Mon, 19 Sep 2016 14:32:40 +0000 (20:02 +0530)]
staging: i4l: act2000: Move assignment out of if statement

This patch places assignments which are inside the if condition, above it.
Done using coccinelle:

@@
statement s;
expression e;
identifier id;
@@
- if ((id = e))
+ id = e;
+ if (id)
        s

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: i4l: Remove unused variable
Sandhya Bankar [Sun, 18 Sep 2016 19:01:12 +0000 (00:31 +0530)]
Staging: i4l: Remove unused variable

Remove unused variable.

This change is made by below coccinelle script:
@@
type T;
identifier i;
constant C;
@@
(
extern T i;
|
- T i;
  <+... when != i
- i = C;
  ...+>
)

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: i4l: Use !x instead of x == NULL.
Sandhya Bankar [Sun, 18 Sep 2016 00:08:34 +0000 (05:38 +0530)]
Staging: i4l: Use !x instead of x == NULL.

Use !x instead of x == NULL. This issue was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: i4l: Do not initialise statics to 0.
Sandhya Bankar [Sat, 17 Sep 2016 23:59:03 +0000 (05:29 +0530)]
Staging: i4l: Do not initialise statics to 0.

Do not initialise statics to 0. Static variable by default initialise to 0,
so no need to explicit initialisation. This issue was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: i4l: Remove NULL comparison.
Sandhya Bankar [Sat, 17 Sep 2016 23:46:44 +0000 (05:16 +0530)]
Staging: i4l: Remove NULL comparison.

This patch removes the explicit NULL comparison. This issue was found by
checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: iio: isl29018: remove the FSF's mailing address
Brian Masney [Tue, 20 Sep 2016 09:38:56 +0000 (05:38 -0400)]
staging: iio: isl29018: remove the FSF's mailing address

Address warning from checkpatch:

CHECK: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF has
changed addresses in the past, and may do so again. Linux already
includes a copy of the GPL.

Signed-off-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: iio: meter: ade7754: Match alignment with open parenthesis
Georgiana Rodica Chelu [Mon, 19 Sep 2016 16:35:09 +0000 (19:35 +0300)]
staging: iio: meter: ade7754: Match alignment with open parenthesis

Reorganize the parameters to improve the readability of the code in
two manners:
- parameters of distinctive variable types on different lines
- parameters of similar variable types on the same line

Also, take advantage of the horizontal space available and place
all the parameters on a single line.

Issues found by checkpatch.pl script.

Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: iio: meter: ade7758_ring: Match alignment with open parenthesis
Georgiana Rodica Chelu [Mon, 19 Sep 2016 15:41:56 +0000 (18:41 +0300)]
staging: iio: meter: ade7758_ring: Match alignment with open parenthesis

Organize the parameters on a single line to improve the readability of
the code. Also, indent the line to match alignment with the open
parenthesis. Ensure that the modifications do not break the rule
of 80 characters per line.

Issues found by checkpatch.pl script.

Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: dgnc: Merge assignment with return
Rehas Sachdeva [Tue, 20 Sep 2016 07:46:37 +0000 (13:16 +0530)]
staging: dgnc: Merge assignment with return

Instead of storing the return value of a function call into a variable and
then returning it, we can club the two into a single return statement. This
change was made using the following semantic patch by Coccinelle:

@@
local idexpression ret;
expression e;
@@

-ret =
+return
     e;
-return ret;

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8188eu: core: rtw_xmit: Remove extra braces
Georgiana Rodica Chelu [Tue, 20 Sep 2016 09:13:06 +0000 (12:13 +0300)]
staging: rtl8188eu: core: rtw_xmit: Remove extra braces

Remove the braces {} in the following cases:
- when there is a single branch with a single statement.
- when both branches have a single statement

The modifications improve the coding style.
Issues found by checkpatch.pl script.

Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rtl8712: rtl871x_cmd: Use !x instead of x == NULL.
Sandhya Bankar [Tue, 20 Sep 2016 09:07:43 +0000 (14:37 +0530)]
Staging: rtl8712: rtl871x_cmd: Use !x instead of x == NULL.

Use !x instead of x == NULL. This patch was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rtl8712: rtl8712_xmit: Use !x instead of x == NULL
Sandhya Bankar [Tue, 20 Sep 2016 09:06:17 +0000 (14:36 +0530)]
Staging: rtl8712: rtl8712_xmit: Use !x instead of x == NULL

Use !x instead of x == NULL. This patch was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rtl8712: rtl8712_recv: Use !x instead of x == NULL
Sandhya Bankar [Tue, 20 Sep 2016 09:04:36 +0000 (14:34 +0530)]
Staging: rtl8712: rtl8712_recv: Use !x instead of x == NULL

Use !x instead of x == NULL. This patch was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rtl8712: rtl8712_efuse: Use !x instead of x == NULL.
Sandhya Bankar [Tue, 20 Sep 2016 09:01:50 +0000 (14:31 +0530)]
Staging: rtl8712: rtl8712_efuse: Use !x instead of x == NULL.

Use !x instead of x == NULL. This patch was found by checkpatch.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192e: Insert blank line after function declaration
Namrata A Shettar [Mon, 19 Sep 2016 14:57:56 +0000 (20:27 +0530)]
staging: rtl8192e: Insert blank line after function declaration

Insert blank line after function declaration to resolve checkpatch
issue.

Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192e: Add space around binary operator '+'
Namrata A Shettar [Mon, 19 Sep 2016 14:57:46 +0000 (20:27 +0530)]
staging: rtl8192e: Add space around binary operator '+'

Add space around binary operator '+' to resolve checkpatch issue.

Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192e: Remove unnecessary blank lines
Namrata A Shettar [Mon, 19 Sep 2016 14:57:37 +0000 (20:27 +0530)]
staging: rtl8192e: Remove unnecessary blank lines

Remove unneccessary blank lines to resolve checkpatch issue.

Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192e: Add space around '+'
Namrata A Shettar [Mon, 19 Sep 2016 14:57:26 +0000 (20:27 +0530)]
staging: rtl8192e: Add space around '+'

Add space around '+' to resolve checkpatch issue.

Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rtl8192u: Remove useless type conversion
Bhumika Goyal [Sun, 18 Sep 2016 12:26:24 +0000 (17:56 +0530)]
Staging: rtl8192u: Remove useless type conversion

Some type conversions like casting a pointer to a pointer of same type,
casting to the original type using addressof(&) operator etc. are not
needed. Therefore, remove them. Done using coccinelle:

@@
type t;
t *p;
t a;
@@
(
- (t)(a)
+ a
|
- (t *)(p)
+ p
|
- (t *)(&a)
+ &a
)

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192u: r8192U_core: fix checkpatch permission warnings
Xavier Roumegue [Mon, 19 Sep 2016 12:49:24 +0000 (14:49 +0200)]
staging: rtl8192u: r8192U_core: fix checkpatch permission warnings

Fix the following warnings:
Symbolic permissions are not preferred. Consider using octal permissions.

Signed-off-by: Xavier Roumegue <xroumegue@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: r8188eu: remove GET_HAL_DATA macro
Ivan Safonov [Sun, 18 Sep 2016 17:28:06 +0000 (00:28 +0700)]
staging: r8188eu: remove GET_HAL_DATA macro

GET_HAL_DATA replaced by its definition.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: r8188eu: remove GET_RF_TYPE macro
Ivan Safonov [Sun, 18 Sep 2016 17:27:43 +0000 (00:27 +0700)]
staging: r8188eu: remove GET_RF_TYPE macro

This macro does not used.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: r8188eu: set correct type for HalData member of adapter structure
Ivan Safonov [Sun, 18 Sep 2016 17:27:32 +0000 (00:27 +0700)]
staging: r8188eu: set correct type for HalData member of adapter structure

To avoid unnecessary typecast.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: r8188eu: remove HW_VAR_DM_FLAG member of hw_variables enumeration
Ivan Safonov [Sun, 18 Sep 2016 17:27:16 +0000 (00:27 +0700)]
staging: r8188eu: remove HW_VAR_DM_FLAG member of hw_variables enumeration

rtw_hal_set_hwreg and rtw_hal_get_hwreg does not used
with HW_VAR_DM_FLAG parameter.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: r8188eu: remove usb_hal.h
Ivan Safonov [Sun, 18 Sep 2016 17:26:29 +0000 (00:26 +0700)]
staging: r8188eu: remove usb_hal.h

usb_hal.h is empty.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: r8188eu: remove rtl8188eu_set_hal_ops function
Ivan Safonov [Sun, 18 Sep 2016 17:26:16 +0000 (00:26 +0700)]
staging: r8188eu: remove rtl8188eu_set_hal_ops function

rtl8188eu_set_hal_ops only allocates
HalData member of adapter structure.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: r8188eu: replace N_BYTE_ALIGMENT macro with PTR_ALIGN
Ivan Safonov [Sun, 18 Sep 2016 17:25:40 +0000 (00:25 +0700)]
staging: r8188eu: replace N_BYTE_ALIGMENT macro with PTR_ALIGN

PTR_ALIGN is a bit shorter than N_BYTE_ALIGMENT.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: r8188eu: delete rtw_usb_bulk_size_boundary function
Ivan Safonov [Sun, 18 Sep 2016 17:25:25 +0000 (00:25 +0700)]
staging: r8188eu: delete rtw_usb_bulk_size_boundary function

This function does not used.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: r8188eu: remove pkt_hdrlen member of pkt_attrib structure
Ivan Safonov [Sun, 18 Sep 2016 17:24:54 +0000 (00:24 +0700)]
staging: r8188eu: remove pkt_hdrlen member of pkt_attrib structure

pkt_hdrlen has a constant value.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: r8188eu: remove xmitframe_direct function
Ivan Safonov [Sun, 18 Sep 2016 17:24:01 +0000 (00:24 +0700)]
staging: r8188eu: remove xmitframe_direct function

xmitframe_direct is a simple wrapper around
rtw_xmitframe_coalesce and rtw_dump_xframe functions.
Many wrappers complicates code reading.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: r8188eu: change last argument type of the usb_write_port function
Ivan Safonov [Sun, 18 Sep 2016 17:23:42 +0000 (00:23 +0700)]
staging: r8188eu: change last argument type of the usb_write_port function

usb_write_port writes only xmit_buf object data to device.
In addition, an appropriate name for this argument is used.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: Merge assignment with return
Rehas Sachdeva [Tue, 20 Sep 2016 07:48:40 +0000 (13:18 +0530)]
staging: wilc1000: Merge assignment with return

Instead of storing the return value into a variable and then returning it, we
can club the two into a single return statement. This change was made using
the following semantic patch by Coccinelle:

@@
local idexpression ret;
expression e;
@@

-ret =
+return
     e;
-return ret;

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: move parahotplug_request_list and related lock
David Kershner [Mon, 19 Sep 2016 21:09:37 +0000 (17:09 -0400)]
staging: unisys: visorbus: move parahotplug_request_list and related lock

parahotplug_request_list and parahotplug_request_list_lock should be
defined closer to where we are actually using them.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: remove fix_vbus_dev_info prototype
David Kershner [Mon, 19 Sep 2016 21:09:36 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove fix_vbus_dev_info prototype

Move the visordriver_probe_device and visorbus_register_visor_driver
functions lower in the file to get rid of the function prototype
fix_vbus_dev_info.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus move visorbus_type to remove prototypes
David Kershner [Mon, 19 Sep 2016 21:09:35 +0000 (17:09 -0400)]
staging: unisys: visorbus move visorbus_type to remove prototypes

Move the struct visorbus_type down in the file to get rid of
the function prototypes visorbus_uevent and visorbus_match.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: move deviceenabled/disabled store functions
David Kershner [Mon, 19 Sep 2016 21:09:34 +0000 (17:09 -0400)]
staging: unisys: visorbus: move deviceenabled/disabled store functions

Move the deviceenabled/devicedisabled store functions so that
function prototypes can be removed.

This caused us to move several of the structures farther
down in the file as well.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: move the remaining_steps_show/store functions
David Kershner [Mon, 19 Sep 2016 21:09:33 +0000 (17:09 -0400)]
staging: unisys: visorbus: move the remaining_steps_show/store functions

Moving the remaining_steps functions allows us to get rid of an unneeded
prototype.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: move textid store and show functions
David Kershner [Mon, 19 Sep 2016 21:09:32 +0000 (17:09 -0400)]
staging: unisys: visorbus: move textid store and show functions

The textid store and show functions were moved to allow us to remove
the function prototypes.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: move error store/show functions
David Kershner [Mon, 19 Sep 2016 21:09:31 +0000 (17:09 -0400)]
staging: unisys: visorbus: move error store/show functions

Move the show and store functions for the error DEV_ATTR_RW so that the
function prototypes can be removed.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: remove parser_done prototype
David Kershner [Mon, 19 Sep 2016 21:09:28 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove parser_done prototype

Remove the unneeded prototype parser_done.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: remove controlvm_respond_physdev_changestate
David Kershner [Mon, 19 Sep 2016 21:09:27 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove controlvm_respond_physdev_changestate

Remove the unneeded prototype declaration for function
controlvm_respond_physdev_changestate.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: move parser_init_byte_stream
David Kershner [Mon, 19 Sep 2016 21:09:22 +0000 (17:09 -0400)]
staging: unisys: visorbus: move parser_init_byte_stream

The function parser_init_byte_stream needs to be moved lower in the file to
avoid extraneous function prototypes.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: move boottotool
David Kershner [Mon, 19 Sep 2016 21:09:30 +0000 (17:09 -0400)]
staging: unisys: visorbus: move boottotool

Move the boottotool show and store functions so the function
prototypes can be removed.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: move toolaction functions to remove prototypes
David Kershner [Mon, 19 Sep 2016 21:09:29 +0000 (17:09 -0400)]
staging: unisys: visorbus: move toolaction functions to remove prototypes

The toolchain functions show and store needed to be moved so the prototypes
were no longer needed.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: remove controlvm_respond_chipset_init prototype
David Kershner [Mon, 19 Sep 2016 21:09:26 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove controlvm_respond_chipset_init prototype

Remove the unneeded controlvm_respond_chipset_init prototype by
moving the functions controlvm_init_response and
controlvm_respond_chipset_init up in the file.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: remove prototype controlvm_respond
David Kershner [Mon, 19 Sep 2016 21:09:25 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove prototype controlvm_respond

Remove the unneeded prototype for controlvm_respond.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: move parahotplug_process_list
David Kershner [Mon, 19 Sep 2016 21:09:24 +0000 (17:09 -0400)]
staging: unisys: visorbus: move parahotplug_process_list

The function parahotplug_process_list needs to be moved lower in the file
to avoid extraneous function prototypes.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: move read_controlvm_event
David Kershner [Mon, 19 Sep 2016 21:09:23 +0000 (17:09 -0400)]
staging: unisys: visorbus: move read_controlvm_event

The function read_controlvm_event needs to be moved lower in the file
to avoid extraneous function prototypes.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: move handle_command
David Kershner [Mon, 19 Sep 2016 21:09:21 +0000 (17:09 -0400)]
staging: unisys: visorbus: move handle_command

Handle_command gets moved lower in the file to avoid the need for
extraneous function prototypes.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>