autotools: build both a shared and static liblxc

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Serge Hallyn <serge@hallyn.com>
Cc: Tycho Andersen <tycho@tycho.ws>

Merge pull request #2451 from brauner/2018-07-06/bugfixes

bugfixes

tree-wide: set MSG_NOSIGNAL

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: declare int array const

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: refactor match_stdfds()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2450 from brauner/2018-07-05/use_mknod

conf: use mknod() to create dummy mount targets

terminal: don't garble output

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: use mknod() to create dummy mount targets

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2446 from brauner/2018-07-02/log_prefix

Logging and cgroup fixes

conf: use mknod() to create dummy mount target

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: safely retrieve path of slave device

openpty() is a horrible function that uses strcpy() into the char *name
argument if name != NULL. We can't rely on the path being sane in all cases so
let's split out the name retrieval to ttyname_r().

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: use fd_cloexec()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgfsng: respect lxc.cgroup.use

If lxc.cgroup.use is specified then only those controllers listed in there will
be used others will be skipped.

Closes #2447.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: remove is_crucial_cgroup_subsystem()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2448 from 2xsec/bugfix

log: remove the trailing .

log: remove the trailing .

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

log: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: remove unneeded log prefixes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2445 from 2xsec/bugfix

tests: cleanup source codes.

tests: cleanup state_server.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup startone.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup snapshot.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup shutdowntest.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup shortlived.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup saveconfig.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup reboot.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: clenaup may_control.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup lxcpath.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup lxc_raw_clone.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup lxc-test-utils.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup locktests.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup list.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup getkeys.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup get_item.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup device_add_remove.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup destroytest.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup criu_check_feature.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup createtest.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup containertests.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup console.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup config_jump_table.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup concurrent.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup clonetest.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup api_reboot.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2444 from 2xsec/bugfix

utils: move recursive_destroy() from cfgsng to utils.

sync: modify error string

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

utils: move recursive_destroy() from cfgsng to utils.

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2441 from 2xsec/coverity

coverity: #1425816

coverity: #1425816

Explicit null dereferenced

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2440 from brauner/2018-06-30/console_fixes

terminal: security fixes

tests: remove duplicate file_exists() definition

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

attach: do not make terminal raw

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

CODING_STYLE: add section about using strlcat()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: delete terminal on error

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

terminal: set FD_CLOEXEC on pty file descriptors

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>

utils: add fd_cloexec()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>

terminal: safely retrieve path of slave device

openpty() is a horrible function that uses strcpy() into the char *name
argument if name != NULL. We can't rely on the path being sane in all cases so
let's split out the name retrieval to ttyname_r().

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: simplify lxc_setup_dev_console()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2437 from 2xsec/bugfix

tools: share internal API symbols

tools: lxc-wait: remove the trailing .

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-top: fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-start: remove the trailing .

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-snapshot: fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-device: remove the trailing . & fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-destroy: remove the trailing .

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-create: remove the trailing . & fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-copy: remove the trailing . & fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-config: fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-checkpoint: remove the trailing .

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-autostart: remove the trailing . & fix coding style of strncmp

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: remote tool_list, tool_utils

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: arguments: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-monitor: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-create: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-snapshot: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-checkpoint: fix log name

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-checkpoint: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-unshare: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-top: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-copy: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-execute: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-device: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-destroy: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-console: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-config: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-ls: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-info: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

utils: code cleanups

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-autostart: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2438 from brauner/2018-06-29/linux-v4.18

autodev: adapt to changes in Linux 4.18

autodev: adapt to changes in Linux 4.18

Starting with commit
55956b59df33 ("vfs: Allow userns root to call mknod on owned filesystems.")
Linux will allow mknod() in user namespaces for userns root if CAP_MKNOD is
available.
However, these device nodes are useless since

static struct super_block *alloc_super(struct file_system_type *type, int flags,
                                       struct user_namespace *user_ns)
{
        /* <snip> */

        if (s->s_user_ns != &init_user_ns)
                s->s_iflags |= SB_I_NODEV;

        /* <snip> */
}

will set the SB_I_NODEV flag on the filesystem. When a device node created in
non-init userns is open()ed the call chain will hit:

bool may_open_dev(const struct path *path)
{
        return !(path->mnt->mnt_flags & MNT_NODEV) &&
                !(path->mnt->mnt_sb->s_iflags & SB_I_NODEV);
}

which will cause an EPERM because the device node is located on an fs
owned by non-init-userns and thus doesn't grant access to device nodes due to
SB_I_NODEV.

The solution is straightforward. Unless you're real root you should bind-mount
device nodes.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tools: lxc-attach: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-cgroup: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-wait: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-unfreeze: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-freeze: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-stop: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-start: share internal API symbols

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2434 from 2xsec/bugfix

tools: fix quiet option is not working

tools: cgroup, freeze, unfreeze, wait: change fprintf => lxc_error

Signed-off-by: 2xsec <dh48.jeong@samsung.com>