]> git.proxmox.com Git - mirror_lxc.git/log
mirror_lxc.git
3 years agorexec: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:45:14 +0000 (10:45 +0100)]
rexec: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agonetwork: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:44:38 +0000 (10:44 +0100)]
network: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agomount_utils: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:42:22 +0000 (10:42 +0100)]
mount_utils: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agomonitor: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:41:52 +0000 (10:41 +0100)]
monitor: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agolxclock: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:40:56 +0000 (10:40 +0100)]
lxclock: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agolxccontainer: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:40:00 +0000 (10:40 +0100)]
lxccontainer: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agolog: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:32:22 +0000 (10:32 +0100)]
log: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agofile_utils: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:30:38 +0000 (10:30 +0100)]
file_utils: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocriu: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:29:59 +0000 (10:29 +0100)]
criu: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconfile_utils: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:28:07 +0000 (10:28 +0100)]
confile_utils: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconfile: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:27:06 +0000 (10:27 +0100)]
confile: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:24:18 +0000 (10:24 +0100)]
conf: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocommands_utils: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:18:41 +0000 (10:18 +0100)]
commands_utils: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoattach: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:16:34 +0000 (10:16 +0100)]
attach: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: convert to strnprintf()
Christian Brauner [Thu, 11 Feb 2021 09:15:15 +0000 (10:15 +0100)]
cgroups: convert to strnprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agostring_utils: add wrapper for snprintf()
Christian Brauner [Thu, 11 Feb 2021 09:14:34 +0000 (10:14 +0100)]
string_utils: add wrapper for snprintf()

This let's us avoid the tedious

if (ret < 0 || (size_t)ret >= sizeof(buf))

style of error checking.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoMerge pull request #3664 from brauner/2021-02-10/fixes
Stéphane Graber [Wed, 10 Feb 2021 20:52:59 +0000 (15:52 -0500)]
Merge pull request #3664 from brauner/2021-02-10/fixes

cgroups: fixes

3 years agocgroups: log container process entering
Christian Brauner [Wed, 10 Feb 2021 19:18:37 +0000 (20:18 +0100)]
cgroups: log container process entering

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: log monitor and transient process entering
Christian Brauner [Wed, 10 Feb 2021 19:17:32 +0000 (20:17 +0100)]
cgroups: log monitor and transient process entering

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: do not return early when entering monitor cgroups
Christian Brauner [Wed, 10 Feb 2021 19:15:48 +0000 (20:15 +0100)]
cgroups: do not return early when entering monitor cgroups

This will happen when restoring a container via criu.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: use brackets to have clear semantics for flags checking
Christian Brauner [Wed, 10 Feb 2021 19:14:38 +0000 (20:14 +0100)]
cgroups: use brackets to have clear semantics for flags checking

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoMerge pull request #3663 from brauner/2021-02-10/fixes
Stéphane Graber [Wed, 10 Feb 2021 18:41:07 +0000 (13:41 -0500)]
Merge pull request #3663 from brauner/2021-02-10/fixes

criu: fixes

3 years agocriu: handle new cgroup layout
Christian Brauner [Wed, 10 Feb 2021 12:21:25 +0000 (13:21 +0100)]
criu: handle new cgroup layout

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocriu: lxc_init() already initializes cgroups
Christian Brauner [Wed, 10 Feb 2021 12:12:47 +0000 (13:12 +0100)]
criu: lxc_init() already initializes cgroups

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocriu: warn about cgroup hierarchies without controllers
Christian Brauner [Wed, 10 Feb 2021 12:03:06 +0000 (13:03 +0100)]
criu: warn about cgroup hierarchies without controllers

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocriu: rework init pid retrieval
Christian Brauner [Wed, 10 Feb 2021 11:50:20 +0000 (12:50 +0100)]
criu: rework init pid retrieval

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocriu: use cleanup macro when parsing mount data
Christian Brauner [Wed, 10 Feb 2021 11:46:08 +0000 (12:46 +0100)]
criu: use cleanup macro when parsing mount data

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocriu: use cleanup macro
Christian Brauner [Wed, 10 Feb 2021 11:45:22 +0000 (12:45 +0100)]
criu: use cleanup macro

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocriu: move logging under lxc_log_trace()
Christian Brauner [Wed, 10 Feb 2021 11:39:23 +0000 (12:39 +0100)]
criu: move logging under lxc_log_trace()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocriu: massage exec_criu()
Christian Brauner [Wed, 10 Feb 2021 11:27:26 +0000 (12:27 +0100)]
criu: massage exec_criu()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocriu: mark cgroups methods specific to criu
Christian Brauner [Wed, 10 Feb 2021 10:11:45 +0000 (11:11 +0100)]
criu: mark cgroups methods specific to criu

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: fix memory leak
Christian Brauner [Wed, 10 Feb 2021 09:58:16 +0000 (10:58 +0100)]
conf: fix memory leak

Fixes: Coverity 1472848
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoMerge pull request #3661 from blenk92/iw_error_msg
Stéphane Graber [Tue, 9 Feb 2021 15:46:19 +0000 (10:46 -0500)]
Merge pull request #3661 from blenk92/iw_error_msg

network: Add error message if iw couldn't be found

3 years agoMerge pull request #3662 from brauner/2021-02-08/fixes
Stéphane Graber [Tue, 9 Feb 2021 15:07:28 +0000 (10:07 -0500)]
Merge pull request #3662 from brauner/2021-02-08/fixes

conf: expand fd-only setup codepaths

3 years agoconf: kill PATH_MAX bytes
Christian Brauner [Mon, 8 Feb 2021 19:32:56 +0000 (20:32 +0100)]
conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: kill PATH_MAX bytes
Christian Brauner [Mon, 8 Feb 2021 19:30:59 +0000 (20:30 +0100)]
conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agotests: add logging to lxc-test-unpriv
Christian Brauner [Mon, 8 Feb 2021 19:24:01 +0000 (20:24 +0100)]
tests: add logging to lxc-test-unpriv

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: fd-only tty setup
Christian Brauner [Mon, 8 Feb 2021 13:52:50 +0000 (14:52 +0100)]
conf: fd-only tty setup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agomount_utils: s/OPEN_TREE_CLONE | OPEN_TREE_CLONE/OPEN_TREE_CLONE | OPEN_TREE_CLOEXEC/g
Christian Brauner [Mon, 8 Feb 2021 13:46:08 +0000 (14:46 +0100)]
mount_utils: s/OPEN_TREE_CLONE | OPEN_TREE_CLONE/OPEN_TREE_CLONE | OPEN_TREE_CLOEXEC/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: rework rootfs pinning
Christian Brauner [Mon, 8 Feb 2021 10:24:57 +0000 (11:24 +0100)]
conf: rework rootfs pinning

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agonetwork: Add error message if iw couldn't be found
Max [Sat, 6 Feb 2021 19:13:15 +0000 (20:13 +0100)]
network: Add error message if iw couldn't be found

When iw is not installed on the host, lxc fails to move wireless devices
into a container. Unfortunately there is no real error message yet
(other than that it didn't work), so its quite unobvious what causes
this. This commit adds a error message that clearly states the
application iw is missing.

Signed-off-by: Maximilian Blenk <blenkmax@gmail.com>
3 years agoconf: kill PAT_MAX bytes
Christian Brauner [Mon, 8 Feb 2021 09:22:00 +0000 (10:22 +0100)]
conf: kill PAT_MAX bytes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: kill PATH_MAX bytes
Christian Brauner [Mon, 8 Feb 2021 09:21:18 +0000 (10:21 +0100)]
conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: don't pass struct lxc_conf
Christian Brauner [Mon, 8 Feb 2021 09:17:05 +0000 (10:17 +0100)]
conf: don't pass struct lxc_conf

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: kill PATH_MAX bytes
Christian Brauner [Mon, 8 Feb 2021 09:16:18 +0000 (10:16 +0100)]
conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: s/setup_mount()/setup_mount_fstab()/g
Christian Brauner [Mon, 8 Feb 2021 08:54:57 +0000 (09:54 +0100)]
conf: s/setup_mount()/setup_mount_fstab()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agomount_utils: add locked flag helpers
Christian Brauner [Sun, 7 Feb 2021 15:19:36 +0000 (16:19 +0100)]
mount_utils: add locked flag helpers

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoMerge pull request #3660 from brauner/2021-02-05/fixes_1
Stéphane Graber [Fri, 5 Feb 2021 22:01:39 +0000 (17:01 -0500)]
Merge pull request #3660 from brauner/2021-02-05/fixes_1

mount_utils: initialize fd

3 years agomount_utils: kill mount_filesystem()
Christian Brauner [Fri, 5 Feb 2021 20:49:51 +0000 (21:49 +0100)]
mount_utils: kill mount_filesystem()

We have way better helpers now.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoattach: switch to simple mount()
Christian Brauner [Fri, 5 Feb 2021 20:47:56 +0000 (21:47 +0100)]
attach: switch to simple mount()

At the point where we're remounging proc and sys we're in the container's
namespaces so there's no chance of escape so a simple mount() syscall will
suffice.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agomount_utils: initialize fd
Christian Brauner [Fri, 5 Feb 2021 20:21:01 +0000 (21:21 +0100)]
mount_utils: initialize fd

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoMerge pull request #3659 from brauner/2021-02-05/fixes
Stéphane Graber [Fri, 5 Feb 2021 18:40:19 +0000 (13:40 -0500)]
Merge pull request #3659 from brauner/2021-02-05/fixes

mount: extend support for the new mount api

3 years agotree-wide: make use of new_mount_api() where it makes sense
Christian Brauner [Fri, 5 Feb 2021 17:46:47 +0000 (18:46 +0100)]
tree-wide: make use of new_mount_api() where it makes sense

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agomount_utils: detect new mount api support
Christian Brauner [Fri, 5 Feb 2021 17:42:10 +0000 (18:42 +0100)]
mount_utils: detect new mount api support

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agomount_utils: kill mount_from_at()
Christian Brauner [Fri, 5 Feb 2021 16:54:19 +0000 (17:54 +0100)]
mount_utils: kill mount_from_at()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: use fd_bind_mount() in lxc_fill_autodev()
Christian Brauner [Fri, 5 Feb 2021 16:53:41 +0000 (17:53 +0100)]
conf: use fd_bind_mount() in lxc_fill_autodev()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agomount_utils: add support for bind-mounts through the new mount api
Christian Brauner [Fri, 5 Feb 2021 16:38:05 +0000 (17:38 +0100)]
mount_utils: add support for bind-mounts through the new mount api

fd_bind_mount()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agomount_utils: kill mount_at()
Christian Brauner [Fri, 5 Feb 2021 16:34:57 +0000 (17:34 +0100)]
mount_utils: kill mount_at()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: switch __cg_mount_direct() to use the new mount api
Christian Brauner [Fri, 5 Feb 2021 16:20:27 +0000 (17:20 +0100)]
cgroups: switch __cg_mount_direct() to use the new mount api

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: switch tmpfs mounting to new mount api
Christian Brauner [Fri, 5 Feb 2021 15:37:17 +0000 (16:37 +0100)]
cgroups: switch tmpfs mounting to new mount api

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: switch mount_autodev() to new mount api
Christian Brauner [Fri, 5 Feb 2021 15:36:59 +0000 (16:36 +0100)]
conf: switch mount_autodev() to new mount api

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agomount_utils: add extended helpers for new mount api
Christian Brauner [Fri, 5 Feb 2021 15:35:36 +0000 (16:35 +0100)]
mount_utils: add extended helpers for new mount api

fs_prepare()
fs_set_property()
fs_attach()
fs_mount()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agomount_utils: move mount_at() and mount_from_at() over from utils.{c,h}
Christian Brauner [Fri, 5 Feb 2021 11:34:07 +0000 (12:34 +0100)]
mount_utils: move mount_at() and mount_from_at() over from utils.{c,h}

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoMerge pull request #3657 from brauner/2021-02-05/init_groups
Christian Brauner [Fri, 5 Feb 2021 11:30:17 +0000 (12:30 +0100)]
Merge pull request #3657 from brauner/2021-02-05/init_groups

conf: implement lxc.init.groups

3 years agoconfile: make garbage groups an error
Christian Brauner [Fri, 5 Feb 2021 10:59:14 +0000 (11:59 +0100)]
confile: make garbage groups an error

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agotests: improve lxc.init.groups tests
Christian Brauner [Fri, 5 Feb 2021 10:28:08 +0000 (11:28 +0100)]
tests: improve lxc.init.groups tests

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconfile: handle appending init groups
Christian Brauner [Fri, 5 Feb 2021 10:06:24 +0000 (11:06 +0100)]
confile: handle appending init groups

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: use lxc_groups_t directly
Christian Brauner [Fri, 5 Feb 2021 10:05:58 +0000 (11:05 +0100)]
conf: use lxc_groups_t directly

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoattach_options: use size_t for lxc_groups_t
Christian Brauner [Fri, 5 Feb 2021 10:05:15 +0000 (11:05 +0100)]
attach_options: use size_t for lxc_groups_t

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoattach: use brackets around flag check
Christian Brauner [Fri, 5 Feb 2021 09:40:56 +0000 (10:40 +0100)]
attach: use brackets around flag check

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoattach_options: use standard C pointer syntax
Christian Brauner [Fri, 5 Feb 2021 09:38:27 +0000 (10:38 +0100)]
attach_options: use standard C pointer syntax

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoattach_options: initialize .groups
Christian Brauner [Fri, 5 Feb 2021 09:37:09 +0000 (10:37 +0100)]
attach_options: initialize .groups

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoattach: Add groups option to keep additional group IDs.
Ruben Jenster [Wed, 3 Feb 2021 23:37:44 +0000 (00:37 +0100)]
attach: Add groups option to keep additional group IDs.

Signed-off-by: Ruben Jenster <r.jenster@drachenfels.de>
3 years agoconfile: add lxc.init.groups to keep additional groups
Ruben Jenster [Fri, 30 Oct 2020 09:00:07 +0000 (10:00 +0100)]
confile: add lxc.init.groups to keep additional groups

Signed-off-by: Ruben Jenster <r.jenster@drachenfels.de>
3 years agoutils: rework lxc_setgroups()
Christian Brauner [Fri, 5 Feb 2021 11:07:44 +0000 (12:07 +0100)]
utils: rework lxc_setgroups()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agotree-wide: use lxc_drop_groups() instead of lxc_setgroups(0, NULL)
Christian Brauner [Fri, 5 Feb 2021 08:56:59 +0000 (09:56 +0100)]
tree-wide: use lxc_drop_groups() instead of lxc_setgroups(0, NULL)

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoutils: add lxc_drop_groups()
Christian Brauner [Fri, 5 Feb 2021 08:55:16 +0000 (09:55 +0100)]
utils: add lxc_drop_groups()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoMerge pull request #3655 from brauner/2021-02-04/fixes_1
Stéphane Graber [Thu, 4 Feb 2021 22:44:48 +0000 (17:44 -0500)]
Merge pull request #3655 from brauner/2021-02-04/fixes_1

Tiny fixes in attach and utils

3 years agoutils: check for snprintf() error
Christian Brauner [Thu, 4 Feb 2021 21:48:18 +0000 (22:48 +0100)]
utils: check for snprintf() error

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoattach: improve logging and terminology
Christian Brauner [Thu, 4 Feb 2021 21:42:58 +0000 (22:42 +0100)]
attach: improve logging and terminology

The term "intermediate process" is not very nice imho, "transient process" fits
better.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoMerge pull request #3651 from brauner/2021-02-04/fixes
Stéphane Graber [Thu, 4 Feb 2021 20:40:31 +0000 (15:40 -0500)]
Merge pull request #3651 from brauner/2021-02-04/fixes

cgroups: fix cgroup mounting

3 years agocgroups: check for correct error in __cg_unified_attach() from cgroup_attach()
Christian Brauner [Thu, 4 Feb 2021 19:27:40 +0000 (20:27 +0100)]
cgroups: check for correct error in __cg_unified_attach() from cgroup_attach()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agotree-wide: s/dfd_root_host/dfd_host/g
Christian Brauner [Thu, 4 Feb 2021 18:06:38 +0000 (19:06 +0100)]
tree-wide: s/dfd_root_host/dfd_host/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agotree-wide: s/mntpt_fd/dfd_mnt/g
Christian Brauner [Thu, 4 Feb 2021 18:05:55 +0000 (19:05 +0100)]
tree-wide: s/mntpt_fd/dfd_mnt/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agotree-wide: s/dev_mntpt_fd/dfd_dev/g
Christian Brauner [Thu, 4 Feb 2021 18:05:05 +0000 (19:05 +0100)]
tree-wide: s/dev_mntpt_fd/dfd_dev/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agosyscall_wrappers: fix PROTECT_OPEN_W macro
Christian Brauner [Thu, 4 Feb 2021 15:06:43 +0000 (16:06 +0100)]
syscall_wrappers: fix PROTECT_OPEN_W macro

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: restricted fd-only lxc_fill_autodev()
Christian Brauner [Thu, 4 Feb 2021 14:57:13 +0000 (15:57 +0100)]
conf: restricted fd-only lxc_fill_autodev()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: start stashing dfd to host's / during container setup
Christian Brauner [Thu, 4 Feb 2021 14:56:37 +0000 (15:56 +0100)]
conf: start stashing dfd to host's / during container setup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: fix lxc_setup_dev_console()
Christian Brauner [Thu, 4 Feb 2021 14:52:54 +0000 (15:52 +0100)]
conf: fix lxc_setup_dev_console()

We were printing garbage on accident.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoutils: add mount_from_at()
Christian Brauner [Thu, 4 Feb 2021 14:23:55 +0000 (15:23 +0100)]
utils: add mount_from_at()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: restrict open calls in cgroup_attach_create_leaf()
Christian Brauner [Thu, 4 Feb 2021 14:05:43 +0000 (15:05 +0100)]
cgroups: restrict open calls in cgroup_attach_create_leaf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: improve error handling and logging in cgroup_attach_leaf()
Christian Brauner [Thu, 4 Feb 2021 14:02:14 +0000 (15:02 +0100)]
cgroups: improve error handling and logging in cgroup_attach_leaf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: fix argument vetting in cgroup_attach()
Christian Brauner [Thu, 4 Feb 2021 14:01:45 +0000 (15:01 +0100)]
cgroups: fix argument vetting in cgroup_attach()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoattach: fix fallback logic when attaching to cgroups
Christian Brauner [Thu, 4 Feb 2021 14:01:09 +0000 (15:01 +0100)]
attach: fix fallback logic when attaching to cgroups

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: switch to fd-based cgroup mounting
Christian Brauner [Thu, 4 Feb 2021 13:00:18 +0000 (14:00 +0100)]
cgroups: switch to fd-based cgroup mounting

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: restricted fd-only controller mountpoint creation
Christian Brauner [Thu, 4 Feb 2021 11:50:43 +0000 (12:50 +0100)]
cgroups: restricted fd-only controller mountpoint creation

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agocgroups: fix cgroup mounting
Christian Brauner [Thu, 4 Feb 2021 10:22:26 +0000 (11:22 +0100)]
cgroups: fix cgroup mounting

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoMerge pull request #3650 from brauner/2021-02-03/fixes_1
Stéphane Graber [Wed, 3 Feb 2021 22:05:35 +0000 (17:05 -0500)]
Merge pull request #3650 from brauner/2021-02-03/fixes_1

conf: harden various mount paths

3 years agoutils: harden __safe_mount_beneath_at()
Christian Brauner [Wed, 3 Feb 2021 20:57:44 +0000 (21:57 +0100)]
utils: harden __safe_mount_beneath_at()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
3 years agoconf: refactor transient procfs mounting
Christian Brauner [Wed, 3 Feb 2021 20:31:03 +0000 (21:31 +0100)]
conf: refactor transient procfs mounting

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>