Thomas Lamprecht [Mon, 24 Jun 2019 12:52:05 +0000 (14:52 +0200)]
ui: workspace: cope better with upgrade related false positive 401 HTTP codes
While we nowadays can work much better with package upgrades relating
the cluster stack it still happens that a pve-cluster upgrade can
produce a false-positive 401 (auth failure) code for a currently
valid ticket, e.g., because a pmxcfs lock was requested but the
pmxcfs was currently not mounted due an upgrade triggered restart.
A frequent case for a few false positive 401 is also a cluster
creation, especially if not done over the web GUI.
Thus add a counter, which gets set to 0 on each successful login or
ticket renewal and gets increased on each 401 error. Only show the
logged out window if we get five or more 401 responses. While 5 may
sound a bit much one needs to remember that we always have quite a
few API call in flight (resource update store, stores from current
panel ...) and thus, if one got really auth denied it will still show
quite fast (1 to 5 seconds, depending on which panel is currently
opened). Further, the backend naturally does not allows to do
anything during this time, this has no security implications
whatsoever.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 25 Jun 2019 08:04:59 +0000 (10:04 +0200)]
pve5to6: avoid Use of uninitialized value $osd_flags in pattern match
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit b8b6003fde296c00ac1f798311e46bcc1a47ed65) Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 25 Jun 2019 07:09:24 +0000 (09:09 +0200)]
pve5to6 will never be a POD based man page, fake it for now
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit 09df2aac59f255dc48fbbca5c2299b89e6015663) Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 25 Jun 2019 07:04:07 +0000 (09:04 +0200)]
followups: pve5to6
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit f72c8f8c1c7e5bd52e98da36cc5f6464b614bae2) Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 25 Jun 2019 07:03:33 +0000 (09:03 +0200)]
bin/make: fix pod2man generation
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit 3331257e0fbc0acbcc55df338b4ca9b1d9558eba) Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
gui: vm: add CPU flag selector with tri-state awareness
This allows to select the tri-state (enforce on, enforce off, default
from QEMU+CPU Model) for each CPU flag independently.
For this a grid with a widgetcolumn is used hosting tree radio
buttons for each state. They're marked '+' for enforce on, '-' for
enforce off and the default has no label, as it isn't easy to add in
such a way that it does not confuses people and does not looks
completely ugly.. But, to help people which have a hard time figuring
out what the states mean, a fake column was added showing the current
selected state's outcome in words.
For show casing the new nice interface add all currently supported
flags from out API-
It could be worth to add some selected CPU model awareness, so that
flags are only enabled if they can make sense with the selected
model. But one should be able to add this relative easily with this
as base.
The hardcoded flag lists is not ideal, we should try to generate this
in the future, but here already qemu-server is lacking and this is
rather independent of the fact and can be done later one just fine
too.
Note that this /is/ an *advanced* feature so not visible for all
directly, while I try to document in short what a flag does it surely
isn't perfect and to short to explain all nuances, they should give
enough pointers to know if it's relevant at all (amd / intel cpu) and
for what one should research
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Revert "buildsys: use dpkg-dev makefile helpers for pkg info"
As we'd need to also cherry-pick commit b597d23d354665ddea247c3ad54ece1b84921768 to make this correct, but
it is more or less a API breakage which we cannot backport in
stable-5 so don't do that but revert this one here, bummer.
Thomas Lamprecht [Thu, 16 May 2019 08:31:00 +0000 (10:31 +0200)]
ui: FW log ratelimit: avoid access on possible undefined rate
This is an optional parameter and needs to be guarded, a simple
"truthy" check is enough, as eithers it's missing or a more complex
string (i.e., it cannot be '0' or the like)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 15 May 2019 14:02:09 +0000 (16:02 +0200)]
partially revert "api/nodes journal: add and enforce parameter conflicts"
This partially reverts commit f9b08743a5a2322427ebdce78eb84c990bae7e31
as we had some wrong assumptions about lastentries and the other
params, so just note conflicts in the description but let the tool
itself make the checks
Oguz Bektas [Wed, 15 May 2019 13:21:56 +0000 (15:21 +0200)]
fix #2185: add option to change nfs version on gui
this enables us to specify an nfs version while editing/creating an nfs
mount. it used to default to vers=3 without the ability to change it in
gui. now it supports: 3, 4, 4.1 and 4.2
it should also be possible to add further options in the future (rsize,
wsize, timeo, etc.) on this screen.
Co-Authored-by: Dominik Csapak <d.csapak@proxmox.com> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
This refactors things a bit to avoid having the same two lines in 3
places and allows the plugin to set the "guest was resumed" time
stamp at the point it really was resumed, not only once the backup
completed (see #503). Further, if a plugin prints it's own
"resumed/running after X seconds" message, it can unset the vmstop
time and thus avoid printing the message twice.
related to a fix for #503
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 13 May 2019 17:24:24 +0000 (17:24 +0000)]
fix #2197: ui: editing CDROM doesn't require VM.Config.Disk rights
A user which just has the default role PVEVMUser on a VM is able to
edit the CDROM, either to no media or if storage permissions are
available also to other ISOs, through the API. So reflect this again
for the WebUI. We could add a check for "VM.Config.CDROM", but that's
not really worth, if we keep in mind that the Ext.Caps state is
heuristically only.
Fix #482: Add timestamps to backup create task log
Adding timestamps to the log messages facilitates troubleshooting.
We only log this in the task log, as the syslog and the backup log
(stored together with the backup on the target storage) already have
date/time prefixed, so only the task log missed this info in case of
multiple backups tasks for a single job.
Thomas Lamprecht [Mon, 15 Apr 2019 13:45:18 +0000 (13:45 +0000)]
fix #263: only include node rrd stats if user has Sys.Audit
It makes sense to not give users without Sys.Audit permissions to
much information over a node and this is relatively easy and cheap to
check and enforce at those two points.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Tested-by: Oguz Bektas <o.bektas@proxmox.com>
pveceph: install ceph service print sucess message
This patch adds a success message on successful ceph.service
installation. And adds a newline to make a successful ceph package
installation more visible.
Thomas Lamprecht [Tue, 16 Apr 2019 06:08:10 +0000 (06:08 +0000)]
d/control: bump widget-toolkit version dependency
It's not that nothing would work without it, but ceph cannot be
configured via gui, and knowing that some user want to do strange
things with mixing package versions, we save us some hassle just
recording this to ensure one cannot run into this..
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
d/control: bump doc-generator build dependency version
When building a current version of pve-manager a dependency to the
documentation is missing, as it ships new references used by our
onlineHelp tooling this is required.
Thomas Lamprecht [Wed, 10 Apr 2019 13:17:47 +0000 (15:17 +0200)]
ui: dc/options: allow to edit HA shutdown policy
add some helpers handling this, can be re used for adding the
migration field, maybe we want to move this to widget-toolkits parent
ObjectGrid class, a bit cleaned up.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 10 Apr 2019 07:56:14 +0000 (09:56 +0200)]
ui: lxc: do not disable complete add resource button if no disk caps
While for now you only have elements which require the add disk
capability in the add sections it makes no sense to hide it, as it
would suggest that one can add no resource at all, and can easily
introduce a bug if we add another type of resource here, independent
of disk add cap.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
projects / pve-manager.git / log