when a vzdump script is set and the backup fails early (eg.
when exceeding the number of backups) run_hook_script()
showed an uninitialized value error trying to use
$task->{mode} which is set only after prepare() was called.
This sets $task->{mode} early, still updated later to $stop
if !$running, and changes the condition for whether
cleanup() should be called to not use $task->{mode} (which
makes no real sense anyway) to using the $cleanup hash like
the rest of the code.
Emmanuel Kasper [Thu, 18 Aug 2016 12:33:41 +0000 (14:33 +0200)]
Clear sensitive content when logging out fixes #1060
The current position inside the Workspace is saved via the StateProvider
separately thus this clearing operation do not lose the previous selection.
As a side effect by calling setContent(null) on logout we also fix the
following bug:
when logging out while the Syslog tab of the Node panel was displayed,
you had to login twice due a to a race condition in the store
load of the Syslog panel. ( The login call could complete successfully
before a backgroup store load, causing the faild store load call
to redisplay a login window)
Do not use a hardcoded Certificate Authority for https repositories
Instead we will the use the CA certificate provided by the
ca-certificates packages, which is now a mandatory depency of
pve-manager since 067d24db982be44ff64cb5eb61a3297bba6afdc9 and
pve-manager 4.2-17. This change allows us in the future to
use different CA for our https repositories.
This changed has been tested OK with the following combination:
* https repository using a StartCom certificate: works
* https repository using a Let's encrypt certificate: works
User visible changes:
* none : the new configuration file 75pveconf silently
overwrites the olderone, except if local changes were made
in which case you're presented with the traditional debian menu
(keep local/ use packager version/ diff / open a shell)
store.findRecord returns the first match, and by default
matches the beginning of the strings not the whole
without this, with multple realms with the same name, but different
tfa settings, the login window can show the tfa input box even
when the selected realm has no tfa active
Emmanuel Kasper [Mon, 1 Aug 2016 14:24:36 +0000 (16:24 +0200)]
closes #195 : hide disallowed commands in tree
When basic capabilities are missing, don't display the corresponding actions in
the tree menu.
Note that we *hide* the corresponding actions, instead of disabling by greying
out the menu command. Disabling here does not make sense, since a low privilege
user has no way to reenable the menu commands by himself.
This is mainly a usability improvement, as the real capabilities test is done in
the backend.
Both terms are rather domain specific and should not be translated.
See http://pve.proxmox.com/pipermail/pve-devel/2016-July/021975.html
for the problems of Monitor Host being wrongly translated
Set VirtIO drivers as default when using the Qemu Wizard and the OS Type is Linux
virtio-blk and virtio-net have been in the kernel since 2.6.25 released in 2008, so
it safe to assume distributions using the l26 type will have these drivers.
this is ExtJS recommended practise, follows most of our
conventions and is necessary for querying
components with Ext.ComponentQuery.query() without escaping the
dots in the component widget name.
on touch devices, the isValid function of forms trigger
a layout event, which the edit window listens to and
executes an isValid on the form -> infinite loop
we now suspend the layout before this and continue afterwards
With the new calculation $pe->{maxcpu} was used before being
initialized to zero. Moving the initialization up.
Additionally setting $pe->{cpu} to $entry->{cpu} if maxcpu
is not set seems pointless as with its factor (maxcpu)
initialized to zero it is cancelled out anyway.
ca-certificates provides the necessary root ca certificates
to connect to the PVE enterprise repositories
The package was always installed since pve-manager 3.1-13 as an indirect
'Depends:' via liblwp-protocol-https, but could have been missing in previous
versions of pve.
Adding this dependency directly makes it sures that it's available
in each PVE installs no matter what Debian packagers do.
With this package installed we no longer need to ship
our own server CA cert.
Dominik Csapak [Mon, 20 Jun 2016 10:36:01 +0000 (12:36 +0200)]
fix #1030: calculate correct cpu usage of pools
we only added the % of the vms in a pool
which lead to wrong results
e.g. having a pool with 3 vms with 4 cores each and a
cpu usage of 50% each (2 cores at 100%)
lead to :
vm1 50%
vm2 50%
vm3 50%
pool 150%
instead we new calculate the percentage for the whole pool
Dominik Csapak [Tue, 21 Jun 2016 14:20:18 +0000 (16:20 +0200)]
set focus on tree after selecting a node
this is useful when using the new search field,
or when double clicking in the search tab,
since it focuses the item in the tree and lets
the treepanel scroll to the item
Dominik Csapak [Tue, 21 Jun 2016 07:22:54 +0000 (09:22 +0200)]
add globalsearchfield
this adds a field, the globalsearchfield
its use is to search across our resources (vm,nodes,storage,pools)
quickly and from everywhere
it filters by taking each word you write, and gives
points to resources based on how often the word matches or
if it is an exact match for a field (details in source), and
sorts after this relevance number
with enter or click on an entry, you go directly to the selected
resource
also supports key up/down selecting of the entries and
toggling the search globally with ctrl+space or ctrl+shift+f
Dominik Csapak [Thu, 16 Jun 2016 10:26:03 +0000 (12:26 +0200)]
make containerviewport stateful
with this patch, the split view saves its state
in the local storage, so that users don't lose this
after a refresh or even a new browser session
(only when they change browser/workstation)
if the window resizes (or refreshes),
the left/bottom panel gets resized to a sane width/height
in case this would be bigger than the viewport
to avoid an unusable interface
Dominik Csapak [Wed, 15 Jun 2016 13:33:51 +0000 (15:33 +0200)]
remove unnecessary information on template summary
since most of the information on the summary page is
irrelevant for templates (e.g. status,ha,using memory,graphs, etc),
we only show just the information which is available and helpful
since we then have the vertical space, we move the notes panel
below the statuspanel, to allow visually more space for the description
(which makes sense for a template)
Emmanuel Kasper [Tue, 14 Jun 2016 09:41:43 +0000 (11:41 +0200)]
Add a toplevel pointer to the PVE admin guide
Since the Admin Guide is now delivered with each standard
PVE installation, link it from the support tab
Initial idea was to include the chapters list in the panel itself
but a simple link renders better because:
* linking to toplevel allows to show that pdf and epub are also
available
* the chapter list is long and would need scrolling on laptop displays
* since a click opens the documentation in another tab, table of content
and content would be in two different tabs, which is not intuitive
Dominik Csapak [Wed, 1 Jun 2016 14:17:07 +0000 (16:17 +0200)]
check if tabs exist before selecting them
when switching from a vm to a template, if you
have a tab selected which does not exists in a template
(for example console or task history) you break
the site
this patch checks if the wanted tab actually exists,
and leave it on default (the first) when it does not