config: allow system service file to set custom target path

Closes #238.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: introduce and use fopen_cached()

Closes #257.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: make fopen() calls cloexec

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxcfs: use fuse's default_permissions

Closes #128.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxcfs: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxcfs: use cleanup macro for pidfile fd

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxcfs: improve logs

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxcfs: cleanup mutex

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxcfs: replace alloca()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_cpuview: remove alloca()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cpuset_parse: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bindings: cleanup send_creds_clone_wrapper()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #336 from brauner/2020-02-27/safe_mount

support ASAN and UBSAN + bugfixes

tree-wide: fix memory leaks

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

autotools: add support for ASAN and UBSAN

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroup_utils: re-add O_NOFOLLOW

This got removed on accident.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #335 from brauner/2020-02-27/memory_stat_fix

proc_fuse: ensure struct memory_stat is properly zeroed

proc_fuse: ensure struct memory_stat is properly zeroed

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #333 from brauner/master

api_extensions: add and log api extensions

api_extensions: add and log api extensions

New features should get an entry in here:

Feb 27 15:21:54 wittgenstein lxcfs[2129877]: mount namespace: 4
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: hierarchies:
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:   0: fd:   5:
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:   1: fd:   6: name=systemd
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:   2: fd:   7: cpu,cpuacct
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:   3: fd:   8: rdma
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:   4: fd:   9: devices
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:   5: fd:  10: pids
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:   6: fd:  11: net_cls,net_prio
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:   7: fd:  12: memory
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:   8: fd:  13: perf_event
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:   9: fd:  14: blkio
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:  10: fd:  15: freezer
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:  11: fd:  16: cpuset
Feb 27 15:21:54 wittgenstein lxcfs[2129877]:  12: fd:  17: hugetlb
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: Kernel supports pidfds
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: api_extensions:
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - cgroups
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - sys_cpu_online
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - proc_cpuinfo
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - proc_diskstats
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - proc_loadavg
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - proc_meminfo
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - proc_stat
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - proc_swaps
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - proc_uptime
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - shared_pidns
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - cpuview_daemon
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - loadavg_daemon
Feb 27 15:21:54 wittgenstein lxcfs[2129877]: - pidfds

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #332 from brauner/2020-02-20/meminfo_extension

meminfo: add some more metrics

meminfo: add some more metrics

dirty/writeback  ... and so on

Closes #315.
Signed-off-by LiMing Wu <19092205@suning.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #331 from brauner/master

bugfixes

cgroup_utils: fix mounting

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc_fuse: use correct format specifier

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: introduce casting helpers

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

croups: remove unused variable

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #330 from brauner/master

bindings: cleanup various parts

tree-wide: use cleanup macros

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bindings: cleanup various parts

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #329 from brauner/master

bindings: initialize safely & compiler-based hardening

autotools: add compiler-based hardening flags which are already standard in lxc

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bindings: initialize safely

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #328 from brauner/master

lxcfs: add --pidfd option

lxcfs: add --pidfd option

This makes running lxcfs way more reliable. It is opt-in for now.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #327 from brauner/master

tree-wide: post-restructuring cleanup

tree-wide: post-restructuring cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #326 from brauner/2020-02-20/cgroup2_support_10

restructure everything

Makefile: add missing header files

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

proc: split proc virtualization into separate files

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bindings: split cgroup part of lxcfs into separate files

This was long overdue since the cgroup faking part is basically unused
at this point on most kernels.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

utils: split helpers from bindings.c into utils.{c,h}

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: add get_cgroup_fd() helper

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #325 from brauner/2020-02-20/cgroup2_support_9

cgroups: fixes and improvements

cgroups: remove unused variables

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: remove ->nrtasks method

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: move mntns fd into struct cgroup_ops

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #324 from brauner/2020-02-20/cgroup2_support_8

bindings: rework {con,de}structor

bindings: rework {con,de}structor

- Improve naming for {con,de}structor.
- Fail when we can't setup cgroups.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #323 from brauner/2020-02-20/cgroup2_support_7

bindings: port cpuview to new cgroup getters & cleanup macro expansion

bindings: use more cleanup macros

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bindings: port cpuview to new cgroup getters

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #322 from brauner/2020-02-20/cgroup2_support_5

bindings: port blkio to new cgroup getters

bindings: port blkio to new cgroup getters

cgroup2's io controller does not support most of the blkio files.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #321 from brauner/2020-02-20/cgroup2_support_4

bindings: port cpuset to new cgroup getters and implement cgroup2 sup…

bindings: introduce dot_or_empty()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bindings: port cpuset to new cgroup getters and implement cgroup2 support

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #320 from brauner/2020-02-20/cgroup2_support_3

bindings: port memory to new cgroup getters and support cgroup2

bindings: port memory to new cgroup getters and implement cgroup2 support

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bindings: rework proc meminfo helpers

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #319 from brauner/2020-02-20/cgroup2_support_2

cgroups: add getter instead of open-coded cgfs_get_value()

cgroups: add getter instead of open-coded cgfs_get_value()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #318 from brauner/2020-02-20/cgroup2_support

bindings: add infrastructure for cgroup2 support

bindings: add infrastructure for cgroup2 support

Mostly based on code I've written for liblxc.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #316 from KellenRenshaw/lp1860813

handle swap reporting better when swap accounting is enabled

bindings: Adjusts the logic for calculating SwapFree to better handle conditions where swap usage is reported to be <0.

Signed-off-by: Kellen Renshaw <kellen.renshaw@canonical.com>

Merge pull request #312 from wlm86/dev

Improve version reporting

Enhance version option

Signed-off-by: LiMing Wu <19092205@suning.com>

Add compile method to README

Signed-off-by: LiMing Wu <19092205@suning.com>

Merge pull request #308 from yinhongbo/master

fixed a problem with server stability degradation caused by cgroup dy…

use is_shared_pidns helper

Signed-off-by: Hongbo Yin <yinhongbo@bytedance.com>

bindings: handle shared pidns

Signed-off-by: Hongbo Yin <yinhongbo@bytedance.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Hongbo Yin <yinhongbo@bytedance.com>

Merge pull request #309 from yinhongbo/read_file

fix read_file second reading empty bug

fix read_file second reading empty bug

Signed-off-by: Hongbo Yin <yinhongbo@bytedance.com>

Merge pull request #307 from yinhongbo/master

fix the problem of counting the number of CPUs when using cpuset and …

fix the problem of counting the number of CPUs when using cpuset and cpuset or using cpuset alone

Changelog: format code style

Signed-off-by: Hongbo Yin <yinhongbo@bytedance.com>

Merge pull request #305 from yinhongbo/master

fix /sys/devices/system/cpu/online in cpuset not correct bug

fix /sys/devices/system/cpu/online in cpuset not correct bug

Signed-off-by: Hongbo Yin <yinhongbo@bytedance.com>

Merge pull request #303 from yinhongbo/master

fix container run pid host mode /proc/stat error log

fix container run pid host mode /proc/stat error log

Signed-off-by: Hongbo Yin <yinhongbo@bytedance.com>

Merge pull request #302 from time-river/master

macro: fix lxcfs_{error,debug,v} build error when __VA_ARGS__ is empty

macro: fix lxcfs_{error,debug,v} build error when __VA_ARGS__ is empty

Originally, the compiler complained:
  macro.h:7:25: error: expected expression before ')' token
      __func__, __VA_ARGS__);

The reason is that GCC wouldn't abandon `,` when `__VA_ARGS__` is empty.
For emaple:
  #define eprintf(format, ...) fprintf (stderr, format, __VA_ARGS__)
  eprintf("success!\n", );
       → fprintf(stderr, "success!\n", );

According to GCC doc, it's okay when adding `##` before `__VA_ARGS__`:
  #define eprintf(format, ...) fprintf (stderr, format, ##__VA_ARGS__)
  eprintf ("success!\n")
       → fprintf(stderr, "success!\n");

Signed-off-by: river <river@vvl.me>

Release LXCFS 3.1.2

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #296 from brauner/2019-07-23/swapfix

bindings: ensure that opts is non NULL

Revert "Revert "cpu: improve cpu info virtualization""

This reverts commit 39b7df424120fa9c3c5dc209b37990fed57f1efd.

Looks like this is actually fine, un-revert.

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

bindings: ensure that opts is non NULL

When the shared library is reloaded but the lxcfs binary itself will
likely not be replaced and even if will still be in-memory, i.e. the
fuse loop will not be restarted.
The code here introduced a new struct lxcfs_opts which is allocated and
gets stashed in the private_data member of the fuse file when the lxcfs
binary is first called. Now, in a scenario where the shared library is
reloaded the lxcfs binary itself won't be re-run. So now we have a
shared library that assumes there's always a valid struct lxcfs_opts
stashed in the private_data member. But there isnt'. This very likely
causes the segfaults we have seen.

Fix it by verifying a struct has been stashed.

Fixes: 7e60aa1b1540 ("option to disable swap in meminfo")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #294 from brauner/master

Revert "cpu: improve cpu info virtualization"

Revert "cpu: improve cpu info virtualization"

This reverts commit db1b32f6ff056ce713c06b9d41bcc1eadd054abd.

We had a multitude of reports saying that they hit segfaults with
current lxcfs. After a bisect and various mentions in the error reports
of corrupt cpu information this is likely the culprit: revert for now.

Link: https://github.com/lxc/lxd/issues/6000
Link: https://lists.linuxcontainers.org/pipermail/lxc-users/2019-July/014932.html
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Release LXCFS 3.1.1

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Makefile: Fix typo in file name

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Release LXCFS 3.1.0

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #293 from brauner/2019-07-18/higher_precision_uptime

bindings: enable higher precision uptime

bindings: enable higher precision uptime

I don't know for what reason anyone but care but I guess ok.

Closes #292.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #290 from BurningXFlame/master

CPU views based on quotas: several improvements

cpu: improve cpu info virtualization

This commit introduces several improvements to CPU views based on
quotas:
- fall back to cpuacct.usage_percpu if cpuacct.usage_all not exists
- correct CPU usage
- correct CPU usage in partial CPU cases when quota/period doesn't yield
  an integer

Signed-off-by: Stephen Xiang <BurningXFlame@gmail.com>
[christian.brauner@ubuntu.com: squashed commits and fixed up commit message]
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Abstract must_strcat from must_strcat_pid. Replace stringbuild with must_strcat.

Signed-off-by: Stephen Xiang <BurningXFlame@gmail.com>

Merge pull request #282 from aither64/syscpus

mount hook: mount /sys/devices/system/cpu/online

mount hook: mount /sys/devices/system/cpu/online

Signed-off-by: Jakub Skokan <jakub.skokan@havefun.cz>

Merge pull request #278 from wavezhang/master

Support /sys/devices/system/cpu/online

Merge pull request #280 from brauner/master

Revert "Merge pull request #272 from brauner/2019-02-19/compiler_base…

Revert "Merge pull request #272 from brauner/2019-02-19/compiler_based_housekeeping"

This reverts commit ac98f00cd89278e82a4cffe9075792d2070abe69, reversing
changes made to d8addb023a0e96b7d42e253703ba909bbc81dd26.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>