]> git.proxmox.com Git - pve-manager.git/log
pve-manager.git
4 years agoui: vm/usbselector: cleanup unused code
Aaron Lauterer [Thu, 26 Sep 2019 13:03:18 +0000 (15:03 +0200)]
ui: vm/usbselector: cleanup unused code

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
4 years agoui: vm/usbedit: simplify USB3 handling
Aaron Lauterer [Thu, 26 Sep 2019 13:03:17 +0000 (15:03 +0200)]
ui: vm/usbedit: simplify USB3 handling

Enable USB3 by default. There are no restrictions anymore that the speed
of the dev must match the USB3 speed. The xhci controller can deal with
USB 2 and 1 devices. USB3 devices can be plugged in a USB2 (ehci)
controller. As discussed in [0]

When using a USB device for SPICE passthrough my tests showed that USB2
devices connecting to the xhci controller work but a USB3 device passed
via Spice cannot connect to an ehci controller (no USB3 enabled).

qemu-server 6.0-9 supports USB3 also for Spice USB passthrough. See
commit 733234b [1].

All this means we can get rid of the separate handling of USB3 and non
USB3 devices and leave the decision to the user if USB3 should be
enabled or not.

[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-September/039131.html
[1]: https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=733234be04d585febd74c655d8b82d17ebf9e133

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: usbselector/usbedit: make widths a bit larger
Thomas Lamprecht [Thu, 26 Sep 2019 14:39:02 +0000 (16:39 +0200)]
ui: usbselector/usbedit: make widths a bit larger

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: usbselector: return string not false when invalid
Thomas Lamprecht [Thu, 26 Sep 2019 14:36:23 +0000 (16:36 +0200)]
ui: usbselector: return string not false when invalid

If the return value is not exact Boolean(true) this is used for
error, so false gets converted to string and shown in error tooltip,
address that

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: vm/usbedit: add gettext to label
Aaron Lauterer [Wed, 25 Sep 2019 12:30:54 +0000 (14:30 +0200)]
ui: vm/usbedit: add gettext to label

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
4 years agoui: vm/usbedit: don't use getUSBValue to avoid possible duplicate "usb3"
Thomas Lamprecht [Mon, 23 Sep 2019 15:06:21 +0000 (17:06 +0200)]
ui: vm/usbedit: don't use getUSBValue to avoid possible duplicate "usb3"

As getUSBValue() always added the "usb3" property if the selected
device was recognized as USB3. But we can now also pass such a device
as USB2 so lift this restriction - which also fixes a bug for USB3
selected devices with the USB3 checkbox set.

The solution also avoids the me.down query, which is nice too.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: vm/usbedit: code & indentation cleanup
Thomas Lamprecht [Mon, 23 Sep 2019 08:01:27 +0000 (10:01 +0200)]
ui: vm/usbedit: code & indentation cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: vm/usbedit: cleanup and refactor usb selector change
Thomas Lamprecht [Mon, 23 Sep 2019 06:42:16 +0000 (08:42 +0200)]
ui: vm/usbedit: cleanup and refactor usb selector change

split the long ternary operation into a common if/else, to make it
readable.

Also, remove the usb3field.isDisabled check as:
1. we do not disable it anywhere anymore
2. if we would, it makes sense to do this anyhow

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: vm/usbedit: use simple bind for radio button changes
Thomas Lamprecht [Mon, 23 Sep 2019 06:18:09 +0000 (08:18 +0200)]
ui: vm/usbedit: use simple bind for radio button changes

reduces code and is more expressive

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: vm/usbedit: omit usb3 changes for spice completely
Thomas Lamprecht [Mon, 23 Sep 2019 06:17:56 +0000 (08:17 +0200)]
ui: vm/usbedit: omit usb3 changes for spice completely

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agousb: Enable USB3 for Spice USB passthrough
Aaron Lauterer [Wed, 11 Sep 2019 12:43:34 +0000 (14:43 +0200)]
usb: Enable USB3 for Spice USB passthrough

Instead of having two times the check if the USB3 setting needs to be
added to the config string it is now checked at one place only.

If USB3 is checked for a non USB3 device it will be attached to the USB2
root hub of the xhci controller.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
4 years agoapi2 : network : use vtysh for frr reload instead systemd
Alexandre Derumier [Mon, 9 Sep 2019 08:22:28 +0000 (10:22 +0200)]
api2 : network : use vtysh for frr reload instead systemd

avoid extra dep on frr-pythontools and parse error messages

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
4 years agoui: Add online help reference to VM bios settings
Aaron Lauterer [Wed, 18 Sep 2019 07:42:37 +0000 (09:42 +0200)]
ui: Add online help reference to VM bios settings

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
4 years agoui: Add online help reference to VM display settings
Aaron Lauterer [Wed, 18 Sep 2019 07:42:36 +0000 (09:42 +0200)]
ui: Add online help reference to VM display settings

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
4 years agoui: power menu: add more tooltips
Thomas Lamprecht [Thu, 19 Sep 2019 12:12:33 +0000 (14:12 +0200)]
ui: power menu: add more tooltips

For reset and reboot.
Shutdown and pause is pretty self-explanatory, so omit that

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agogui: qemu: add reboot button
Dominik Csapak [Thu, 12 Sep 2019 11:37:24 +0000 (13:37 +0200)]
gui: qemu: add reboot button

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoCleanup: align backslashes in manager6 Makefile
Aaron Lauterer [Tue, 17 Sep 2019 09:35:48 +0000 (11:35 +0200)]
Cleanup: align backslashes in manager6 Makefile

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
4 years agoupdate appliance info for PMG 6.0
Thomas Lamprecht [Tue, 10 Sep 2019 09:45:25 +0000 (11:45 +0200)]
update appliance info for PMG 6.0

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agofix login window on chrome
Dominik Csapak [Fri, 6 Sep 2019 12:28:20 +0000 (14:28 +0200)]
fix login window on chrome

labelWidth: 'auto' is not valid since extjs simply
adds 'px' and sets it as width which would result in:

width: 'autopx';

which is not valid css. chrome/chromium had a change such that this now
produces the wrong height in the login bottom 'button bar'

250 should be enough for all translations and we do not have
any other element there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoapi network reload: code cleanup
Thomas Lamprecht [Thu, 5 Sep 2019 12:31:24 +0000 (14:31 +0200)]
api network reload: code cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoapi2: network reload: add frr config generation and reload
Alexandre Derumier [Wed, 4 Sep 2019 05:54:36 +0000 (07:54 +0200)]
api2: network reload: add frr config generation and reload

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
4 years agobrowser settings: move reset layout button to same row as label
Thomas Lamprecht [Wed, 4 Sep 2019 13:14:06 +0000 (15:14 +0200)]
browser settings: move reset layout button to same row as label

diff best viewed with git diff -w

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agobrowser settings: add tooltip to reset layout button
Thomas Lamprecht [Wed, 4 Sep 2019 12:30:19 +0000 (14:30 +0200)]
browser settings: add tooltip to reset layout button

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agovnc scaling: show setting in a single line
Thomas Lamprecht [Wed, 4 Sep 2019 12:30:01 +0000 (14:30 +0200)]
vnc scaling: show setting in a single line

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agovnc scaling: still fallback to old default value if not set
Thomas Lamprecht [Wed, 4 Sep 2019 11:46:55 +0000 (13:46 +0200)]
vnc scaling: still fallback to old default value if not set

as else we change behavior for those who never set the new scaling
variable, or cleared the browser local store.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoClose #2262: Add noVNC scale setting
Dominic Jäger [Tue, 3 Sep 2019 10:13:15 +0000 (12:13 +0200)]
Close #2262: Add noVNC scale setting

Add a setting to choose the scale mode of the noVNC pop-up as well as
the embedded console in the content panel to "My Settings". Having both
set to local scaling was the most important use-case for the users. One
setting for both places is the simplest solution making this possible.

The new section (fieldset) makes adding further options such as
"Local Cursor" easy.

Co-developed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
4 years agobump version to 6.0-7
Thomas Lamprecht [Tue, 3 Sep 2019 08:32:49 +0000 (10:32 +0200)]
bump version to 6.0-7

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agofollouwp whitespace/indentation cleanup
Thomas Lamprecht [Tue, 3 Sep 2019 08:31:14 +0000 (10:31 +0200)]
follouwp whitespace/indentation cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoapi2 : nodes : sdn status endpoint
Alexandre Derumier [Wed, 21 Aug 2019 03:22:40 +0000 (05:22 +0200)]
api2 : nodes : sdn status endpoint

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
4 years agoapi : cluster ressources : add sdn
Alexandre Derumier [Wed, 21 Aug 2019 03:22:39 +0000 (05:22 +0200)]
api : cluster ressources : add sdn

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
4 years agopvestatd : broadcast sdn transportzone status
Alexandre Derumier [Wed, 21 Aug 2019 03:22:38 +0000 (05:22 +0200)]
pvestatd : broadcast sdn transportzone status

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
4 years agoapi2: network reload : generate local sdn config
Alexandre Derumier [Wed, 21 Aug 2019 03:22:37 +0000 (05:22 +0200)]
api2: network reload : generate local sdn config

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
4 years agoapi2 : cluster: add sdn api endpoint
Alexandre Derumier [Wed, 21 Aug 2019 03:22:36 +0000 (05:22 +0200)]
api2 : cluster: add sdn api endpoint

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
4 years agofix typos all over the place
Thomas Lamprecht [Tue, 3 Sep 2019 05:55:32 +0000 (07:55 +0200)]
fix typos all over the place

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoapi startall guest: improve descriptions
Thomas Lamprecht [Tue, 3 Sep 2019 05:53:11 +0000 (07:53 +0200)]
api startall guest: improve descriptions

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoShow supported file types in upload file selector
Stefan Reiter [Thu, 22 Aug 2019 12:39:54 +0000 (14:39 +0200)]
Show supported file types in upload file selector

By default, all file types are shown, but the user now has the option of
filtering only by supported types in the file selector dialog.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Acked-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoui: IPRef field: allow all valid IPs, even if not in the store
Thomas Lamprecht [Fri, 30 Aug 2019 16:55:51 +0000 (18:55 +0200)]
ui: IPRef field: allow all valid IPs, even if not in the store

since commit 1ccb53ecdbd69a0e4c57a6d861da1918d3625e08 from widget
toolkit[0] we enforce by default that an entered value needs to be in
the backing data store, else the field is marked invalid.

But, for the firewall source/destination IP selector we do not care
if it's in the store, which is only loaded for convenience and to
allow selecting defined aliases/ipsets

[0]: https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commit;h=1ccb53ecdbd69a0e4c57a6d861da1918d3625e08

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoapi: fix nodes stats memory return type description
Tim Marx [Mon, 26 Aug 2019 11:13:42 +0000 (13:13 +0200)]
api: fix nodes stats memory return type description

Signed-off-by: Tim Marx <t.marx@proxmox.com>
4 years agoCPU flags: Add aes flag
Peter Keresztes Schmidt [Thu, 1 Aug 2019 17:39:27 +0000 (19:39 +0200)]
CPU flags: Add aes flag

Signed-off-by: Peter Keresztes Schmidt <peterke@sos.ethz.ch>
4 years agofix #2341: ceph: osd create: allow db/wal on partioned disks
Dominik Csapak [Thu, 22 Aug 2019 10:26:10 +0000 (12:26 +0200)]
fix #2341: ceph: osd create: allow db/wal on partioned disks

It was intended that for partitioned disks, we create one and use it.
Instead the code died always when the disk was used and not of type 'LVM'

We now check correctly the 2 cases:
* used for partitions and has gpt
* used and lvm

The remaining api call handles those two cases correctly

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agofix #2340: gui: ceph: handle 'null' versions for hosts
Dominik Csapak [Thu, 22 Aug 2019 10:26:09 +0000 (12:26 +0200)]
fix #2340: gui: ceph: handle 'null' versions for hosts

the api returns 'null' for a host that is in the crushmap, but
without actual version information, so just check for falsyness instead
of 'undefined', else we run later into javascript exceptions and no
content on the osd page

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoui: vm memory: correctly set initial maxValue for balloon
Thomas Lamprecht [Thu, 22 Aug 2019 12:08:50 +0000 (14:08 +0200)]
ui: vm memory: correctly set initial maxValue for balloon

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoapi2: dust off root API module a little bit
Thomas Lamprecht [Thu, 22 Aug 2019 12:07:45 +0000 (14:07 +0200)]
api2: dust off root API module a little bit

trailing whitespace cleanup and fix the code methods signatures (no
response anymore)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agobump version to 6.0-6
Thomas Lamprecht [Fri, 16 Aug 2019 11:10:40 +0000 (13:10 +0200)]
bump version to 6.0-6

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoDelete "exclude" when switching a backup job to pool mode
Stefan Reiter [Wed, 14 Aug 2019 13:36:27 +0000 (15:36 +0200)]
Delete "exclude" when switching a backup job to pool mode

If you updated a job in "exclude" mode with some VMIDs specified to "pool" mode,
the backup job would retain the "exclude" section and thus not back up all VMs.

The GUI misrepresents this, showing that all VMs will be backed up or
straight up break and show "exclude" mode again, with the backend still
being on "pool" - to prevent this, we always delete a jobs "exclude" list
when it's switched to "pool".

Co-authored-by: Tim Marx <t.marx@proxmox.com>
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
4 years agoCode cleanup in Backup
Stefan Reiter [Mon, 12 Aug 2019 12:50:08 +0000 (14:50 +0200)]
Code cleanup in Backup

Whitespace removal and consolidating VZDump's job id format into a
local variable.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
4 years agofix #1594: add "Run now" button to cluster backup page
Stefan Reiter [Mon, 12 Aug 2019 12:50:06 +0000 (14:50 +0200)]
fix #1594: add "Run now" button to cluster backup page

Iterate all (online) nodes client-side and call vzdump with the correct
parameters (according to the job selected) for each one.

Then, show a progress bar in a non-closeable modal-dialog, to ensure the
user stays on the Backup page during the /vzdump API calls. Any errors
that occurred will be displayed in a consolidated message box.

Includes a "confirm" dialog to not accidentally run a potentially large
backup job.

Curiously, the "pve-cluster-backup" data model seems to have been broken
entirely.  I'm not sure how it was working before, but the changes in
this patch need it fixed, so include that as well (use "mode" instead of
individual flags + "compress" is not a boolean).

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
4 years agofix #1594: allow skipping VMIDs on other nodes from API
Stefan Reiter [Mon, 12 Aug 2019 12:50:07 +0000 (14:50 +0200)]
fix #1594: allow skipping VMIDs on other nodes from API

This was previously gated to CLI only, but it causes a vzdump job
started with the newly introduced "Run Now" button to fail if it
includes VMIDs on other nodes.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
4 years agod/control: bump version of widget toolkit dependency
Thomas Lamprecht [Tue, 13 Aug 2019 14:14:15 +0000 (16:14 +0200)]
d/control: bump version of widget toolkit dependency

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoadd the css/images from proxmox widget toolkit
Dominik Csapak [Wed, 24 Jul 2019 07:21:13 +0000 (09:21 +0200)]
add the css/images from proxmox widget toolkit

add the dirs to the proxy and the css file to the index template

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agogui: fix html entities in system report file
Dominik Csapak [Thu, 8 Aug 2019 12:28:55 +0000 (14:28 +0200)]
gui: fix html entities in system report file

since the content of the window is encoded with 'Ext.htmlEncode'
we have to decode it with 'Ext.String.htmlDecode' (Ext.htmlDecode is
a deprecated alias for it) before downloading the file

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agofix #2314: remove GZIP env var
Stefan Reiter [Wed, 7 Aug 2019 12:12:10 +0000 (14:12 +0200)]
fix #2314: remove GZIP env var

...and replace instead with command line argument.
Avoids a deprecation warning.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
4 years agogui: ceph wizard: fix typo
Dominik Csapak [Thu, 25 Jul 2019 14:47:22 +0000 (16:47 +0200)]
gui: ceph wizard: fix typo

s/Coniguration/Configuration/

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoFix #582: Add default delay for backups
Dominic Jäger [Mon, 15 Jul 2019 10:28:18 +0000 (12:28 +0200)]
Fix #582: Add default delay for backups

A default of 5 seems like a reasonable delay for removing backups from
the GUI.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
4 years agoui login: followup: add some hints to the 595 login error message
Thomas Lamprecht [Wed, 24 Jul 2019 16:32:56 +0000 (18:32 +0200)]
ui login: followup: add some hints to the 595 login error message

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: login: do not show connection failure as login failure
Oguz Bektas [Wed, 24 Jul 2019 15:46:20 +0000 (17:46 +0200)]
ui: login: do not show connection failure as login failure

In case pvedaemon, pveproxy is not running or we get somehow else a
595 response (connection failure), we want to tell this to the user,
since "Login failed" doesn't help.

Handle all connection failures, leave the rest the same. We could go
into more detail (CONNECT_FAILURE, CLIENT_INVALID, LOAD_FAILURE and
SERVER_INVALID), but i didn't see any reason to make all these
distinctions now.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
4 years agoui: vm/Hardware: do not depent mapping of cdrom, cloudinit, .. on the CSS class
Thomas Lamprecht [Wed, 24 Jul 2019 16:05:59 +0000 (18:05 +0200)]
ui: vm/Hardware: do not depent mapping of cdrom, cloudinit, .. on the CSS class

This was pretty brittle to begin with, on should not attach logic to
CSS class names or the like, if possible.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: vm/Hardware: convert more icons from bitmap to font awesome
Thomas Lamprecht [Wed, 24 Jul 2019 08:48:15 +0000 (10:48 +0200)]
ui: vm/Hardware: convert more icons from bitmap to font awesome

since commit 03558174ef4f15f542a61584013a195481188e7f we can use the
Font Awesome icons without them being shown in the remove dialog, so
convert more to them - they are vectors and look a bit better.

Also ensure that all icons are rendered as fixed width, with fa-fw

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years ago(re)bump version to 6.0-5
Thomas Lamprecht [Tue, 23 Jul 2019 17:18:54 +0000 (19:18 +0200)]
(re)bump version to 6.0-5

The other commit was pushed out by slight mistake but not shipped,
so re-bumped the date, but with same version (commid hash is shipped
anyway)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: vm/HW: use more font awesome icons and fix color
Thomas Lamprecht [Tue, 23 Jul 2019 17:18:15 +0000 (19:18 +0200)]
ui: vm/HW: use more font awesome icons and fix color

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agopveAudioInputPanel: comment out onlineHelp doc reference for now
Thomas Lamprecht [Tue, 23 Jul 2019 17:03:50 +0000 (19:03 +0200)]
pveAudioInputPanel: comment out onlineHelp doc reference for now

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoAdd audio device to HardwareView
Aaron Lauterer [Fri, 19 Jul 2019 13:32:21 +0000 (15:32 +0200)]
Add audio device to HardwareView

Adds the following:

* Menu entry to create a new audio device
  only clickable if:
    * permissions are there
    * no audio device exists
* listing in the hardwarew view

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
4 years agoAdd edit dialog for audio device
Aaron Lauterer [Fri, 19 Jul 2019 13:32:20 +0000 (15:32 +0200)]
Add edit dialog for audio device

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
4 years agobump version to 6.0-5
Thomas Lamprecht [Tue, 23 Jul 2019 15:35:09 +0000 (17:35 +0200)]
bump version to 6.0-5

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoInclude Windows Server 2019 in OS-Type list
Stefan Reiter [Tue, 23 Jul 2019 11:41:30 +0000 (13:41 +0200)]
Include Windows Server 2019 in OS-Type list

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
4 years agoAdd hv-tlbflush and hv-evmcs as optional flags
Stefan Reiter [Tue, 23 Jul 2019 11:41:29 +0000 (13:41 +0200)]
Add hv-tlbflush and hv-evmcs as optional flags

since they have both been removed as automatic hyper-v flags.

hv-evmcs description intentionally does not contain a mention of Windows, since
it works for Linux guests as well.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
4 years agoceph: add perl flag GET and PUT call
Thomas Lamprecht [Tue, 23 Jul 2019 14:33:58 +0000 (16:33 +0200)]
ceph: add perl flag GET and PUT call

use PUT for setting or unsetting, as POST/DELETE (like the old node
specific API used) makes no sense. One does not creates or deletes
the flag, they are always here. One just updates their value

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoceph: move flag API endpoints to node-agnostic /cluster/ceph path
Thomas Lamprecht [Tue, 23 Jul 2019 14:28:44 +0000 (16:28 +0200)]
ceph: move flag API endpoints to node-agnostic /cluster/ceph path

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoceph: move possible_flags to Ceph::Tools for intra-module reuse
Thomas Lamprecht [Tue, 23 Jul 2019 13:47:37 +0000 (15:47 +0200)]
ceph: move possible_flags to Ceph::Tools for intra-module reuse

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoapi/cluster: move ceph calls into sub- directory/module
Thomas Lamprecht [Tue, 23 Jul 2019 13:28:18 +0000 (15:28 +0200)]
api/cluster: move ceph calls into sub- directory/module

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agocluster api: group and sort module use
Thomas Lamprecht [Tue, 23 Jul 2019 13:24:58 +0000 (15:24 +0200)]
cluster api: group and sort module use

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoremove unused ext-pve.css
Thomas Lamprecht [Tue, 23 Jul 2019 12:27:52 +0000 (14:27 +0200)]
remove unused ext-pve.css

not used since commit 5783c7f4ddbeeddb7038f40c94908b0f3a6b5fa7 from
2016...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoceph flags: rename flags2 to flag before public release
Thomas Lamprecht [Tue, 23 Jul 2019 11:59:44 +0000 (13:59 +0200)]
ceph flags: rename flags2 to flag before public release

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: ceph/osd: add a real fix for the window-not-centered issue
Thomas Lamprecht [Tue, 23 Jul 2019 11:47:36 +0000 (13:47 +0200)]
ui: ceph/osd: add a real fix for the window-not-centered issue

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: ceph/flags: ensure window is vertically centered with a hack
Thomas Lamprecht [Tue, 23 Jul 2019 11:00:51 +0000 (13:00 +0200)]
ui: ceph/flags: ensure window is vertically centered with a hack

and some small changes of col width and missing semicolon

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: ceph/flags: commit changes into flag store to avoid having dirty rows
Thomas Lamprecht [Tue, 23 Jul 2019 11:00:02 +0000 (13:00 +0200)]
ui: ceph/flags: commit changes into flag store to avoid having dirty rows

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: ceph/flags: rename 'Set Flags' to 'Manage Global Flags'
Thomas Lamprecht [Tue, 23 Jul 2019 10:58:15 +0000 (12:58 +0200)]
ui: ceph/flags: rename 'Set Flags' to 'Manage Global Flags'

as one can also unset, not only set them, further the scope should be
made a bit more clear, "Cluster could have worked too"

Additionally specify that we mean the "OSD Flags" in the window
title (it's a bit to long for the button)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoapi/ceph: followup: refactor out getting the current set flags
Thomas Lamprecht [Tue, 23 Jul 2019 10:54:11 +0000 (12:54 +0200)]
api/ceph: followup: refactor out getting the current set flags

Add a new private helper which just does that for us, to avoid having
the same, or multiple implementations doing the same thing.

Allow to pass the $rados for sharing the same connection but also
just create it else for convenience

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agogui: ceph: convert 'set noout' button to 'set flags'
Dominik Csapak [Tue, 23 Jul 2019 07:52:29 +0000 (09:52 +0200)]
gui: ceph: convert 'set noout' button to 'set flags'

by using the new CephSetFlags EditWindow

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agogui: ceph: add a ceph flag EditWindow
Dominik Csapak [Tue, 23 Jul 2019 07:52:28 +0000 (09:52 +0200)]
gui: ceph: add a ceph flag EditWindow

this simply shows a grid with the available flags of the backend,
with a checkbox indicating the status

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoceph: set/unset flag: remove unused variable
Dominik Csapak [Tue, 23 Jul 2019 07:52:27 +0000 (09:52 +0200)]
ceph: set/unset flag: remove unused variable

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoceph: add PUT 'flags' api call
Dominik Csapak [Tue, 23 Jul 2019 07:52:26 +0000 (09:52 +0200)]
ceph: add PUT 'flags' api call

this api call can set multiple flags at once, but does this in a
worker since this can take quiet some time

also we only set/unset flags that are not already set/unset (respectively)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoceph: add GET 'flags2'
Dominik Csapak [Tue, 23 Jul 2019 07:52:25 +0000 (09:52 +0200)]
ceph: add GET 'flags2'

we want a GET api call where we return all available flags with
description, but the GET 'flags' api call already returns a string
and not an array, so we cannot use that

instead, we add a new api call that returns that feature and
with e.g. pve 7 we can remove the 'flags' api call and
rename 'flags2' to 'flags'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years ago5to6: cleanup cert check and make more general
Thomas Lamprecht [Tue, 23 Jul 2019 07:46:54 +0000 (09:46 +0200)]
5to6: cleanup cert check and make more general

If we need to add other types or increases the min size this makes it
easier as it's just a schematic definition.

Also just do a pass/fail on each cert, so drop the last "summary
pass".

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agopve5to6: cert: check certificates key size
Alwin Antreich [Mon, 22 Jul 2019 15:11:40 +0000 (17:11 +0200)]
pve5to6: cert: check certificates key size

Debian Buster raised the default security level (1 -> 2) for TLS
connections.

This moves from the 80 bit security level to the 112 bit security level
and will require 2048 bit or larger RSA and DHE keys, 224 bit or larger
ECC keys, and SHA-2.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
4 years agopvenode: add public key size & type to cert info
Alwin Antreich [Mon, 22 Jul 2019 15:11:39 +0000 (17:11 +0200)]
pvenode: add public key size & type to cert info

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
4 years agogui: cert: add public key type & size to certs view
Alwin Antreich [Mon, 22 Jul 2019 15:11:37 +0000 (17:11 +0200)]
gui: cert: add public key type & size to certs view

by default the fields are hidden

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
4 years agofix #2265: enable discard for virtio-blk
Stefan Reiter [Wed, 10 Jul 2019 10:29:09 +0000 (12:29 +0200)]
fix #2265: enable discard for virtio-blk

QEMU 4.0 supports this. Guest needs to have at least Kernel 5.0 for it
to be used.

SSD emulation is still not supported AFAICT, so no change here.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
4 years agoceph: add flag hash
Dominik Csapak [Mon, 22 Jul 2019 14:08:47 +0000 (16:08 +0200)]
ceph: add flag hash

this is used to generate the paramters for the set/unset api call
and will be used for the parameters of the upcoming 'set multiple flags' call

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoceph tools: factor out frequent keyring and config init check
Thomas Lamprecht [Tue, 23 Jul 2019 05:48:45 +0000 (07:48 +0200)]
ceph tools: factor out frequent keyring and config init check

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: ceph: update text for outdated versions a bit
Thomas Lamprecht [Mon, 22 Jul 2019 14:38:15 +0000 (16:38 +0200)]
ui: ceph: update text for outdated versions a bit

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoapi/osd: opinionated code cleanup of list
Thomas Lamprecht [Mon, 22 Jul 2019 14:25:05 +0000 (16:25 +0200)]
api/osd: opinionated code cleanup of list

among others: reduce use of sub-hash as index for another hash

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agogui: ceph dashboard: improve version hints
Dominik Csapak [Fri, 19 Jul 2019 08:17:03 +0000 (10:17 +0200)]
gui: ceph dashboard: improve version hints

show the difference between a service where the host has outdated
packages, and where only the service runs an outdated version and only
needs to restart

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agogui: ceph osd: improve version hints
Dominik Csapak [Fri, 19 Jul 2019 08:17:02 +0000 (10:17 +0200)]
gui: ceph osd: improve version hints

we now traverse the whole tree for the versions and save not only
the maxversion but if we have mixed versions at all

the traversal contains code to inject the host versions into the treenodes

this way we can omit any icon in case everything is on the same level
and if not we:

* show a check at update hosts and services
* show a 'restart' symbol for osds that only need a restart
* show an 'upgrade' symbol (fa-upload) for osds/hosts that need
  a package upgrade

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agogui: ceph: add HEALTH_UPGRADE state
Dominik Csapak [Fri, 19 Jul 2019 08:17:01 +0000 (10:17 +0200)]
gui: ceph: add HEALTH_UPGRADE state

to have 2 different states for
* packages are outdated
* packages are up to date but the service runs with the old version

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoceph: osd list: add hostversions to the host nodes
Dominik Csapak [Fri, 19 Jul 2019 08:17:00 +0000 (10:17 +0200)]
ceph: osd list: add hostversions to the host nodes

we want to improve the version hints in the osd tree gui and need
the version at the host nodes

we could (and want to) workaround it in the gui to have that
info for both versions of the api call

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agopveam update: also print success
Thomas Lamprecht [Fri, 19 Jul 2019 17:34:04 +0000 (19:34 +0200)]
pveam update: also print success

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoupdate shipped aplinfo index
Thomas Lamprecht [Fri, 19 Jul 2019 17:32:49 +0000 (19:32 +0200)]
update shipped aplinfo index

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoaplinfo: make apltest a bit more flexible
Thomas Lamprecht [Fri, 19 Jul 2019 17:31:57 +0000 (19:31 +0200)]
aplinfo: make apltest a bit more flexible

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoaplinfo: update from aplinfo-pve-6.dat
Thomas Lamprecht [Fri, 19 Jul 2019 15:55:50 +0000 (17:55 +0200)]
aplinfo: update from aplinfo-pve-6.dat

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>