]>
git.proxmox.com Git - mirror_novnc.git/log
Samuel Mannehed [Wed, 20 May 2020 23:31:55 +0000 (01:31 +0200)]
Standardize on camelCase in RFB
Samuel Mannehed [Fri, 8 May 2020 20:30:20 +0000 (22:30 +0200)]
Remove unused properties and variables
The code that used these were removed in the following commits:
*
9ff86fb718477515ede2d6457f06643935d76bcd (RFB._mouse_arr)
*
bb6965f2e60c2301dd638383bdc792d1f10af942 (old_requestAnimationFrame)
*
490d471c53b1791398d6c30f0efce54925939f33 (Display._c_forceCanvas)
Samuel Mannehed [Sat, 9 May 2020 18:03:06 +0000 (20:03 +0200)]
Properly limit mouse moves to once every 17 ms
Previous attempt in
c958269 had a number of issues, this is a full
rewrite, complete with improved unit tests.
Fixes github issue #1402
Samuel Mannehed [Sun, 10 May 2020 00:05:38 +0000 (02:05 +0200)]
Stop send mouse clicks while dragging in view only
Samuel Mannehed [Wed, 20 May 2020 23:41:02 +0000 (01:41 +0200)]
Standardize on camelCase for functions in RFB
Samuel Mannehed [Wed, 20 May 2020 23:31:55 +0000 (01:31 +0200)]
Standardize on camelCase for variables in RFB
Samuel Mannehed [Fri, 8 May 2020 20:30:20 +0000 (22:30 +0200)]
Remove unused mouse_arr variable
Pierre Ossman [Tue, 5 May 2020 10:14:49 +0000 (12:14 +0200)]
Consistently close dialogs on connect/disconnect
This was done a bit arbitrarily before which could easily miss things,
end up in the wrong state and not trigger animations correctly.
This reverts commit
c12e5b2b544aff6f662c7f61f82ce40d132e14df and fixes
things in a different way.
Samuel Mannehed [Fri, 1 May 2020 18:49:49 +0000 (20:49 +0200)]
Merge pull request #1398 from novnc/compressionlevel
Add ability to set Tight compression level
Samuel Mannehed [Fri, 1 May 2020 14:14:15 +0000 (16:14 +0200)]
Add ability to set compression level
Fixes github issue #1382.
Samuel Mannehed [Fri, 1 May 2020 18:26:51 +0000 (20:26 +0200)]
Add unit tests for mouse move limit
Samuel Mannehed [Fri, 1 May 2020 17:53:36 +0000 (19:53 +0200)]
Shorten rows to max 80 chars in mouse.js
Samuel Mannehed [Fri, 1 May 2020 17:51:33 +0000 (19:51 +0200)]
Fix wording in comment
Samuel Mannehed [Fri, 1 May 2020 18:36:18 +0000 (20:36 +0200)]
Merge pull request #1352 from uklatt/master
Limit mouse move events to one every 17 mS.
Uwe Klatt [Fri, 3 Jan 2020 11:08:35 +0000 (12:08 +0100)]
Limit mouse move events to one every 17 ms
Samuel Mannehed [Fri, 1 May 2020 13:34:14 +0000 (15:34 +0200)]
Fix indentation for focus check
Samuel Mannehed [Fri, 1 May 2020 12:38:09 +0000 (14:38 +0200)]
Don't fade the control bar if it has focus
Fixes github issue #1369
Samuel Mannehed [Fri, 1 May 2020 11:30:01 +0000 (13:30 +0200)]
Hide the clipboard when not connected
Fixes github issue #1367.
Samuel Mannehed [Wed, 29 Apr 2020 16:58:04 +0000 (18:58 +0200)]
Merge pull request #1396 from iblech/patch-1
Document default setting of `focusOnClick`
Ingo Blechschmidt [Wed, 29 Apr 2020 07:36:32 +0000 (09:36 +0200)]
Document default setting of `focusOnClick`
Filip Stedronsky [Sun, 22 Mar 2020 23:59:42 +0000 (00:59 +0100)]
rfb: VeNCrypt Plain SecurityType support
This allows using TigerVNC server with PAM authentication (e.g. agains
LDAP or other extensible authentication mechanisms)
Tested with TigerVNC server (Xvnc -SecurityTypes Plain -PlainUsers '*')
Should not break anything else, this method is tried last when all
other fail.
Tested in Firefox 74 and Chromium 80
Alex Tanskanen [Thu, 12 Mar 2020 12:17:51 +0000 (13:17 +0100)]
Fix focus problem after closing the toolbar
Closing the toolbar would make the focus remain on the toolbar and
not in the session. The only way to switch focus was to click in the
session. This commit will automatically switch back focus to the session
after closing the toolbar.
Pierre Ossman [Fri, 28 Feb 2020 13:56:57 +0000 (14:56 +0100)]
Set a default value for the quality input
Pierre Ossman [Fri, 28 Feb 2020 13:52:56 +0000 (14:52 +0100)]
Add UI for quality setting
Pierre Ossman [Fri, 28 Feb 2020 12:54:36 +0000 (13:54 +0100)]
Merge branch 'quality-level' of https://github.com/eDrillingSolutions/noVNC
Andrey Trebler [Mon, 10 Feb 2020 11:44:36 +0000 (12:44 +0100)]
adds qualityLevel property to RFB class for updating JPEG quality level encoding on the fly
Niko Lehto [Mon, 24 Feb 2020 07:57:28 +0000 (08:57 +0100)]
Hide clipboard side bar button when view only mode
The clipboard side bar button serves no purpose if user uses 'View Only'
mode, this commit hides this button in those instances.
Alex Tanskanen [Thu, 20 Feb 2020 15:12:35 +0000 (16:12 +0100)]
Fix crash with too large clipboard data
If too much text is copied in the session, String.fromCharCode.apply()
would crash in Safari on macOS and Chrome on Linux. This commit fixes
this issue by avoiding apply() altogether. Also added test to cover this
issue.
Pierre Ossman [Tue, 18 Feb 2020 14:24:51 +0000 (15:24 +0100)]
Style all input types for consistent UI
At least all that the browsers will let us.
Pierre Ossman [Tue, 18 Feb 2020 08:46:10 +0000 (09:46 +0100)]
Merge branch 'clipboard_unicode' of https://github.com/CendioNiko/noVNC
Niko Lehto [Mon, 27 Jan 2020 12:49:07 +0000 (13:49 +0100)]
Add extended clipboard Pseudo-Encoding
Add extended clipboard pseudo-encoding to allow the use of unicode
characters in the clipboard.
Niko Lehto [Mon, 17 Feb 2020 09:27:51 +0000 (10:27 +0100)]
Export constants in inflate.js for easier usage
Niko Lehto [Tue, 4 Feb 2020 08:55:49 +0000 (09:55 +0100)]
Fix bug where inflate would read too much data
Niko Lehto [Mon, 3 Feb 2020 09:19:00 +0000 (10:19 +0100)]
Split api of inflate
Added ability to read data chunk wise.
Niko Lehto [Mon, 3 Feb 2020 09:04:20 +0000 (10:04 +0100)]
Handle errors from zlib/pako
Niko Lehto [Mon, 3 Feb 2020 08:57:56 +0000 (09:57 +0100)]
Move error handling to Inflate class
Every call wants this check so this should be done inside the class.
Niko Lehto [Tue, 11 Feb 2020 13:20:56 +0000 (14:20 +0100)]
Add missing copyright header for Inflator.js
Niko Lehto [Mon, 3 Feb 2020 08:53:30 +0000 (09:53 +0100)]
Remove unused inflate argument
The value true was an invalid flush argument so it was in practice
unused.
Niko Lehto [Tue, 28 Jan 2020 16:00:04 +0000 (17:00 +0100)]
Add util for unsigned and signed int. conversion
Will be used in later commit in extended clipboard handling.
Niko Lehto [Fri, 7 Feb 2020 12:23:21 +0000 (13:23 +0100)]
Add deflator helper class for deflating data
Wraps pako's deflate for easier usage.
Niko Lehto [Tue, 28 Jan 2020 09:01:54 +0000 (10:01 +0100)]
Make clipBoardPasteFrom() test more specific
Don't rely on clientCutText() to test clipboardPasteFrom().
Samuel Mannehed [Wed, 12 Feb 2020 10:25:04 +0000 (11:25 +0100)]
Merge pull request #1361 from alvintownsend/master
Correcting path to package.json for running at a path other than root.
Alvin Townsend [Fri, 31 Jan 2020 10:34:53 +0000 (11:34 +0100)]
Correcting path to package.json for running at a path other than root.
Samuel Mannehed [Thu, 30 Jan 2020 10:40:44 +0000 (11:40 +0100)]
Fix color channels for VMware alpha cursors
The red and blue channels were incorrectly swapped.
Pierre Ossman [Thu, 23 Jan 2020 13:27:37 +0000 (14:27 +0100)]
Make afterEach() hooks work when skipping tests
Mocha will now run afterEach() hooks when tests are skipped, so we need
to make them more robust against things being partially set up.
Juanjo Diaz [Thu, 23 Jan 2020 09:51:51 +0000 (11:51 +0200)]
Remove generated HTML by Cursor when it detaches
Pierre Ossman [Tue, 14 Jan 2020 08:45:28 +0000 (09:45 +0100)]
Merge branch 'abstraction_for_detection' of https://github.com/samhed/noVNC
Samuel Mannehed [Fri, 3 Jan 2020 09:41:34 +0000 (10:41 +0100)]
Simplify encodeUTF8/decodeUTF8 unittests
Samuel Mannehed [Thu, 2 Jan 2020 16:29:41 +0000 (17:29 +0100)]
Add unit tests for encodeUTF8 and decodeUTF8
Samuel Mannehed [Thu, 2 Jan 2020 12:56:07 +0000 (13:56 +0100)]
Remove unused python scripts
Samuel Mannehed [Thu, 2 Jan 2020 12:24:42 +0000 (13:24 +0100)]
Fix chinese translation for "Disconnect"
Thanks for @wavezhang, @litongjava, and @bhzhu203 for helping out.
Samuel Mannehed [Thu, 2 Jan 2020 12:18:24 +0000 (13:18 +0100)]
Update chinese translation strings
Thanks to @QQ2017 and @wavezhang for helping out with correcting these.
Samuel Mannehed [Thu, 24 Oct 2019 14:43:07 +0000 (16:43 +0200)]
Add comment for browser and platform detection
Samuel Mannehed [Wed, 23 Oct 2019 15:08:56 +0000 (17:08 +0200)]
Add short description at the top of browser.js
Samuel Mannehed [Wed, 23 Oct 2019 15:09:41 +0000 (17:09 +0200)]
Properly detect scrollbar gutter
As a rule, instead of hard-coding a behavior on specific platforms we
should do dynamic detection.
This commit moves away from always hiding scrollbars on Android and iOS
and instead detects the rendered width of scrollbars in the browser.
Samuel Mannehed [Tue, 31 Dec 2019 01:15:07 +0000 (02:15 +0100)]
Remove Google Chrome Frame plugin compatability
Chrome Frame has been retired we so we can remove it from this
compatability tag.
Samuel Mannehed [Tue, 31 Dec 2019 01:07:31 +0000 (02:07 +0100)]
Restore X-UA-Compatible meta tag to vnc_lite
It's still required since without this IE's default setting for "Display intranet web pages in compatibility mode" will cause errors.
Samuel Mannehed [Tue, 31 Dec 2019 01:06:02 +0000 (02:06 +0100)]
Restore X-UA-Compatible meta tag to vnc.html
It's still required since without this IE's default setting for "Display intranet web pages in compatibility mode" will cause errors.
Pierre Ossman [Mon, 30 Dec 2019 08:30:00 +0000 (09:30 +0100)]
Allow cursor to be updated while connecting
We haven't got a server provided cursor at this point, but we might
have done something local, e.g. enabled the dot cursor.
Pierre Ossman [Wed, 25 Dec 2019 11:10:21 +0000 (12:10 +0100)]
Make sure "undefined" can be a default parameter value
Lower layers can consider null to be a valid value, when we'd rather
they treat the value as not set.
Pierre Ossman [Mon, 23 Dec 2019 14:40:17 +0000 (15:40 +0100)]
Handle slow loading of images
Internet Explorer seems to flag images as loaded prematurely, which
can result in rendering bugs. We can detect this by looking at the
dimensions though.
Pierre Ossman [Mon, 23 Dec 2019 14:37:48 +0000 (15:37 +0100)]
Validate decoded image dimensions
They are expected to be a certain size, so verify this so no server
tries to do something broken.
Pierre Ossman [Mon, 23 Dec 2019 14:11:32 +0000 (15:11 +0100)]
Avoid using Array.includes()
Internet Explorer doesn't have this method. Use the safer indexOf()
instead.
Samuel Mannehed [Mon, 23 Dec 2019 09:25:02 +0000 (10:25 +0100)]
Build in the behavior to ignore decodeUTF8 errors
Makes the code clearer and more explicit in intent.
Pierre Ossman [Mon, 23 Dec 2019 08:35:51 +0000 (09:35 +0100)]
Use undefined as the default value for password
An empty password is techincally legal, and now supported by the
RFB core, so we cannot use that as a placeholder for "no password".
Samuel Mannehed [Fri, 20 Dec 2019 23:26:57 +0000 (00:26 +0100)]
Peter is no longer part of the noVNC team
Samuel Mannehed [Sat, 7 Dec 2019 19:12:27 +0000 (20:12 +0100)]
Merge pull request #1327 from vanym/decodeUTF8_try_catch
Fixes exception when desktop name contains non-utf8 character
VanyM [Thu, 5 Dec 2019 19:36:51 +0000 (22:36 +0300)]
Add try catch in every place that uses decodeUTF8
Chris "Koying" Browet [Sat, 3 Aug 2019 07:11:25 +0000 (09:11 +0200)]
Add support for Unix Tight auth
Chris Koying Browet [Thu, 5 Dec 2019 14:34:18 +0000 (15:34 +0100)]
Expand password dialog to work for usernames too
Some VNC authentication schemes use usernames, our UI should support
these.
Samuel Mannehed [Thu, 5 Dec 2019 11:15:43 +0000 (12:15 +0100)]
Merge pull request #1318 from chrisjdev/emptyPassword
Allow connecting with empty string credentials
Chris J [Thu, 7 Nov 2019 20:15:15 +0000 (15:15 -0500)]
Allow connecting with empty string credentials
Checking for undefined instead of falsy. That way an empty strings are allowed.
Samuel Mannehed [Wed, 4 Dec 2019 09:13:25 +0000 (10:13 +0100)]
Add encodeUTF8 function to core/util/strings.js
Pierre Ossman [Fri, 29 Nov 2019 09:08:15 +0000 (10:08 +0100)]
Make Cursor.detach() safe to call when not attached
Avoids having checks in higher layers.
Samuel Mannehed [Thu, 28 Nov 2019 11:51:32 +0000 (12:51 +0100)]
Fix chinese translation errors
Thanks to @QQ2017 for providing the translation strings
Samuel Mannehed [Mon, 25 Nov 2019 16:03:55 +0000 (17:03 +0100)]
Simplify logic for status hierarchy
Removes unnecessary variable
Samuel Mannehed [Mon, 25 Nov 2019 15:38:03 +0000 (16:38 +0100)]
Ensure warning status timeouts are honored
When showing a new status popup we want to set a timer for how long to
show it. In cases where we show many statuses in a fast succession we
need to remove any running timeouts when showing a new one.
There are exceptions when new statuses won't be shown, and thats if a
more severe status is already showing, i.e and error or a warning.
Warnings can still have timeouts. There was a bug that occured when we
tried to show a normal status while a warning was showing. The bug
caused the warning status timeout to be removed even if the normal
status was never shown. We should only remove running timeouts if we're
actually going to show a new status.
Pierre Ossman [Tue, 12 Nov 2019 13:12:18 +0000 (14:12 +0100)]
Merge branch 'babel' of https://github.com/CendioOssman/noVNC
Pierre Ossman [Tue, 12 Nov 2019 09:25:18 +0000 (10:25 +0100)]
Don't use arrow functions in legacy loader
The browsers that need the legacy code do not support such fancy
modern things.
Pierre Ossman [Tue, 12 Nov 2019 09:24:40 +0000 (10:24 +0100)]
Load support scripts first
E.g. SystemJS requires the Promise polyfill, so make sure all our
support files are loaded first.
Pierre Ossman [Mon, 11 Nov 2019 14:46:12 +0000 (15:46 +0100)]
Upgrade to latest babel
There has been a lot of renaming and restructuring in babel, so we need
to modify our code to handle the latest version. We also need to adjust
the way we build our babel worker as babel itself no longer runs in older
browsers such as Internet Explorer.
Samuel Mannehed [Mon, 11 Nov 2019 15:46:36 +0000 (16:46 +0100)]
Merge pull request #1319 from wavezhang/patch-2
Update zh_CN.po
Pierre Ossman [Mon, 11 Nov 2019 12:36:30 +0000 (13:36 +0100)]
Always include Promise polyfill for legacy browsers
It is now used by our general code and not just by the conversion
routines, so we need to make sure it is always included for the
old browsers.
Pierre Ossman [Mon, 11 Nov 2019 12:33:47 +0000 (13:33 +0100)]
Clean up handling of untransformed files
This control flow is difficult enough as it is to follow. Move the
handling of the untransformed files to a separate block to make it
slightly easier to understand.
Pierre Ossman [Mon, 11 Nov 2019 12:32:19 +0000 (13:32 +0100)]
Remove redundant "no copy" check
We also check this list as a filter to walkDir(), so no need for the
extra check here.
Pierre Ossman [Mon, 11 Nov 2019 09:01:43 +0000 (10:01 +0100)]
Use proper backticks for generating legacy script tags
wavezhang [Fri, 8 Nov 2019 06:08:23 +0000 (14:08 +0800)]
Update zh_CN.po
fix spell errors, improve translations
Alex Tanskanen [Thu, 7 Nov 2019 15:19:08 +0000 (16:19 +0100)]
Fix missing caps lock events on iOS
Caps Lock on iOS only trigged key release or key press events.
When it's clicked it would only send keydown, and next time
it would only send keyup and so on. It should send both a key press
and a key release.
Also added the unit tests for macOS since those were missing.
Co-Authored-By: Alex Tanskanen <aleta@cendio.se>
Samuel Mannehed [Thu, 7 Nov 2019 11:49:41 +0000 (12:49 +0100)]
Add README to app/locale warning not to modify
Alex Tanskanen [Mon, 4 Nov 2019 13:22:46 +0000 (14:22 +0100)]
Add "macOS shuffle" to iOS as well
Since iOS functions like macOS with regards to Alt behaving like AltGr,
we need the same workaround on iOS as well.
Pierre Ossman [Mon, 4 Nov 2019 09:17:45 +0000 (10:17 +0100)]
Handle missing Shift events on Windows
This is a bug in the OS that leaks through to the browsers. We need
to fake a Shift release here to avoid Shift getting stuck in the remote
session.
Pierre Ossman [Fri, 1 Nov 2019 12:13:35 +0000 (13:13 +0100)]
Send NumLock on macOS, even though the key is Clear
There is no obvious choice what works best here, but this is what
TigerVNC has been doing for years without complaints. Let's follow
them until we get reports that this doesn't work well.
Pierre Ossman [Fri, 1 Nov 2019 09:49:19 +0000 (10:49 +0100)]
Fix typo for MailSend key
Pierre Ossman [Fri, 1 Nov 2019 09:25:23 +0000 (10:25 +0100)]
Update to latest UI Events key specification
Pierre Ossman [Fri, 1 Nov 2019 08:59:02 +0000 (09:59 +0100)]
Fix AltGr for a few more keys in IE and Edge
Some keys apparently send 'Unidentified' rather than an unshifted value.
Make sure those are also handled. Examples are \ and | on a Swedish
keyboard.
Samuel Mannehed [Thu, 31 Oct 2019 15:24:06 +0000 (16:24 +0100)]
Keep the virtual keyboard after using extra keys
If using the extra keys always gives focus to the screen then an
on-screen keyboard would be closed. When using on-screen keyboards we
instead want to give focus to our virtual keyboard input element.
Pierre Ossman [Thu, 31 Oct 2019 14:36:40 +0000 (15:36 +0100)]
Revert iOS keyup workaround
It seems Apple has fixed their buggy keyup events, so remove the
workaround and allow keys to be kept pressed again.
This is a revert of
9e99ce126ca8f6f350fa015c0e58d35103c62f7e .
Pierre Ossman [Thu, 31 Oct 2019 13:51:36 +0000 (14:51 +0100)]
Handle broken numpad delete key in Chrome
Pierre Ossman [Thu, 31 Oct 2019 13:08:36 +0000 (14:08 +0100)]
Explain why Clear maps to KP_Begin
Pierre Ossman [Thu, 31 Oct 2019 13:07:30 +0000 (14:07 +0100)]
Try to handle Meta key properly
The standards have unfortunatly caused some confusion between the Windows
key and the original Meta key. Try to handle the common case sanely at least.